[ovs-dev] mod_dl_dst corrupted in 1.3.0?

2012-01-11 Thread Yoshi Tamura
Hi, I noticed a weird behavior in openvswitch 1.3.0 that when I install a flow with mod_dl_dst, the packet gets corrupted. I created a deb package from the official 1.3.0 release and installed to my machine. $ dpkg -l | grep openvswitch ii openvswitch-common 1.3.0-1

[ovs-dev] healthcare company information database

2012-01-11 Thread Pedro T Starks
US Healthcare Database - 230,000 emails in 365 categories Price until Friday: $99 CLICK HERE TO ORDER File Available for download in excel format Just a few of the medical specialties available:

[ovs-dev] [PATCH] ofproto: New action TTL decrement.

2012-01-11 Thread Pravin B Shelar
Following patch implements dec_ttl as vendor action with similar semantics as OpenFlow 1.2. If TTL reaches zero while procession actions in current table, the remaining actions in previous tables are processed. An configuration parameter is added to make TTL decrement to zero generate packet in. F

[ovs-dev] hello

2012-01-11 Thread caliste423
Hi Dear ! How are you doing today i,hope every thing is fine,? if so thanks be to God My name is calister and i am a girl. I saw a profile about you in the google search so I decided to extend my greetings to you I do have the mind that you could be a nice person I have an interest to meet peo

[ovs-dev] [PATCH] datapath: IFF_OVS_DATAPATH is backported by RHEL 6.2.

2012-01-11 Thread Jesse Gross
On kernels 2.6.37 and above IFF_OVS_DATAPATH has a unique value upstream, on 2.6.36 we define it to be IFF_BRIDGE_DATAPATH and below to 0. There isn't really a good reason to use IFF_BRIDGE_DATAPATH on 2.6.36 (and it's perhaps bad because it's checked in a few places and we don't want those checks

Re: [ovs-dev] [of1.1 2/3] ofp-util: Extend message decoding data structures with version field.

2012-01-11 Thread Ethan Jackson
Looks good. Ethan On Wed, Dec 14, 2011 at 10:01, Ben Pfaff wrote: > This makes it possible to add entries for decoding OpenFlow messages with > newer versions, e.g. OpenFlow 1.1 or 1.2.  However, no actual messages for > newer versions are actually implemented yet; that will come later. > --- >

Re: [ovs-dev] [of1.1 1/3] nicira-ext: Rename "struct nxt_*" to "struct nx_*".

2012-01-11 Thread Ethan Jackson
Looks good. Be sure to update nxt_set_packet_in_format and nxt_packet_in when you rebase. Ethan On Wed, Dec 14, 2011 at 10:01, Ben Pfaff wrote: > Most structures in this file have an "nx_" prefix, so this makes naming > more consistent. > --- >  include/openflow/nicira-ext.h |   10 +- >

Re: [ovs-dev] [PATCH] vswitchd: Document maximum queue_id for Linux QoS.

2012-01-11 Thread Ethan Jackson
> (I guess "noninclusive" is the new "exclusive"?  :-) Now now, lets be nonnoninclusive of different writing styles. (I'll change it) Ethan ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] vswitchd: Document maximum queue_id for Linux QoS.

2012-01-11 Thread Ben Pfaff
On Wed, Jan 11, 2012 at 02:18:53PM -0800, Ethan Jackson wrote: > The code enforces a noninclusive maximum of 0xf000 on queue_ids for > Linux queueing disciplines, but the documentation doesn't mention > this limitation. > > Reported-by: Michael Mao > Signed-off-by: Ethan Jackson Looks good. (I

[ovs-dev] [PATCH] vswitchd: Document maximum queue_id for Linux QoS.

2012-01-11 Thread Ethan Jackson
The code enforces a noninclusive maximum of 0xf000 on queue_ids for Linux queueing disciplines, but the documentation doesn't mention this limitation. Reported-by: Michael Mao Signed-off-by: Ethan Jackson --- vswitchd/vswitch.xml | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(

Re: [ovs-dev] [PATCH] datapath: Fix multipart datapath dumps.

2012-01-11 Thread Ben Pfaff
On Wed, Jan 11, 2012 at 01:57:05PM -0800, Jesse Gross wrote: > On Wed, Jan 11, 2012 at 10:03 AM, Ben Pfaff wrote: > > On Tue, Jan 10, 2012 at 05:20:27PM -0800, Jesse Gross wrote: > >> On Tue, Jan 10, 2012 at 4:52 PM, Ben Pfaff wrote: > >> > The logic to split up the list of datapaths into multipl

Re: [ovs-dev] [PATCH] datapath: Fix multipart datapath dumps.

2012-01-11 Thread Jesse Gross
On Wed, Jan 11, 2012 at 10:03 AM, Ben Pfaff wrote: > On Tue, Jan 10, 2012 at 05:20:27PM -0800, Jesse Gross wrote: >> On Tue, Jan 10, 2012 at 4:52 PM, Ben Pfaff wrote: >> > The logic to split up the list of datapaths into multiple Netlink messages >> > was simply wrong, causing the list to be term

Re: [ovs-dev] [PATCH] dpif-netdev: Make port numbers predictable for dummy dpif, for unit tests.

2012-01-11 Thread Ethan Jackson
> +choose_port(struct dpif *dpif, struct netdev *netdev) >  { >     struct dp_netdev *dp = get_dp_netdev(dpif); >     int port_no; > > +    if (dpif->dpif_class == &dpif_dummy_class) { > +        /* If the port name contains a number, try to assign that port > number. > +         * This can make w

Re: [ovs-dev] [PATCH v2] odp-util: Handle ipv6 in set nw action.

2012-01-11 Thread Pravin Shelar
Thanks, I pushed to master. --Pravin. On Wed, Jan 11, 2012 at 12:34 PM, Ben Pfaff wrote: > On Wed, Jan 11, 2012 at 12:32:37PM -0800, Pravin B Shelar wrote: >> v1-v2: >>         - Added nw_proto check in IPv4/IPv6 set action. >>         - Removed assert from user-space datapath. >>         - Adde

Re: [ovs-dev] [PATCH v2] odp-util: Handle ipv6 in set nw action.

2012-01-11 Thread Ben Pfaff
On Wed, Jan 11, 2012 at 12:32:37PM -0800, Pravin B Shelar wrote: > v1-v2: > - Added nw_proto check in IPv4/IPv6 set action. > - Removed assert from user-space datapath. > - Added check for IPv4 in mod_nw_tos. > > --8<--cut here---

[ovs-dev] [PATCH v2] odp-util: Handle ipv6 in set nw action.

2012-01-11 Thread Pravin B Shelar
v1-v2: - Added nw_proto check in IPv4/IPv6 set action. - Removed assert from user-space datapath. - Added check for IPv4 in mod_nw_tos. --8<--cut here-->8- Rather than silently skipping ipv6 action generation, following patch

Re: [ovs-dev] [PATCH] ofproto-dpif: Honor statistics in packet_out().

2012-01-11 Thread Ethan Jackson
Thanks, I've pushed this. Ethan On Wed, Jan 11, 2012 at 11:28, Ben Pfaff wrote: > Thanks, I'm happy with this. > > On Wed, Jan 11, 2012 at 11:27:00AM -0800, Ethan Jackson wrote: >> I agree this is a bit subtle.  Here's an updated version of the patch. >> >> --- >> A "packet out" ordinarily isn'

Re: [ovs-dev] [PATCH] Don't specify program name in passive connection man page fragments.

2012-01-11 Thread Justin Pettit
On Jan 11, 2012, at 11:07 AM, Ben Pfaff wrote: > On Wed, Jan 11, 2012 at 11:05:41AM -0800, Justin Pettit wrote: >> The vconn and ovsdb passive connection man page fragments used the >> PN (program name) macro to describe their functionality. This was >> usually correct, but in the case of ovs-vsc

Re: [ovs-dev] [PATCH] ofproto-dpif: Honor statistics in packet_out().

2012-01-11 Thread Ben Pfaff
Thanks, I'm happy with this. On Wed, Jan 11, 2012 at 11:27:00AM -0800, Ethan Jackson wrote: > I agree this is a bit subtle. Here's an updated version of the patch. > > --- > A "packet out" ordinarily isn't accounted to any OpenFlow rule, > because its actions come directly from the controller in

[ovs-dev] [PATCH] ofproto-dpif: Honor statistics in packet_out().

2012-01-11 Thread Ethan Jackson
I agree this is a bit subtle. Here's an updated version of the patch. --- A "packet out" ordinarily isn't accounted to any OpenFlow rule, because its actions come directly from the controller instead of from an OpenFlow rule. However, any "resubmit" actions or output to OFPP_TABLE within the set

Re: [ovs-dev] [PATCH] Don't specify program name in passive connection man page fragments.

2012-01-11 Thread Ben Pfaff
On Wed, Jan 11, 2012 at 11:05:41AM -0800, Justin Pettit wrote: > The vconn and ovsdb passive connection man page fragments used the > PN (program name) macro to describe their functionality. This was > usually correct, but in the case of ovs-vsctl, they may be used to > describe configuring ovs-vs

[ovs-dev] [PATCH] Don't specify program name in passive connection man page fragments.

2012-01-11 Thread Justin Pettit
The vconn and ovsdb passive connection man page fragments used the PN (program name) macro to describe their functionality. This was usually correct, but in the case of ovs-vsctl, they may be used to describe configuring ovs-vswitchd. This commit rewords the fragments to make them correct regardl

Re: [ovs-dev] [PATCH] ovsdb-tool: Use typical db and schema install locations as defaults.

2012-01-11 Thread Ben Pfaff
Thank you. I pushed this to master. On Tue, Jan 10, 2012 at 06:15:34PM -0800, Ethan Jackson wrote: > Looks good. > > Ethan > > On Wed, Nov 30, 2011 at 14:09, Ben Pfaff wrote: > > This makes ovsdb-tool easier to use in the common case. > > > > Requested-by: Reid Price > > Feature #7756. > > --

[ovs-dev] milestone

2012-01-11 Thread Ben Pfaff
## - ## ## Test results. ## ## - ## 1000 tests were successful. 2 tests were skipped. That's a lot of tests. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ofproto-dpif: Restore optimization for no-actions case (without leak).

2012-01-11 Thread Ben Pfaff
Thanks. I'm going to sit on this for a while to give the fixed code a chance to get tested. On Tue, Jan 10, 2012 at 05:01:08PM -0800, Ethan Jackson wrote: > The memory management in this function is a bit confusing so I had to > think about it a bit, but this looks correct to me. > > Ethan > >

Re: [ovs-dev] [PATCH] ofproto-dpif: Honor statistics in packet_out().

2012-01-11 Thread Ben Pfaff
On Tue, Jan 10, 2012 at 08:19:17PM -0800, Ethan Jackson wrote: > Reported-by: Jesse Gross > Signed-off-by: Ethan Jackson > --- > > Jesse tested this, I've only compiled it. The patch looks good, but it took me a while to understand the rationale here. Let me add to your changelog (or you can e

Re: [ovs-dev] [PATCH] datapath: Fix multipart datapath dumps.

2012-01-11 Thread Ben Pfaff
On Tue, Jan 10, 2012 at 05:20:27PM -0800, Jesse Gross wrote: > On Tue, Jan 10, 2012 at 4:52 PM, Ben Pfaff wrote: > > The logic to split up the list of datapaths into multiple Netlink messages > > was simply wrong, causing the list to be terminated after the first part. > > Only about the first 50

Re: [ovs-dev] [PATCH] docs: New 'man-pdf' Makefile target to generate PDF versions of manpages.

2012-01-11 Thread Ben Pfaff
Hmm. That target usually generated PDF versions of Texinfo documents, not PDF versions of manpages. It might still be appropriate. I'm not sure that /usr/share/doc is a good place to install manpages. I'm going to think about this for a while. On Tue, Jan 10, 2012 at 10:44:24PM -0800, Romain L

Re: [ovs-dev] [PATCH 2/2] ovs-vsctl: Add set relational operators to "find" command.

2012-01-11 Thread Ben Pfaff
Thanks. I'm not too worried about someone deleting the blank lines, since that mistake will get caught immediately. On Tue, Jan 10, 2012 at 05:57:31PM -0800, Ethan Jackson wrote: > Looks good. > > In the tests I think it would be a good idea to add a comment > explaining why there are so many bl

Re: [ovs-dev] [PATCH 1/2] ovsdb-data: Short-circuit ovsdb_datum_includes_all() in trivial case.

2012-01-11 Thread Ben Pfaff
Right, in fact both 'a' and 'b' must be in sorted order, as specified by the invariants documented for ovsdb_datum. I don't remember why I was looking at this (it's over a month old). It wasn't a performance problem. On Tue, Jan 10, 2012 at 05:33:10PM -0800, Ethan Jackson wrote: > I'm assuming t