On Tue, Dec 27, 2011 at 2:27 AM, Simon Horman wrote:
> On Tue, Dec 27, 2011 at 10:29:55AM +0900, Simon Horman wrote:
>> On Mon, Dec 26, 2011 at 03:11:40PM -0500, Jesse Gross wrote:
>> > On Fri, Dec 16, 2011 at 3:47 AM, Simon Horman wrote:
>> > > Hi,
>> > >
>> > > I have observed high rates of pac
On Wed, Dec 28, 2011 at 7:20 PM, Ben Pfaff wrote:
> diff --git a/datapath/vport-internal_dev.c b/datapath/vport-internal_dev.c
> index c56f3b2..31d55fc 100644
> --- a/datapath/vport-internal_dev.c
> +++ b/datapath/vport-internal_dev.c
> @@ -94,11 +94,21 @@ static int internal_dev_mac_addr(struct n
Depend on python (>= 2.7) | python-argparse instead of
python-argparse to avoid pulling in python2.6
See: http://bugs.debian.org/653645
Signed-off-by: Simon Horman
---
debian/changelog |3 +++
debian/control |6 --
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/deb
On Thu, Dec 29, 2011 at 11:00:24AM -0800, Ethan Jackson wrote:
> Sounds good. Here is an incremental.
The incremental looks good. Thank you.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Package: openvswitch-common
Version: 1.3.0-1
Severity: normal
The unconditional dependency on python-argparse always pulls in python2.6.
argparse was included in python2.7
Please change the argparse dependency to
python (>= 2.7) | python-argparse
> I guess we need to set up a primary controller to test packet buffering?
> All of these packets are unbuffered. Oh well, packet buffering probably
> should have its own tests anyway.
I was mostly interested in verifying that the future patches result in
controller actions generating correct pac
I added the following to the NEWS section.
+- ovs-ofctl:
+- Added daemonization support to the monitor and snoop commands.
On Thu, Dec 29, 2011 at 01:19, Ben Pfaff wrote:
> On Wed, Dec 28, 2011 at 05:52:34PM -0800, Ethan Jackson wrote:
>> This will ease implementation of future unit
Please review this version.
Ethan
On Thu, Dec 29, 2011 at 16:05, Ethan Jackson wrote:
> The new PACKET_IN format implemented in this patch includes flow
> metadata such as the cookie, table_id, and registers.
>
> Signed-off-by: Ethan Jackson
> ---
> include/openflow/nicira-ext.h | 46 +++
The new PACKET_IN format implemented in this patch includes flow
metadata such as the cookie, table_id, and registers.
Signed-off-by: Ethan Jackson
---
include/openflow/nicira-ext.h | 46 +-
lib/learning-switch.c |2 +
lib/nx-match.h|2 +-
lib/ofp-pr
Sounds good, this is what I've originally implemented so I'll stick with it in
accordance to your suggestion. I need to resend this patch due to rebasing from
master. Please don't review until then.
Ethan (iPhone)
On Dec 29, 2011, at 14:38, Justin Pettit wrote:
> I would leave it as a separa
I would leave it as a separate field in the packet_in. We don't have a way of
indicating whether a flow has a valid cookie or not, so we would always have to
add a NXM_NX_COOKIE field. Also, the match wouldn't be the same as the flow
that was originally pushed, since the cookie is part of the
Sounds good. Here is an incremental.
---
INSTALL.Linux |5 -
lib/ofp-print.c|5 +
tests/ofp-print.at |6 +-
3 files changed, 2 insertions(+), 14 deletions(-)
diff --git a/INSTALL.Linux b/INSTALL.Linux
index 7a55ccd..8ef2315 100644
--- a/INSTALL.Linux
+++ b/INSTAL
Please refrain from reviewing this patch temporarily.
Given recent changes to master, do you think it makes sense to encode
the cookie directly in the packet_in structure, or to encode it as
part of the NXM in the packet_in structure using NXM_NX_COOKIE.
Furthermore, I wonder if it makes sense to
On Wed, Dec 28, 2011 at 05:52:38PM -0800, Ethan Jackson wrote:
> This commit pulls code used to modify L3 and L4 header fields
> from dp_netdev into the packet library. An additional user will
> be added in a future commit.
Looks good to me, thank you.
This is the direction that I want to move in anyhow, for supporting
OpenFlow 1.1 and later. Thanks for doing this.
One comment: other ofputil_decode_*() functions call
ofputil_decode_msg_type() and check the result because they can actually
decode more than one message format. But this function
On Wed, Dec 28, 2011 at 05:52:36PM -0800, Ethan Jackson wrote:
> This will make the memory ownership clearer when future patches
> make more extensive use of ofputil_packet_in.
This does seem like an improvement. Did you also consider replacing the
ofpbuf pointer by pointer and length members?
T
Thank you for writing these tests!
Ethernet source addresses shouldn't have the multicast bit set. I guess
it doesn't matter for these tests but it's setting a bad example.
It's probably better to use the [stderr] special case for AT_CHECK (see
the Autoconf manual) rather than to explicitly redi
17 matches
Mail list logo
