> If you are working entirely in python, you could switch some of this errno
> passing into something more exception-based, it might look a little more
> natural.
I personally find exceptions aesthetically displeasing. They make
code hard to reason about. That said, I agree, if I were to rewrite
LGTM
On Fri, Sep 16, 2011 at 4:49 PM, Ethan Jackson wrote:
> The python style guide requires two newlines between top level
> definitions. This patch also removes some trailing whitespace.
> ---
> python/ovs/daemon.py | 34 +-
> 1 files changed, 29 insertions(
LGTM
On Fri, Sep 16, 2011 at 4:49 PM, Ethan Jackson wrote:
> By convention, unused arguments should be named "_" and top level
> definitions should be separated by two spaces.
> ---
> tests/test-daemon.py |5 -
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/tests/te
Seems reasonable.
If you are working entirely in python, you could switch some of this errno
passing into something more exception-based, it might look a little more
natural.
On Fri, Sep 16, 2011 at 4:49 PM, Ethan Jackson wrote:
> Pychecker complains about __read_pidfile() having too may return
Didn't look at the entire file, but the patch seems obviously correct.
On Fri, Sep 16, 2011 at 6:28 PM, Ethan Jackson wrote:
> Pychecker considers it bad style.
> ---
>
> The original version of this patch that I sent out broke the unit tests.
> Please review this version.
>
> ---
> python/ovs/
