LGTM On Fri, Sep 16, 2011 at 4:49 PM, Ethan Jackson <et...@nicira.com> wrote:
> By convention, unused arguments should be named "_" and top level > definitions should be separated by two spaces. > --- > tests/test-daemon.py | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/tests/test-daemon.py b/tests/test-daemon.py > index 350b8f7..816304f 100644 > --- a/tests/test-daemon.py > +++ b/tests/test-daemon.py > @@ -21,9 +21,11 @@ import time > import ovs.daemon > import ovs.util > > -def handler(signum, frame): > + > +def handler(signum, _): > raise Exception("Signal handler called with %d" % signum) > > + > def main(argv): > logging.basicConfig(level=logging.DEBUG) > > @@ -57,6 +59,7 @@ def main(argv): > while True: > time.sleep(1) > > + > def usage(): > sys.stdout.write("""\ > %s: Open vSwitch daemonization test program for Python > -- > 1.7.6.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev >
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev