[ovs-dev] [mcgroup 4/4] dpif-linux: Handle nl_lookup_genl_mcgroup() failures.

2011-09-14 Thread Ethan Jackson
The nl_lookup_genl_mcgroup() function can fail on older kernels which do not support the required netlink interface. Before this patch, dpif-linux would refuse to create a datapath when this happened. With this patch, it attempts to use a workaround. If the workaround fails it simply disables th

[ovs-dev] [mcgroup 3/4] dpif-linux: Open dpif despite notifier failures.

2011-09-14 Thread Ethan Jackson
Before this patch, if dpif-linux failed to register a notifier it would give up opening the datapath entirely. This seems draconian as a dpif can still perform the majority of its intended functionality without vport notifications. --- lib/dpif-linux.c | 23 +++ 1 files chan

[ovs-dev] [mcgroup 1/4] nln: Allow unregister when register fails.

2011-09-14 Thread Ethan Jackson
Quite a bit of code in OVS ignores the return code of nln_notifier_register() and will nln_notifier_unregister() on notifiers which failed to register in the first place. This can cause segmentation faults. Instead of forcing every caller to remember whether or not registration failed, this patch

[ovs-dev] [mcgroup 2/4] datapath: Hardcode vport multicast group ID on older kernels.

2011-09-14 Thread Ethan Jackson
Older kernels do not advertise the multicast groups of families when requested by userspace. As a workaround, this patch hardcodes the multicast group ID of the ovs_vport family on these kernels. Userspace will be able to fall back to this hardcoded value if the standard mechanism is unavailable.

Re: [ovs-dev] [PATCH] Fix tunnel lookup

2011-09-14 Thread Jesse Gross
On Wed, Sep 14, 2011 at 5:27 PM, Pravin Shelar wrote: >        Attached patch fixes tunnel lookup to do correct port comparison. > This bug is introduced by commit 3544358aa5960b148bc31435a0062e9392530ec2 > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross _

[ovs-dev] [PATCH] Fix tunnel lookup

2011-09-14 Thread Pravin Shelar
Attached patch fixes tunnel lookup to do correct port comparison. This bug is introduced by commit 3544358aa5960b148bc31435a0062e9392530ec2 Signed-off-by: Pravin B Shelar --- datapath/tunnel.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/datapath/tunnel.c b/

Re: [ovs-dev] [PATCH] datapath: Set vport in skb when executed from userspace.

2011-09-14 Thread Jesse Gross
On Tue, Sep 13, 2011 at 6:43 PM, Ben Pfaff wrote: > On Tue, Sep 13, 2011 at 04:43:32PM -0700, Jesse Gross wrote: >> +     if (flow->key.eth.in_port != USHRT_MAX) >> +             OVS_CB(packet)->vport = get_vport_protected(dp, >> +                                                     flow->key.eth.