Thanks. I pushed it.
--Justin
On Aug 15, 2011, at 3:24 PM, Ben Pfaff wrote:
> Looks good.
>
> On Mon, Aug 15, 2011 at 01:55:35PM -0700, Justin Pettit wrote:
>> ---
>> vswitchd/vswitch.xml |3 ---
>> 1 files changed, 0 insertions(+), 3 deletions(-)
>>
>> diff --git a/vswitchd/vswitch.xml b
Thanks, I pushed this.
On Mon, Aug 15, 2011 at 03:19:19PM -0700, Ethan Jackson wrote:
> Looks good,
>
> I noticed that quite a while ago, probably should have fixed it then.
>
> Ethan
>
> On Mon, Aug 15, 2011 at 15:18, Ben Pfaff wrote:
> > This is not a bug yet, but it could be the next time s
Looks good.
On Mon, Aug 15, 2011 at 01:55:35PM -0700, Justin Pettit wrote:
> ---
> vswitchd/vswitch.xml |3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
> index f56e670..6082256 100644
> --- a/vswitchd/vswitch.xml
> +++ b
Looks good,
I noticed that quite a while ago, probably should have fixed it then.
Ethan
On Mon, Aug 15, 2011 at 15:18, Ben Pfaff wrote:
> This is not a bug yet, but it could be the next time someone carelessly
> adds a new case.
> ---
> lib/ofp-print.c | 1 +
> 1 files changed, 1 insertions
This is not a bug yet, but it could be the next time someone carelessly
adds a new case.
---
lib/ofp-print.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/lib/ofp-print.c b/lib/ofp-print.c
index 4c94ebb..d7804fe 100644
--- a/lib/ofp-print.c
+++ b/lib/ofp-print.c
@@ -368,
---
vswitchd/vswitch.xml |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
index f56e670..6082256 100644
--- a/vswitchd/vswitch.xml
+++ b/vswitchd/vswitch.xml
@@ -680,9 +680,6 @@
Key-value pairs for configuring rarely us
On Mon, Aug 15, 2011 at 05:34:08AM -0700, pravin shelar wrote:
>This patch makes sampling support more generic/simple by adding
> Datapath SAMPLING action. When sampling is turned on, a SAMPLING
> action is added to all flows for given bridge.
>This patch cleanup sampling upcall by stripi
That's good enough for me. Thanks, I pushed these.
On Mon, Aug 15, 2011 at 01:26:24PM -0700, Ethan Jackson wrote:
> I would strongly agree that they should be merged to branch-1.2 fwiw.
>
> Ethan
>
> On Mon, Aug 15, 2011 at 13:21, Ben Pfaff wrote:
> > These bug-fix commits are already on maste
I would strongly agree that they should be merged to branch-1.2 fwiw.
Ethan
On Mon, Aug 15, 2011 at 13:21, Ben Pfaff wrote:
> These bug-fix commits are already on master. I think that they should
> go on branch-1.2 also. Let me know if you think there are others, or
> if you disagree with thes
This series seems fine to me.
On Mon, Aug 15, 2011 at 13:21, Ben Pfaff wrote:
> Reported-by: Ethan Jackson
> ---
> lib/ofp-parse.c | 12 +---
> 1 files changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/lib/ofp-parse.c b/lib/ofp-parse.c
> index 58b0da1..d6be774 100644
> --- a/l
Reported-by: Ethan Jackson
---
lib/ofp-parse.c | 12 +---
1 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/lib/ofp-parse.c b/lib/ofp-parse.c
index 58b0da1..d6be774 100644
--- a/lib/ofp-parse.c
+++ b/lib/ofp-parse.c
@@ -781,14 +781,20 @@ parse_field_value(struct cls_rule *r
These bug-fix commits are already on master. I think that they should
go on branch-1.2 also. Let me know if you think there are others, or
if you disagree with these. I'll push them tomorrow if I don't hear
objections.
Thanks,
Ben.
Ben Pfaff (1):
ofp-parse: Fix parsing of register values 2*
From: Ethan Jackson
This patch fixes a bug introduced in Commit 43edca57 "nx-match: New
helpers.", which caused the "move" action to improperly handle bit
ranges.
---
lib/nx-match.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/nx-match.c b/lib/nx-match.c
index e6
On Mon, Aug 15, 2011 at 01:07:10PM -0700, Justin Pettit wrote:
> On Aug 15, 2011, at 11:10 AM, Ben Pfaff wrote:
>
> > @@ -696,7 +696,7 @@ Does nothing at all. Any number of bytes represented
> > as hex digits
> > \fIhh\fR may be included. Pairs of hex digits may be separated by
> > periods for
On Aug 15, 2011, at 11:10 AM, Ben Pfaff wrote:
> @@ -696,7 +696,7 @@ Does nothing at all. Any number of bytes represented as
> hex digits
> \fIhh\fR may be included. Pairs of hex digits may be separated by
> periods for readability.
> .
> -.IP
> "\fBmove:\fIsrc\fB[\fIstart\fB..\fIend\fB]->\fId
This patch makes sampling support more generic/simple by adding
Datapath SAMPLING action. When sampling is turned on, a SAMPLING
action is added to all flows for given bridge.
This patch cleanup sampling upcall by striping it down to minimum
essential that userspace can not figure out for
---
utilities/ovs-ofctl.8.in |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in
index f4e223e..9051170 100644
--- a/utilities/ovs-ofctl.8.in
+++ b/utilities/ovs-ofctl.8.in
@@ -676,7 +676,7 @@ did not support recursion;
I have a story there. I had a whole "counted list" implementation
ready to go, and then when I went through the tree to find potential
users I found only two. And then when I looked closer I found that
they didn't really need to count. And that's why there's this patch
series that makes them not
Okay, sounds good. It's not large enough that it makes sense to make the lists
counting or anything.
--Justin
On Aug 15, 2011, at 9:03 AM, Ben Pfaff wrote:
> When I occasionally look, I usually see about a dozen or so. Not
> enough to concern me, anyway. Some are probably duplicates (same f
Thanks, I'll push this soon.
On Fri, Aug 12, 2011 at 04:51:01PM -0700, Justin Pettit wrote:
> Looks fine to me.
>
> --Justin
>
>
> On Aug 10, 2011, at 3:05 PM, Ben Pfaff wrote:
>
> > ---
> > ofproto/connmgr.c |7 ---
> > ofproto/connmgr.h |1 -
> > 2 files changed, 0 insertions(+), 8
When I occasionally look, I usually see about a dozen or so. Not
enough to concern me, anyway. Some are probably duplicates (same fd).
On Fri, Aug 12, 2011 at 05:06:06PM -0700, Justin Pettit wrote:
> It looks fine, but do we have an idea on the number of waiters that typically
> exist?
>
> --J
Hi Ben
Excerpts from Ben Pfaff's message of 2011-08-15 00:04:46 +0200:
> On Sun, Aug 14, 2011 at 07:08:35PM +0200, Gaudenz Steinlin wrote:
> > Please add support for automatically building the modules with DKMS. The
> > virtualbox-source package is an example of a kernel module source
> > package
22 matches
Mail list logo