On Mon, Aug 15, 2011 at 05:34:08AM -0700, pravin shelar wrote: > This patch makes sampling support more generic/simple by adding > Datapath SAMPLING action. When sampling is turned on, a SAMPLING > action is added to all flows for given bridge. > This patch cleanup sampling upcall by striping it down to minimum > essential that userspace can not figure out for itself. Now sample > packet is sent along with actions checksum. So that sflow module can > make sure it has consistent actions. > > Signed-off-by: Pravin Shelar <pshe...@nicira.com>
Jesse is the maintainer of this code but I have a few minor comments anyway. The whole commit message seems to be indented by one space. The comment on ODP_ACTION_ATTR_SAMPLING is wrong. The kerneldoc comment on ODP_PACKET_ATTR_PACKET needs to be updated because the following sentence now also, I believe, applies to packets obtained by sampling too: "For %ODP_PACKET_CMD_ACTION, %ODP_PACKET_ATTR_PACKET reflects changes made by actions preceding %ODP_ACTION_ATTR_USERSPACE, but %ODP_PACKET_ATTR_KEY is the flow key extracted from the packet as originally received." _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
