Re: [ovs-dev] openflow 1.1

2011-06-20 Thread Justin Pettit
On Jun 20, 2011, at 8:36 PM, Ben Pfaff wrote: > On Tue, Jun 21, 2011 at 12:08:17PM +0900, YAMAMOTO Takashi wrote: >> is anyone working on implementing OF 1.1? >> particularly i'm interested in MPLS stuff. > > I don't know anyone working on implementing OF 1.1. I just wanted to add that OpenFlow

Re: [ovs-dev] openflow 1.1

2011-06-20 Thread Ben Pfaff
On Tue, Jun 21, 2011 at 12:08:17PM +0900, YAMAMOTO Takashi wrote: > is anyone working on implementing OF 1.1? > particularly i'm interested in MPLS stuff. I don't know anyone working on implementing OF 1.1. (MPLS could be implemented without implementing OF 1.1, though.) _

[ovs-dev] openflow 1.1

2011-06-20 Thread YAMAMOTO Takashi
hi, is anyone working on implementing OF 1.1? particularly i'm interested in MPLS stuff. YAMAMOTO Takashi ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] ovsdb-idl: Plug hole in state machine.

2011-06-20 Thread Ben Pfaff
The state machine didn't have a proper state for "not yet committed or aborted", which meant that destroying an ovsdb_idl_txn without committing or aborting it caused a segfault. This fixes the problem by adding a new state TXN_UNCOMMITTED to the state machine. This is related to commit 79554078d

Re: [ovs-dev] [PATCH 2/2] debian: Add "force-reload-kmod" command to /etc/init.d/openvswitch-switch.

2011-06-20 Thread Andrew Evans
On Mon, 2011-06-20 at 15:32 -0700, Ben Pfaff wrote: > On Mon, Jun 20, 2011 at 03:05:11PM -0700, Andrew Evans wrote: > > On Mon, Jun 20, 2011 at 2:50 PM, Ben Pfaff wrote: > > > On Mon, Jun 20, 2011 at 02:45:46PM -0700, Andrew Evans wrote: > > >> Does anything unlink $script on exit (normal or other

Re: [ovs-dev] [PATCH 2/2] debian: Add "force-reload-kmod" command to /etc/init.d/openvswitch-switch.

2011-06-20 Thread Ben Pfaff
On Mon, Jun 20, 2011 at 03:05:11PM -0700, Andrew Evans wrote: > On Mon, Jun 20, 2011 at 2:50 PM, Ben Pfaff wrote: > > On Mon, Jun 20, 2011 at 02:45:46PM -0700, Andrew Evans wrote: > >> Does anything unlink $script on exit (normal or otherwise)? > > > > No, this feature is experimental enough that

[ovs-dev] [PATCH] vlog: Add a little more detail to ratelimit messages

2011-06-20 Thread Ben Pfaff
When a message is suppressed by vlog ratelimiting, and then that message occurs again much later, sometimes we get messages like this: Dropped 4 log messages in last 8695 seconds due to excessive rate It seems pretty clear in this case that in fact we just didn't get that kind of message for m

Re: [ovs-dev] [PATCH 2/2] debian: Add "force-reload-kmod" command to /etc/init.d/openvswitch-switch.

2011-06-20 Thread Andrew Evans
On Mon, Jun 20, 2011 at 2:50 PM, Ben Pfaff wrote: > On Mon, Jun 20, 2011 at 02:45:46PM -0700, Andrew Evans wrote: >> Does anything unlink $script on exit (normal or otherwise)? > > No, this feature is experimental enough that I suspect we'll need to > collect the generated scripts for debugging fr

Re: [ovs-dev] [PATCH 2/2] debian: Add "force-reload-kmod" command to /etc/init.d/openvswitch-switch.

2011-06-20 Thread Ben Pfaff
On Mon, Jun 20, 2011 at 02:45:46PM -0700, Andrew Evans wrote: > On Wed, Jun 15, 2011 at 1:35 PM, Ben Pfaff wrote: > > This can be useful for upgrades when there's no time for a reboot. > > This is essentially cut-and-paste of the version already in > > xenserver/etc_init.d_openvswitch with a few a

Re: [ovs-dev] [PATCH 2/2] debian: Add "force-reload-kmod" command to /etc/init.d/openvswitch-switch.

2011-06-20 Thread Andrew Evans
On Wed, Jun 15, 2011 at 1:35 PM, Ben Pfaff wrote: > This can be useful for upgrades when there's no time for a reboot. > This is essentially cut-and-paste of the version already in > xenserver/etc_init.d_openvswitch with a few adaptations for Debian. > > This code probably won't last very long, be

Re: [ovs-dev] [rhel v2 1/2] Fix force-reload-kmod initscript command implementations.

2011-06-20 Thread Ben Pfaff
On Mon, Jun 20, 2011 at 02:20:32PM -0700, Andrew Evans wrote: > On Mon, 2011-06-20 at 13:25 -0700, Ben Pfaff wrote: > > I screwed this up in the recent conversion. > > > > Signed-off-by: Ben Pfaff > > Acked-by: Andrew Evans Thanks, I'll push this. __

[ovs-dev] [bug5961 3/3] bridge: Enable system stats only if turned on in the database.

2011-06-20 Thread Ben Pfaff
Most hypervisors have no use for this column, so populating it just wastes CPU time. It can still be enabled explicitly via other-config. CC: Peter Balland CC: David Tsai Bug #5961. NIC-397. --- vswitchd/bridge.c | 21 - vswitchd/vswitch.ovsschema |6 --

[ovs-dev] [bug5961 1/3] ovsdb-idl: Improve comment.

2011-06-20 Thread Ben Pfaff
--- lib/ovsdb-idl.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c index 94784bd..f4daaed 100644 --- a/lib/ovsdb-idl.c +++ b/lib/ovsdb-idl.c @@ -1640,7 +1640,11 @@ ovsdb_idl_txn_complete(struct ovsdb_idl_txn *txn, * been disabled (

[ovs-dev] [bug5961 2/3] ovsdb-doc: Add support for references to specific keys.

2011-06-20 Thread Ben Pfaff
Now a specific key can be referenced with syntax like . Also fixes up an existing place that needed this feature already (and had a typo, too). --- ovsdb/ovsdb-doc.in |2 ++ vswitchd/vswitch.xml |7 +++ 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/ovsdb/ovsdb-doc.i

Re: [ovs-dev] [rhel v2 1/2] Fix force-reload-kmod initscript command implementations.

2011-06-20 Thread Andrew Evans
On Mon, 2011-06-20 at 13:25 -0700, Ben Pfaff wrote: > I screwed this up in the recent conversion. > > Signed-off-by: Ben Pfaff Acked-by: Andrew Evans ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [rhel v2 2/2] Add RHEL 5/6 spec files and instructions.

2011-06-20 Thread Ben Pfaff
--- INSTALL.RHEL | 61 + Makefile.am|2 + README |9 +- rhel/.gitignore|3 + rhel/automake.mk

[ovs-dev] [rhel v2 1/2] Fix force-reload-kmod initscript command implementations.

2011-06-20 Thread Ben Pfaff
I screwed this up in the recent conversion. Signed-off-by: Ben Pfaff --- debian/openvswitch-switch.init | 42 +++-- xenserver/etc_init.d_openvswitch |4 +- 2 files changed, 28 insertions(+), 18 deletions(-) diff --git a/debian/openvswitch-switch.init b/de

[ovs-dev] [rhel v2 0/2] second version of RHEL RPM support

2011-06-20 Thread Ben Pfaff
Here's another version of the RHEL support patch. I've applied all of the comments from Andrew and Justin. Andrew's point that I wasn't building the kernel modules properly for RHEL means that all of the kernel RPM support has been redone. This patch also adds support for RHEL 6. The first patc

Re: [ovs-dev] [rhel-5.6 2/2] Add RHEL-5.6 spec file and instructions.

2011-06-20 Thread Ben Pfaff
On Mon, Jun 20, 2011 at 12:39:33AM -0700, Justin Pettit wrote: > I haven't had a chance to read through the entire patch yet, but I > think you stripped out punching a hole in iptables for GRE tunnels > from the base ovs-ctl script since you sent this patch out. Did you > want to add a rule to the

Re: [ovs-dev] [rhel-5.6 2/2] Add RHEL-5.6 spec file and instructions.

2011-06-20 Thread Justin Pettit
I haven't had a chance to read through the entire patch yet, but I think you stripped out punching a hole in iptables for GRE tunnels from the base ovs-ctl script since you sent this patch out. Did you want to add a rule to the RHEL-5.6 init script to do this? Also, do you have thoughts on how