I haven't had a chance to read through the entire patch yet, but I think you stripped out punching a hole in iptables for GRE tunnels from the base ovs-ctl script since you sent this patch out. Did you want to add a rule to the RHEL-5.6 init script to do this? Also, do you have thoughts on how we might make ovs-bugtool more modular, so that we can easily adapt it to new platforms like this?
--Justin On Jun 17, 2011, at 1:51 PM, Ben Pfaff wrote: > On Fri, Jun 17, 2011 at 01:29:10PM -0700, Andrew Evans wrote: >> Thanks, this looks good. I have only a few minor comments: >> >> On Thu, 2011-06-16 at 12:25 -0700, Ben Pfaff wrote: >>> diff --git a/INSTALL.RHEL-5.6 b/INSTALL.RHEL-5.6 >> >> Should we change the RHEL 5.6 references to RHEL 5? RHEL 5.7 is >> currently in beta, and there will probably be future RHEL 5 minor >> releases. I guess we might want to say that this might not work on RHEL >> 5.5 and earlier. > > OK, I changed some to say RHEL 5, others to just say RHEL (because I'm > working on RHEL 6 packaging at the moment and it won't be much > different). > >>> + rpmbuild \ >>> + -D "openvswitch_version <Open vSwitch version>" \ >>> + -D "kernel_version <kernel version>" \ >>> + -D "kernel_flavor <kernel flavor>" \ >>> + -bb openvswitch-$VERSION/rhel-5.6/openvswitch-rhel-5.6.spec >> >> Can we make this more similar to the rpmbuild command typically used to >> build Red Hat kmod packages? The required -D arguments seem unorthodox >> to me. There's an example kmod spec file and rpmbuild commands here: >> >> http://wiki.centos.org/HowTos/BuildingKernelModules > > Ugh, that example file is full of nasty unreadable gunge. > > I'll work on that and come back with a new patch. > >>> + set "$@" --force-oorefiles="$FORCE_COREFILES" >> >> Did you mean --force-corefiles? > > Oops, thanks. Fixed. > > The same typo also appeared in the XenServer and Debian initscripts, > so I fixed it in those too. > >>> + if test ! -e /var/run/openvswitch.booted; then >>> + touch /var/run/openvswitch.booted >>> + set "$@" --delete-bridges >>> + fi >> >> Is something else deleting /var/run/openvswitch.booted on system >> shutdown or OVS stop, or is this only supposed to run the first time OVS >> is started? > > Red Hat and Debian, at least, delete everything from /var/run early in > the boot process. I think that the newest trend is actually to mount > it as a tmpfs. > >>> + force-reload-kmod) >>> + $ovs_ctl force_reload_kmod >> >> Doesn't ovs-ctl require force-reload-kmod? > > You're right. > > This typo was also in the XenServer init scripts. I'll send out a > patch for this one and the "oorefiles" one. > _______________________________________________ > dev mailing list > [email protected] > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
