Re: [PR] Add basic EditorConfig file [openoffice]

2025-01-24 Thread Dave Fisher
Hi - > On Jan 24, 2025, at 12:05 PM, ardovm (via GitHub) wrote: > > > ardovm commented on PR #256: > URL: https://github.com/apache/openoffice/pull/256#issuecomment-2613292891 > >> Wiki is often outdated. > > ...but I liked it that way... ;-) > > In fact, I thought that that wiki page wa

Re: [PR] Add basic EditorConfig file [openoffice]

2025-01-24 Thread via GitHub
ardovm commented on PR #256: URL: https://github.com/apache/openoffice/pull/256#issuecomment-2613292891 > Wiki is often outdated. ...but I liked it that way... ;-) In fact, I thought that that wiki page was written _after_ many files were already formatted with tabs. It

Re: [PR] Address bug 127942 [openoffice]

2025-01-24 Thread via GitHub
Pilot-Pirx commented on PR #251: URL: https://github.com/apache/openoffice/pull/251#issuecomment-2613358341 Windows build went fine. But after clearing the recent file list the URL history is still populated... After closing and reopening the URL history is clean. -- This is an autom

Re: [PR] Fix spelling [openoffice]

2025-01-24 Thread via GitHub
Pilot-Pirx merged PR #254: URL: https://github.com/apache/openoffice/pull/254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice

Re: [PR] Add basic EditorConfig file [openoffice]

2025-01-24 Thread via GitHub
Pilot-Pirx commented on PR #256: URL: https://github.com/apache/openoffice/pull/256#issuecomment-2613117081 Wiki is often outdated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Add basic EditorConfig file [openoffice]

2025-01-24 Thread via GitHub
ardovm commented on PR #256: URL: https://github.com/apache/openoffice/pull/256#issuecomment-2613107969 I suggest we add: `tab_width = 4` to the `[*]` section because many files are formatted this way. [A page on our wiki](https://wiki.openoffice.org/wiki/Cpp_Coding_Standards/FO

Re: [PR] Add basic EditorConfig file [openoffice]

2025-01-24 Thread via GitHub
ardovm commented on PR #256: URL: https://github.com/apache/openoffice/pull/256#issuecomment-2613319002 > Wiki is often outdated. > > Would that correspond to: > > /* vim: set noet sw=4 ts=4: */ I looked further and now I agree that this is our current standard. Yes, the

Re: [PR] Fix end of hxx files remove unneeded blank lines [openoffice]

2025-01-24 Thread via GitHub
jbampton commented on PR #242: URL: https://github.com/apache/openoffice/pull/242#issuecomment-2612818155 This was an auto fix using pre-commit but I just submitted the line ending changes previously. From the official pre-commit hooks there is the `end-of-file-fixer` which was used:

Re: [PR] Add basic EditorConfig file [openoffice]

2025-01-24 Thread via GitHub
jbampton commented on PR #256: URL: https://github.com/apache/openoffice/pull/256#issuecomment-2612922913 There is a good list of projects using EditorConfig: https://github.com/editorconfig/editorconfig/wiki/Projects-Using-EditorConfig -- This is an automated message from t

Re: [PR] Add 4 more official pre-commit hooks [openoffice]

2025-01-24 Thread via GitHub
Pilot-Pirx commented on PR #255: URL: https://github.com/apache/openoffice/pull/255#issuecomment-2612841963 I would also be interested in: https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#mixed-line-ending I already found and fixed some files with mixed line ending

Re: [PR] Fix end of hxx files remove unneeded blank lines [openoffice]

2025-01-24 Thread via GitHub
Pilot-Pirx commented on PR #242: URL: https://github.com/apache/openoffice/pull/242#issuecomment-2612928821 It was the massive amount of files why I didn't merge it. But in the end, we can always revert the commit... -- This is an automated message from the Apache Git Service. To respon

[PR] Fix spelling [openoffice]

2025-01-24 Thread via GitHub
jbampton opened a new pull request, #254: URL: https://github.com/apache/openoffice/pull/254 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: Win64 port making progress

2025-01-24 Thread Matthias Seidel
Hi Damjan, Now it *almost* succeeds. :-D Since my configure wants to build the NSIS/MSI installer it fails in the final module "instsetoo_native". Adding "epm" to configure didn't help. BTW, I never needed epm for the Windows 32-bit build, maybe the cause is here: https://github.com/apache

Re: [PR] Add 4 more official pre-commit hooks [openoffice]

2025-01-24 Thread via GitHub
jbampton commented on PR #255: URL: https://github.com/apache/openoffice/pull/255#issuecomment-2612958634 I pushed a second commit that fixed the line mixed line ending in `main` for just `cxx` and `hxx` files. Was a large amount just for this batch -- This is an automated message

Re: [PR] Address bug 127942 [openoffice]

2025-01-24 Thread via GitHub
ardovm commented on PR #251: URL: https://github.com/apache/openoffice/pull/251#issuecomment-2613583413 There are other problems, unfortunately. When the history is cleared, it does not get populated again (visited documents are not saved) until the program is restarted. This cannot be m

[PR] Fix more spelling [openoffice]

2025-01-24 Thread via GitHub
jbampton opened a new pull request, #252: URL: https://github.com/apache/openoffice/pull/252 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] Fix more spelling [openoffice]

2025-01-24 Thread via GitHub
jbampton commented on PR #252: URL: https://github.com/apache/openoffice/pull/252#issuecomment-2612195526 So there are a whole bunch of pre-commit hooks that can be added in future if needed. The official hooks are seen here: https://github.com/pre-commit/pre-commit-hooks And

Re: [PR] feat(actions): add `pre-commit` framework with `codespell` [openoffice]

2025-01-24 Thread via GitHub
jbampton merged PR #191: URL: https://github.com/apache/openoffice/pull/191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.a

[PR] Standardize the pre-commit config [openoffice]

2025-01-24 Thread via GitHub
jbampton opened a new pull request, #253: URL: https://github.com/apache/openoffice/pull/253 https://github.com/codespell-project/codespell?tab=readme-ov-file#pre-commit-hook -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[PR] Add 4 more official pre-commit hooks [openoffice]

2025-01-24 Thread via GitHub
jbampton opened a new pull request, #255: URL: https://github.com/apache/openoffice/pull/255 https://github.com/pre-commit/pre-commit-hooks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Add basic EditorConfig file [openoffice]

2025-01-24 Thread Damjan Jovanovic
On Fri, Jan 24, 2025 at 8:10 PM Dave Fisher wrote: > Hi - > > > On Jan 24, 2025, at 12:05 PM, ardovm (via GitHub) > wrote: > > > > > > ardovm commented on PR #256: > > URL: > https://github.com/apache/openoffice/pull/256#issuecomment-2613292891 > > > >> Wiki is often outdated. > > > > ...but I