On Fri, Jan 24, 2025 at 8:10 PM Dave Fisher <w...@apache.org> wrote:
> Hi - > > > On Jan 24, 2025, at 12:05 PM, ardovm (via GitHub) <g...@apache.org> > wrote: > > > > > > ardovm commented on PR #256: > > URL: > https://github.com/apache/openoffice/pull/256#issuecomment-2613292891 > > > >> Wiki is often outdated. > > > > ...but I liked it that way... ;-) > > > > In fact, I thought that that wiki page was written _after_ many files > were already formatted with tabs. > > > > It may be worth a short discussion on dev@. > > I’m reading this on dev. I’d like to know what currently busy developers > like DamJan think. > > I always had to use a tab size of 4. As for spaces vs tabs, I usually try to preserve whatever the file originally used, which is usually tabs for C++ and makefiles, and spaces for Java. > > > >> Would that correspond to: > >> > >> `/* vim: set noet sw=4 ts=4: */` > > > > This should represent the current state of many files, i.e. tabs, to > be displayed as 4 spaces. > > > > I was suggesting we rather set `et` instead of `noet`, using no tabs > for indentation, but rather 4 spaces. > > If developer makes a mistake will this precommit hook fix our mistakes? > How can GitHub fix mistakes when we commit to gitbox.apache.org? > > Best, > Dave > > Damjan
