Re: Very simple first patch

2014-11-26 Thread Andrea Pescetti
On 14/11/2014 Michal Hriň wrote: http://people.apache.org/~hrin/dejavu/ Thanks! I tried to avoid to download whole trunk. I tried this on release because I want to know if the build is my problem or others. svn diff can't be made without svn co, right? But this is my problem. Yes, you need an

Re: Very simple first patch

2014-11-14 Thread Kay Schenk
On Fri, Nov 14, 2014 at 12:08 AM, Herbert Duerr wrote: > On 14.11.2014 01:04, Kay Schenk wrote: > >> On 11/13/2014 03:10 PM, Andrea Pescetti wrote: >> >>> On 13/11/2014 Michal Hriň wrote: >>> [...] >>> It is a update of external package :) >>> >>> And here is a problem, but it doesn't d

Re: Very simple first patch

2014-11-14 Thread Michal Hriň
Dňa 14.11.2014 o 00:10 Andrea Pescetti napísal(a): On 13/11/2014 Michal Hriň wrote: I made very simple patch. http://people.apache.org/~hrin/dejavu/ Looks quite correct. The normal way would be to open an issue of type PATCH and attach your patch. Make just one .patch file, obtained with svn d

Re: Very simple first patch

2014-11-14 Thread Herbert Duerr
On 14.11.2014 01:04, Kay Schenk wrote: On 11/13/2014 03:10 PM, Andrea Pescetti wrote: On 13/11/2014 Michal Hriň wrote: [...] It is a update of external package :) And here is a problem, but it doesn't depend on you. Policy so far has been: we download build-time dependencies from the Extensio

Re: Very simple first patch

2014-11-13 Thread Kay Schenk
On 11/13/2014 03:10 PM, Andrea Pescetti wrote: > On 13/11/2014 Michal Hriň wrote: >> I made very simple patch. >> http://people.apache.org/~hrin/dejavu/ > > Looks quite correct. The normal way would be to open an issue of type > PATCH and attach your patch. Make just one .patch file, obtained wi

Re: Very simple first patch

2014-11-13 Thread Andrea Pescetti
On 13/11/2014 Michal Hriň wrote: I made very simple patch. http://people.apache.org/~hrin/dejavu/ Looks quite correct. The normal way would be to open an issue of type PATCH and attach your patch. Make just one .patch file, obtained with svn diff or git diff. And don't forget to send the link

Very simple first patch

2014-11-13 Thread Michal Hriň
Hi, I made very simple patch. http://people.apache.org/~hrin/dejavu/ Please review, and feel free to add it to trunk if it will be good. And add comments if I'm doing something wrong. It is a update of external package :) Regards, Hriň