Re: git revision missing when building 4.1.7 from the source tarball

Hi Jim, Am 03.10.19 um 21:16 schrieb Jim Jagielski: > Here is the logic of the patch: > > Basically, at build time, the same system in place to get the "repo version" > is used... During the build it checks to see if the build is based on a git > checkout and, if so, uses the short hash. If not

Re: git revision missing when building 4.1.7 from the source tarball

Here is the logic of the patch: Basically, at build time, the same system in place to get the "repo version" is used... During the build it checks to see if the build is based on a git checkout and, if so, uses the short hash. If not a git repo, it sees if it's SVN and uses that. If neither, th

Re: git revision missing when building 4.1.7 from the source tarball

Thanks! As it is in 4.1.8 I will start a test build on that branch now... Matthias Am 03.10.19 um 19:16 schrieb Jim Jagielski: > Done in 27a447d8e738b70f74ab05606693d7139127efc4 > >> On Sep 19, 2019, at 8:25 AM, Matthias Seidel >> wrote: >> >> Hi Jim, >> >> Am 19.09.19 um 13:47 schrieb Jim Jag

Re: git revision missing when building 4.1.7 from the source tarball

Done in 27a447d8e738b70f74ab05606693d7139127efc4 > On Sep 19, 2019, at 8:25 AM, Matthias Seidel > wrote: > > Hi Jim, > > Am 19.09.19 um 13:47 schrieb Jim Jagielski: >>> On Sep 18, 2019, at 1:43 AM, Don Lewis wrote: >>> >>> If you build 4.1.7 starting with the source tarball, the git revision

Re: git revision missing when building 4.1.7 from the source tarball

Hi Jim, Am 19.09.19 um 13:47 schrieb Jim Jagielski: >> On Sep 18, 2019, at 1:43 AM, Don Lewis wrote: >> >> If you build 4.1.7 starting with the source tarball, the git revision >> isn't included in the build result because the source tarball doesn't >> include the .git directory. That is needed

Re: git revision missing when building 4.1.7 from the source tarball

> On Sep 18, 2019, at 1:43 AM, Don Lewis wrote: > > If you build 4.1.7 starting with the source tarball, the git revision > isn't included in the build result because the source tarball doesn't > include the .git directory. That is needed so that 'git log' can find > the most recent commit has

Re: git revision missing when building 4.1.7 from the source tarball

That sounds reasonable. I suggest .revision since the value ends up as the Revision value in versionrc. Whatever the name, it should be added to .gitignore. Since this is not a regression, I don't consider it a blocker for 4.1.7. In the meantime, I have a workaround for the FreeBSD port. On 18

Re: git revision missing when building 4.1.7 from the source tarball

Hi Don, We build the source tarball with "dmake aoo_srcrelease" [1]. Maybe the git hash can additionally be put into a file which is used when no .git directory is present? This should even work if the person who wants to build from source tarball has no git installed... Regards,    Matthias [