That sounds reasonable. I suggest .revision since the value ends up as the Revision value in versionrc. Whatever the name, it should be added to .gitignore.
Since this is not a regression, I don't consider it a blocker for 4.1.7. In the meantime, I have a workaround for the FreeBSD port. On 18 Sep, Matthias Seidel wrote: > Hi Don, > > We build the source tarball with "dmake aoo_srcrelease" [1]. > > Maybe the git hash can additionally be put into a file which is used > when no .git directory is present? > This should even work if the person who wants to build from source > tarball has no git installed... > > Regards, > > Matthias > > [1] > https://cwiki.apache.org/confluence/display/OOOUSERS/How+to+Cook+a+Release#HowtoCookaRelease-Howisthesourcecodeobtained? > > > Am 18.09.19 um 07:43 schrieb Don Lewis: >> If you build 4.1.7 starting with the source tarball, the git revision >> isn't included in the build result because the source tarball doesn't >> include the .git directory. That is needed so that 'git log' can find >> the most recent commit hash. I wasn't able to find a reasonable subset >> of the .git contents that would allow this to work. >> >> This problem was probably also present with svn, but nobody noticed. >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org >> For additional commands, e-mail: dev-h...@openoffice.apache.org >> >> > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
