Re: compiler warnings when building OpenOffice

2016-09-05 Thread Don Lewis
On 1 Sep, Don Lewis wrote: > 493 -Wunused-private-field > 391 -Wunused-parameter > 366 -Wunused-const-variable > 314 -Woverloaded-virtual > 181 -Wunused-variable > 109 -Wlogical-op-parentheses > 93 -Wsign-compare > 77 -Wdelete-non-virtual-dtor > 72 -Wint-to-void-pointer-cast > 63 -W

Re: compiler warnings when building OpenOffice

2016-09-04 Thread Patricia Shanahan
On 9/4/2016 3:45 PM, Patricia Shanahan wrote: On 9/1/2016 4:00 PM, Don Lewis wrote: On 1 Sep, Patricia Shanahan wrote: I need a problem to work on. Would you like me to take a particular compiler warning and try to sort it out? Here is one: /wrkdirs/usr/ports/editors/openoffice-devel2/work/

Re: compiler warnings when building OpenOffice

2016-09-04 Thread Patricia Shanahan
On 9/1/2016 4:00 PM, Don Lewis wrote: On 1 Sep, Patricia Shanahan wrote: I need a problem to work on. Would you like me to take a particular compiler warning and try to sort it out? Here is one: /wrkdirs/usr/ports/editors/openoffice-devel2/work/aoo-4.2.0/main/solver/420/unxfbsdx.pro/inc/osl/

Re: compiler warnings when building OpenOffice

2016-09-01 Thread Don Lewis
On 1 Sep, To: Don Lewis wrote: > One of the -Wunused-parameter warnings led me to this questionable bit > of code in filter/source/xsltfilter/containerhelper.hxx: > > template > inline void forEachMem(FuncType pFunc, ParamType aParam) const > { > forEach(

Re: compiler warnings when building OpenOffice

2016-09-01 Thread Don Lewis
On 1 Sep, Patricia Shanahan wrote: > I need a problem to work on. Would you like me to take a particular > compiler warning and try to sort it out? Here is one: /wrkdirs/usr/ports/editors/openoffice-devel2/work/aoo-4.2.0/main/solver/420/unxfbsdx.pro/inc/osl/diagnose.hxx:65:25: warning: 'osl_de

Re: compiler warnings when building OpenOffice

2016-09-01 Thread Patricia Shanahan
I need a problem to work on. Would you like me to take a particular compiler warning and try to sort it out? On 9/1/2016 3:29 PM, Don Lewis wrote: On 29 Aug, Don Lewis wrote: When building OpenOffice trunk revsion r1758161 as a FreeBSD port on FreeBSD 12.0-CURRENT with clang 3.8.0, I get the f

Re: compiler warnings when building OpenOffice

2016-09-01 Thread Don Lewis
On 29 Aug, Don Lewis wrote: > When building OpenOffice trunk revsion r1758161 as a FreeBSD port on > FreeBSD 12.0-CURRENT with clang 3.8.0, I get the following warnings. > I'm mostly interested in the OpenOffice code and not the bundled > external code, so I specifically built the FreeBSD port it u

Re: compiler warnings when building OpenOffice

2016-08-30 Thread Don Lewis
On 30 Aug, Don Lewis wrote: > On 30 Aug, Kay Schenk wrote: >> >> >> On 08/29/2016 04:14 PM, Don Lewis wrote: >>> A couple -Wtautological-undefined-compare warnings: >>> >>> warning: reference cannot be bound to dereferenced null pointer in >>> well-defined C++ code; comparison may be assumed t

Re: compiler warnings when building OpenOffice

2016-08-30 Thread Don Lewis
On 30 Aug, Kay Schenk wrote: > > > On 08/29/2016 04:14 PM, Don Lewis wrote: >> When building OpenOffice trunk revsion r1758161 as a FreeBSD port on >> FreeBSD 12.0-CURRENT with clang 3.8.0, I get the following warnings. >> I'm mostly interested in the OpenOffice code and not the bundled >> extern

Re: compiler warnings when building OpenOffice

2016-08-30 Thread Kay Schenk
On 08/29/2016 04:14 PM, Don Lewis wrote: > When building OpenOffice trunk revsion r1758161 as a FreeBSD port on > FreeBSD 12.0-CURRENT with clang 3.8.0, I get the following warnings. > I'm mostly interested in the OpenOffice code and not the bundled > external code, so I specifically built the Fr

Re: compiler warnings when building OpenOffice

2016-08-29 Thread Don Lewis
On 29 Aug, Don Lewis wrote: > When building OpenOffice trunk revsion r1758161 as a FreeBSD port on > FreeBSD 12.0-CURRENT with clang 3.8.0, I get the following warnings. > I'm mostly interested in the OpenOffice code and not the bundled > external code, so I specifically built the FreeBSD port it u

compiler warnings when building OpenOffice

2016-08-29 Thread Don Lewis
When building OpenOffice trunk revsion r1758161 as a FreeBSD port on FreeBSD 12.0-CURRENT with clang 3.8.0, I get the following warnings. I'm mostly interested in the OpenOffice code and not the bundled external code, so I specifically built the FreeBSD port it uses --with-system-foo extensively wh

Re: Compiler warnings

2014-03-10 Thread Andre Fischer
On 05.03.2014 11:54, Andre Fischer wrote: On 05.03.2014 09:30, Andre Fischer wrote: I have created issue 124361 for this. The 4555 warning is triggered by the hash_map wrapper in module stl_port/ when it includes unordered_map. Luckily this allows us to turn of the warning temporarily fo

Re: Compiler warnings

2014-03-06 Thread Herbert Duerr
On 05.03.2014 14:42, Andre Fischer wrote: Exception support does make object files larger and possibly a bit slower. The question is, is that significant? To put some actual data behind this: the exception handling tables in the libraries cost us about 20MB (on our current 64bit Linux build).

Re: Compiler warnings

2014-03-05 Thread Andre Fischer
On 05.03.2014 14:18, Rob Weir wrote: On Wed, Mar 5, 2014 at 7:32 AM, jan i wrote: On 5 March 2014 12:46, Andre Fischer wrote: On 05.03.2014 12:38, John O'Sullivan wrote: Use MSVC's WD flag to disable the warning. You'll probably need to hack wntmsci11.mk... I wouldn't like to turn off th

Re: Compiler warnings

2014-03-05 Thread Andre Fischer
On 05.03.2014 14:49, jan i wrote: On 5 March 2014 14:42, Andre Fischer wrote: On 05.03.2014 10:01, Herbert Duerr wrote: On 05.03.2014 09:30, Andre Fischer wrote: re C4530: One option would be to compile all sc code with exceptions enabled. That sounds reasonable. Does anyone know

Re: Compiler warnings

2014-03-05 Thread jan i
On 5 March 2014 14:42, Andre Fischer wrote: > On 05.03.2014 10:01, Herbert Duerr wrote: > >> On 05.03.2014 09:30, Andre Fischer wrote: >> >>re C4530: One option would be to compile all sc code with exceptions >>> enabled. >>> >> >> That sounds reasonable. >> >> Does anyone know of a reason

Re: Compiler warnings

2014-03-05 Thread Andre Fischer
On 05.03.2014 11:53, Herbert Duerr wrote: On 05.03.2014 11:45, Andre Fischer wrote: On 05.03.2014 11:28, Herbert Duerr wrote: On 05.03.2014 10:28, Andre Fischer wrote: On 05.03.2014 10:01, Herbert Duerr wrote: The warning "expression has no effect" itself is interesting enough, just not in in

Re: Compiler warnings

2014-03-05 Thread Andre Fischer
On 05.03.2014 10:01, Herbert Duerr wrote: On 05.03.2014 09:30, Andre Fischer wrote: re C4530: One option would be to compile all sc code with exceptions enabled. That sounds reasonable. Does anyone know of a reason not to do that? Not that I'm aware of. I am neither, that's why I ask

Re: Compiler warnings

2014-03-05 Thread Andre Fischer
On 05.03.2014 14:20, jan i wrote: On 5 March 2014 14:18, Rob Weir wrote: On Wed, Mar 5, 2014 at 7:32 AM, jan i wrote: On 5 March 2014 12:46, Andre Fischer wrote: On 05.03.2014 12:38, John O'Sullivan wrote: Use MSVC's WD flag to disable the warning. You'll probably need to hack wntmsci11

Re: Compiler warnings

2014-03-05 Thread jan i
On 5 March 2014 14:18, Rob Weir wrote: > On Wed, Mar 5, 2014 at 7:32 AM, jan i wrote: > > On 5 March 2014 12:46, Andre Fischer wrote: > > > >> On 05.03.2014 12:38, John O'Sullivan wrote: > >> > >>> Use MSVC's WD flag to disable the warning. You'll probably need to hack > >>> wntmsci11.mk... > >

Re: Compiler warnings

2014-03-05 Thread Rob Weir
On Wed, Mar 5, 2014 at 7:32 AM, jan i wrote: > On 5 March 2014 12:46, Andre Fischer wrote: > >> On 05.03.2014 12:38, John O'Sullivan wrote: >> >>> Use MSVC's WD flag to disable the warning. You'll probably need to hack >>> wntmsci11.mk... >>> >> >> I wouldn't like to turn off this warning globall

Re: Compiler warnings

2014-03-05 Thread jan i
On 5 March 2014 12:46, Andre Fischer wrote: > On 05.03.2014 12:38, John O'Sullivan wrote: > >> Use MSVC's WD flag to disable the warning. You'll probably need to hack >> wntmsci11.mk... >> > > I wouldn't like to turn off this warning globally. I only don't want to > see it for system headers tha

Re: Compiler warnings

2014-03-05 Thread Andre Fischer
On 05.03.2014 12:38, John O'Sullivan wrote: Use MSVC's WD flag to disable the warning. You'll probably need to hack wntmsci11.mk... I wouldn't like to turn off this warning globally. I only don't want to see it for system headers that I can't change anyway. -Andre

Re: Compiler warnings

2014-03-05 Thread John O'Sullivan
Use MSVC's WD flag to disable the warning. You'll probably need to hack wntmsci11.mk... On 5 Mar 2014 08:31, "Andre Fischer" wrote: > I am currently working on some bug in the sc module and find that it is > really hard to even find compiler errors among the many warning messages. > Some of thes

Re: Compiler warnings

2014-03-05 Thread Andre Fischer
On 05.03.2014 09:30, Andre Fischer wrote: I am currently working on some bug in the sc module and find that it is really hard to even find compiler errors among the many warning messages. Some of these warnings are caused directly by code in sc but the majority of the warnings originate in hea

Re: Compiler warnings

2014-03-05 Thread Herbert Duerr
On 05.03.2014 11:45, Andre Fischer wrote: On 05.03.2014 11:28, Herbert Duerr wrote: On 05.03.2014 10:28, Andre Fischer wrote: On 05.03.2014 10:01, Herbert Duerr wrote: The warning "expression has no effect" itself is interesting enough, just not in in list header. Fortunately terms like "list(

Re: Compiler warnings

2014-03-05 Thread Andre Fischer
On 05.03.2014 11:28, Herbert Duerr wrote: On 05.03.2014 10:28, Andre Fischer wrote: On 05.03.2014 10:01, Herbert Duerr wrote: The warning "expression has no effect" itself is interesting enough, just not in in list header. Fortunately terms like "list(1137)" can be filtered out easily. Please

Re: Compiler warnings

2014-03-05 Thread Herbert Duerr
On 05.03.2014 10:28, Andre Fischer wrote: On 05.03.2014 10:01, Herbert Duerr wrote: The warning "expression has no effect" itself is interesting enough, just not in in list header. Fortunately terms like "list(1137)" can be filtered out easily. Please explain how that can be filtered out easil

Re: Compiler warnings

2014-03-05 Thread Andre Fischer
On 05.03.2014 10:01, Herbert Duerr wrote: On 05.03.2014 09:30, Andre Fischer wrote: I am currently working on some bug in the sc module and find that it is really hard to even find compiler errors among the many warning messages. Some of these warnings are caused directly by code in sc but the

Re: Compiler warnings

2014-03-05 Thread Herbert Duerr
On 05.03.2014 09:30, Andre Fischer wrote: I am currently working on some bug in the sc module and find that it is really hard to even find compiler errors among the many warning messages. Some of these warnings are caused directly by code in sc but the majority of the warnings originate in heade

Compiler warnings

2014-03-05 Thread Andre Fischer
I am currently working on some bug in the sc module and find that it is really hard to even find compiler errors among the many warning messages. Some of these warnings are caused directly by code in sc but the majority of the warnings originate in header files. Platform is Windows. The most

Re: WaE: sw/source/filter/ww8 compiler warnings

2012-12-03 Thread Pavel Janík
On Dec 4, 2012, at 3:14 AM, chengjh wrote: > Sure,Pavel, after I have a clean build for this module, I get this warning > too, and I have already committed the change and don't find any other > warning..From that,I think my environment on Mac OS X 10.5.8 can identify > the same warning set with y

Re: WaE: sw/source/filter/ww8 compiler warnings

2012-12-03 Thread chengjh
Sure,Pavel, after I have a clean build for this module, I get this warning too, and I have already committed the change and don't find any other warning..From that,I think my environment on Mac OS X 10.5.8 can identify the same warning set with yours, but level is still less than yours because I di

Re: WaE: sw/source/filter/ww8 compiler warnings

2012-12-03 Thread Pavel Janík
Hi! On Dec 3, 2012, at 4:18 PM, chengjh wrote: > I committed some changes to solve the found warnings...Please help to > verify again..And I will have a check to the whole sw module to see whether > any missed warning is still existing.thanks. thanks. The module is almost clean now. I only see:

Re: WaE: sw/source/filter/ww8 compiler warnings

2012-12-03 Thread chengjh
Hi Pavel, I committed some changes to solve the found warnings...Please help to verify again..And I will have a check to the whole sw module to see whether any missed warning is still existing.thanks. On Fri, Nov 30, 2012 at 3:54 AM, Pavel Janík wrote: > Hi, > > current trunk issues few warning

Re: WaE: sw/source/filter/ww8 compiler warnings

2012-11-30 Thread chengjh
Hi Pavel, this is unnecessary checking, and it will be revised soon..Thanks for your care. On Sat, Dec 1, 2012 at 3:19 AM, Pavel Janík wrote: > > On Nov 30, 2012, at 8:16 PM, Pavel Janík wrote: > > > > > On Nov 30, 2012, at 12:04 PM, chengjh wrote: > > > >> I will have a look. > > > > Next o

Re: WaE: sw/source/filter/ww8 compiler warnings

2012-11-30 Thread Pavel Janík
On Nov 30, 2012, at 8:16 PM, Pavel Janík wrote: > > On Nov 30, 2012, at 12:04 PM, chengjh wrote: > >> I will have a look. > > Next one: > > /Users/pavel/BUILD/BuildDir/ooo_trunk_src/sw/source/filter/ww8/ww8graf.cxx:2749: > warning: comparison between signed and unsigned integer expressio

Re: WaE: sw/source/filter/ww8 compiler warnings

2012-11-30 Thread Pavel Janík
On Nov 30, 2012, at 12:04 PM, chengjh wrote: > I will have a look. Next one: /Users/pavel/BUILD/BuildDir/ooo_trunk_src/sw/source/filter/ww8/ww8graf.cxx:2749: warning: comparison between signed and unsigned integer expressions -- Pavel Janík

Re: WaE: sw/source/filter/ww8 compiler warnings

2012-11-30 Thread chengjh
I will have a look. On Fri, Nov 30, 2012 at 3:54 AM, Pavel Janík wrote: > Hi, > > current trunk issues few warnings in sw/source/filter/ww8: > > cc1plus: warnings being treated as errors > /Users/pavel/BUILD/BuildDir/ooo_trunk_src/sw/source/filter/ww8/ww8par3.cxx: > In member function ‘SwNum

WaE: sw/source/filter/ww8 compiler warnings

2012-11-29 Thread Pavel Janík
Hi, current trunk issues few warnings in sw/source/filter/ww8: cc1plus: warnings being treated as errors /Users/pavel/BUILD/BuildDir/ooo_trunk_src/sw/source/filter/ww8/ww8par3.cxx: In member function ‘SwNumRule* WW8ListManager::GetNumRule(int)’: /Users/pavel/BUILD/BuildDir/ooo_trunk_src/sw/sourc