davids5 commented on issue #12: nxstyle improvements with No tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#issuecomment-569671947
@xiaoxiang781216 - all review Items have been addressed - Please merge or
ask an other PPMC to merge it.
-
masayuki2009 opened a new pull request #16: feature k210
URL: https://github.com/apache/incubator-nuttx/pull/16
**Summary**
- Added initial support for Sipeed Maix Bit board with Kendryte K210
processor.
- K210 has two RV64GC cores but in this PR only the primary core is enabled.
xiaoxiang781216 commented on a change in pull request #12: nxstyle improvements
with No tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#discussion_r361990500
##
File path: tools/nxstyle.c
##
@@ -43,53 +43,128 @@
#include
#include
#include
+#include
+#
xiaoxiang781216 commented on a change in pull request #12: nxstyle improvements
with No tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#discussion_r361986470
##
File path: tools/nxstyle.c
##
@@ -135,67 +211,98 @@ int main(int argc, char **argv, char **envp)
xiaoxiang781216 commented on a change in pull request #12: nxstyle improvements
with No tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#discussion_r361987147
##
File path: tools/nxstyle.c
##
@@ -135,67 +211,98 @@ int main(int argc, char **argv, char **envp)
xiaoxiang781216 commented on a change in pull request #12: nxstyle improvements
with No tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#discussion_r361991442
##
File path: tools/nxstyle.c
##
@@ -135,67 +211,98 @@ int main(int argc, char **argv, char **envp)
xiaoxiang781216 commented on a change in pull request #12: nxstyle improvements
with No tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#discussion_r361989296
##
File path: tools/nxstyle.c
##
@@ -135,67 +211,98 @@ int main(int argc, char **argv, char **envp)
xiaoxiang781216 commented on a change in pull request #12: nxstyle improvements
with No tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#discussion_r361990957
##
File path: tools/nxstyle.c
##
@@ -135,67 +211,98 @@ int main(int argc, char **argv, char **envp)
xiaoxiang781216 commented on a change in pull request #12: nxstyle improvements
with No tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#discussion_r361989974
##
File path: tools/nxstyle.c
##
@@ -135,67 +211,98 @@ int main(int argc, char **argv, char **envp)
xiaoxiang781216 commented on a change in pull request #12: nxstyle improvements
with No tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#discussion_r361988441
##
File path: tools/nxstyle.c
##
@@ -135,67 +211,98 @@ int main(int argc, char **argv, char **envp)
patacongo commented on a change in pull request #16: feature k210
URL: https://github.com/apache/incubator-nuttx/pull/16#discussion_r362002179
##
File path: include/stdint.h
##
@@ -273,8 +273,13 @@ typedef _uint64_t uint_fast64_t;
/* Integer types capable of ho
patacongo commented on a change in pull request #16: feature k210
URL: https://github.com/apache/incubator-nuttx/pull/16#discussion_r362002179
##
File path: include/stdint.h
##
@@ -273,8 +273,13 @@ typedef _uint64_t uint_fast64_t;
/* Integer types capable of ho
patacongo commented on a change in pull request #16: feature k210
URL: https://github.com/apache/incubator-nuttx/pull/16#discussion_r362002179
##
File path: include/stdint.h
##
@@ -273,8 +273,13 @@ typedef _uint64_t uint_fast64_t;
/* Integer types capable of ho
patacongo commented on a change in pull request #16: feature k210
URL: https://github.com/apache/incubator-nuttx/pull/16#discussion_r362002179
##
File path: include/stdint.h
##
@@ -273,8 +273,13 @@ typedef _uint64_t uint_fast64_t;
/* Integer types capable of ho
patacongo commented on a change in pull request #12: nxstyle improvements with
No tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#discussion_r362005445
##
File path: tools/nxstyle.c
##
@@ -135,67 +211,98 @@ int main(int argc, char **argv, char **envp)
int
davids5 commented on a change in pull request #12: nxstyle improvements with No
tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#discussion_r362007291
##
File path: tools/nxstyle.c
##
@@ -135,67 +211,98 @@ int main(int argc, char **argv, char **envp)
int e
davids5 commented on a change in pull request #12: nxstyle improvements with No
tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#discussion_r362007238
##
File path: tools/nxstyle.c
##
@@ -135,67 +211,98 @@ int main(int argc, char **argv, char **envp)
int e
davids5 commented on a change in pull request #12: nxstyle improvements with No
tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#discussion_r362007489
##
File path: tools/nxstyle.c
##
@@ -43,53 +43,128 @@
#include
#include
#include
+#include
+#include
davids5 commented on a change in pull request #12: nxstyle improvements with No
tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#discussion_r362007456
##
File path: tools/nxstyle.c
##
@@ -135,67 +211,98 @@ int main(int argc, char **argv, char **envp)
int e
davids5 commented on a change in pull request #12: nxstyle improvements with No
tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#discussion_r362007559
##
File path: tools/nxstyle.c
##
@@ -135,67 +211,98 @@ int main(int argc, char **argv, char **envp)
int e
davids5 commented on a change in pull request #12: nxstyle improvements with No
tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#discussion_r362007745
##
File path: tools/nxstyle.c
##
@@ -135,67 +211,98 @@ int main(int argc, char **argv, char **envp)
int e
xiaoxiang781216 commented on a change in pull request #12: nxstyle improvements
with No tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#discussion_r362010142
##
File path: tools/README.txt
##
@@ -313,7 +313,15 @@ nxstyle.c
standard. This program is compl
xiaoxiang781216 commented on a change in pull request #12: nxstyle improvements
with No tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#discussion_r362010914
##
File path: tools/nxstyle.c
##
@@ -134,70 +211,80 @@ int main(int argc, char **argv, char **envp)
davids5 commented on a change in pull request #12: nxstyle improvements with No
tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#discussion_r362011999
##
File path: tools/nxstyle.c
##
@@ -135,67 +211,98 @@ int main(int argc, char **argv, char **envp)
int e
xiaoxiang781216 commented on a change in pull request #12: nxstyle improvements
with No tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#discussion_r362011203
##
File path: tools/nxstyle.c
##
@@ -134,70 +211,80 @@ int main(int argc, char **argv, char **envp)
davids5 commented on a change in pull request #12: nxstyle improvements with No
tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#discussion_r362011922
##
File path: tools/nxstyle.c
##
@@ -135,67 +211,98 @@ int main(int argc, char **argv, char **envp)
int e
davids5 commented on issue #12: nxstyle improvements with No tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#issuecomment-56970
@xiaoxiang781216 - thank you for a through review and all the value added
suggestions.
I am done, all the changes: I added a version in th
davids5 commented on a change in pull request #12: nxstyle improvements with No
tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#discussion_r362014598
##
File path: tools/nxstyle.c
##
@@ -134,70 +211,80 @@ int main(int argc, char **argv, char **envp)
int r
xiaoxiang781216 commented on a change in pull request #12: nxstyle improvements
with No tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#discussion_r362017755
##
File path: tools/nxstyle.c
##
@@ -386,24 +467,26 @@ int main(int argc, char **argv, char **envp)
xiaoxiang781216 commented on a change in pull request #12: nxstyle improvements
with No tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#discussion_r362020988
##
File path: tools/nxstyle.c
##
@@ -134,70 +213,78 @@ int main(int argc, char **argv, char **envp)
xiaoxiang781216 commented on a change in pull request #12: nxstyle improvements
with No tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#discussion_r362020748
##
File path: tools/nxstyle.c
##
@@ -669,25 +757,25 @@ int main(int argc, char **argv, char **envp)
davids5 commented on a change in pull request #12: nxstyle improvements with No
tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#discussion_r362035777
##
File path: tools/nxstyle.c
##
@@ -669,25 +757,25 @@ int main(int argc, char **argv, char **envp)
davids5 commented on a change in pull request #12: nxstyle improvements with No
tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#discussion_r362035720
##
File path: tools/nxstyle.c
##
@@ -386,24 +467,26 @@ int main(int argc, char **argv, char **envp)
davids5 commented on a change in pull request #12: nxstyle improvements with No
tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#discussion_r362035976
##
File path: tools/nxstyle.c
##
@@ -134,70 +213,78 @@ int main(int argc, char **argv, char **envp)
int r
davids5 commented on issue #12: nxstyle improvements with No tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#issuecomment-569731061
@xiaoxiang781216
The program needs many more functional changes to be useful, My vacation is
coming to an end.
I will not be inv
patacongo commented on issue #12: nxstyle improvements with No tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#issuecomment-569743134
@xiaoxiang781216 Perhaps you should merge this onto a development branch.
Where we can work together to continue development. It is currentl
patacongo edited a comment on issue #12: nxstyle improvements with No tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#issuecomment-569743134
@xiaoxiang781216 Perhaps you should merge this onto a features branch,
perhaps called 'nxstyle'. There we can work together to continu
patacongo edited a comment on issue #12: nxstyle improvements with No tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#issuecomment-569743134
@xiaoxiang781216 Perhaps you should merge this onto a feature branch,
perhaps called 'nxstyle'. There we can work together to continue
xiaoxiang781216 commented on issue #12: nxstyle improvements with No tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#issuecomment-569756871
@patacongo, @davids5 fix resolve my most comment except snprintf, but that
is a very minor issue. The patch is good for me, you can squa
patacongo merged pull request #12: nxstyle improvements with No tooling
URL: https://github.com/apache/incubator-nuttx/pull/12
This is an automated message from the Apache Git Service.
To respond to the message, please log on
patacongo commented on issue #12: nxstyle improvements with No tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#issuecomment-569758903
@xiaoxiang781216 Please, make whatever additional changes to you want to
make against branch nxstyle and merge that branch to master.
---
masayuki2009 commented on a change in pull request #16: feature k210
URL: https://github.com/apache/incubator-nuttx/pull/16#discussion_r362137425
##
File path: include/stdint.h
##
@@ -273,8 +273,13 @@ typedef _uint64_t uint_fast64_t;
/* Integer types capable of
masayuki2009 commented on issue #16: feature k210
URL: https://github.com/apache/incubator-nuttx/pull/16#issuecomment-569855598
@patacongo I fixed what you pointed out and pushed again.
This is an automated message from the Ap
adamfeuer commented on issue #13: sama3 sam_serial.c USART selection fixes
URL: https://github.com/apache/incubator-nuttx/pull/13#issuecomment-569866163
@patacongo Is there anything else fix in this PR before it can be merged?
xiaoxiang781216 merged pull request #4: Change wiki link from NUTTXTEST to NUTTX
URL: https://github.com/apache/incubator-nuttx-website/pull/4
This is an automated message from the Apache Git Service.
To respond to the messag
huahang opened a new pull request #5: publish the website
URL: https://github.com/apache/incubator-nuttx-website/pull/5
Try to publish the website according to:
https://cwiki.apache.org/confluence/display/INFRA/.asf.yaml+features+for+git+repositories
huahang closed pull request #5: publish the website
URL: https://github.com/apache/incubator-nuttx-website/pull/5
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
huahang opened a new pull request #6: publish the website
URL: https://github.com/apache/incubator-nuttx-website/pull/6
Try to publish the website according to:
https://cwiki.apache.org/confluence/display/INFRA/.asf.yaml+features+for+git+repositories
davids5 commented on issue #6: publish the website
URL:
https://github.com/apache/incubator-nuttx-website/pull/6#issuecomment-569895811
@xiaoxiang781216 - not my area of expertise.
This is an automated message from the Apach
xiaoxiang781216 opened a new pull request #17: Net cleanup
URL: https://github.com/apache/incubator-nuttx/pull/17
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
xiaoxiang781216 closed pull request #15: [DONT MERGE] Fixed NUTTX-1
URL: https://github.com/apache/incubator-nuttx/pull/15
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
xiaoxiang781216 commented on issue #15: [DONT MERGE] Fixed NUTTX-1
URL: https://github.com/apache/incubator-nuttx/pull/15#issuecomment-569928557
Let's close the test pull request.
This is an automated message from the Apache G
xiaoxiang781216 opened a new pull request #18: fix sim:bluetooth compiler error
URL: https://github.com/apache/incubator-nuttx/pull/18
wireless/bluetooth/bt_null.c:274:10: warning: implicit declaration of
function 'bt_driver_register'; did you mean 'bt_netdev_register'?
[-Wimplicit-functio
patacongo merged pull request #9: Fixed STM32L4_NUSART for STM32L433XX.
URL: https://github.com/apache/incubator-nuttx/pull/9
This is an automated message from the Apache Git Service.
To respond to the message, please log on
patacongo merged pull request #10: wireless: remove unnecessary flags
URL: https://github.com/apache/incubator-nuttx/pull/10
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
patacongo merged pull request #11: Added Kconfig pin config chooser for
nucleo-l432kc USARTs.
URL: https://github.com/apache/incubator-nuttx/pull/11
This is an automated message from the Apache Git Service.
To respond to the
xiaoxiang781216 opened a new pull request #19: Unify the c++ standard library
name to libxx
URL: https://github.com/apache/incubator-nuttx/pull/19
Change-Id: Ic5a2cd2d92759d6416f1609065f20240334e624c
Signed-off-by: Xiang Xiao
patacongo merged pull request #13: sama3 sam_serial.c USART selection fixes
URL: https://github.com/apache/incubator-nuttx/pull/13
This is an automated message from the Apache Git Service.
To respond to the message, please lo
xiaoxiang781216 opened a new pull request #20: psock_udp_sendto should call
udp_wrbuffer_tryalloc for nonblock socket
URL: https://github.com/apache/incubator-nuttx/pull/20
Change-Id: I218dbbf7a588314a1034410aafad34cac802cc69
Signed-off-by: Xiang Xiao
--
patacongo merged pull request #16: feature k210
URL: https://github.com/apache/incubator-nuttx/pull/16
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
patacongo commented on issue #17: Net cleanup
URL: https://github.com/apache/incubator-nuttx/pull/17#issuecomment-569943700
To many small changes to review online. I don't see any problems with what
I have looked at, but neither an I convinced that I have keen enough insight
into all the
patacongo merged pull request #17: Net cleanup
URL: https://github.com/apache/incubator-nuttx/pull/17
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
patacongo merged pull request #18: fix sim:bluetooth compiler error
URL: https://github.com/apache/incubator-nuttx/pull/18
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
patacongo commented on a change in pull request #19: Unify the c++ standard
library name to libxx
URL: https://github.com/apache/incubator-nuttx/pull/19#discussion_r362237598
##
File path: tools/LibTargets.mk
##
@@ -188,10 +188,10 @@ $(ARCH_SRC)$(DELIM)libuarch$(LIBEXT): c
patacongo merged pull request #20: psock_udp_sendto should call
udp_wrbuffer_tryalloc for nonblock socket
URL: https://github.com/apache/incubator-nuttx/pull/20
This is an automated message from the Apache Git Service.
To re
xiaoxiang781216 commented on a change in pull request #19: Unify the c++
standard library name to libxx
URL: https://github.com/apache/incubator-nuttx/pull/19#discussion_r362243316
##
File path: tools/LibTargets.mk
##
@@ -188,10 +188,10 @@ $(ARCH_SRC)$(DELIM)libuarch$(LIBE
patacongo commented on a change in pull request #19: Unify the c++ standard
library name to libxx
URL: https://github.com/apache/incubator-nuttx/pull/19#discussion_r362243636
##
File path: tools/LibTargets.mk
##
@@ -188,10 +188,10 @@ $(ARCH_SRC)$(DELIM)libuarch$(LIBEXT): c
patacongo merged pull request #19: Unify the c++ standard library name to libxx
URL: https://github.com/apache/incubator-nuttx/pull/19
This is an automated message from the Apache Git Service.
To respond to the message, pleas
xiaoxiang781216 commented on issue #10: wireless: remove unnecessary flags
URL: https://github.com/apache/incubator-nuttx/pull/10#issuecomment-569955525
@patacongo this PR need merge too:
https://github.com/apache/incubator-nuttx-apps/pull/1
otherwise, wapi will build break.
-
patacongo merged pull request #1: Wapi simplify
URL: https://github.com/apache/incubator-nuttx-apps/pull/1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
patacongo merged pull request #2: fix builtin_list.c:58:10: fatal error:
builtin_proto.h: No such file …
URL: https://github.com/apache/incubator-nuttx-apps/pull/2
This is an automated message from the Apache Git Service.
To
masayuki2009 opened a new pull request #21: net: tcp: Fix compile error in tcp.h
URL: https://github.com/apache/incubator-nuttx/pull/21
During build testing for spresense with the latest master, I encountered the
following compile error.
```
tcp/tcp_netpoll.c: In function 'tcp_pol
patacongo merged pull request #21: net: tcp: Fix compile error in tcp.h
URL: https://github.com/apache/incubator-nuttx/pull/21
This is an automated message from the Apache Git Service.
To respond to the message, please log on
patacongo commented on issue #21: net: tcp: Fix compile error in tcp.h
URL: https://github.com/apache/incubator-nuttx/pull/21#issuecomment-570001685
BTW: CONFIG_NET_TCPBACKLOG probably should always be enabled. Otherwise,
you will miss connection requests. That configuration is a candidat
masayuki2009 commented on issue #21: net: tcp: Fix compile error in tcp.h
URL: https://github.com/apache/incubator-nuttx/pull/21#issuecomment-570002552
> BTW: CONFIG_NET_TCPBACKLOG probably should always be enabled. Otherwise,
you will miss connection requests. That configuration is a candi
patacongo commented on issue #21: net: tcp: Fix compile error in tcp.h
URL: https://github.com/apache/incubator-nuttx/pull/21#issuecomment-570003155
@masayuki2009 Removing support for CONFIG_NET_TCPBACKLOG altogether might be
a better solution? Anyone else have an opinion to the contrary?
patacongo edited a comment on issue #21: net: tcp: Fix compile error in tcp.h
URL: https://github.com/apache/incubator-nuttx/pull/21#issuecomment-570003155
@masayuki2009 Removing support for CONFIG_NET_TCPBACKLOG altogether might be
a better solution? Anyone else have an opinion to the con
masayuki2009 commented on issue #21: net: tcp: Fix compile error in tcp.h
URL: https://github.com/apache/incubator-nuttx/pull/21#issuecomment-570004024
> @masayuki2009 Removing support for CONFIG_NET_TCPBACKLOG altogether might
be a better solution? Anyone else have an opinion to the contra
masayuki2009 commented on issue #2: fix builtin_list.c:58:10: fatal error:
builtin_proto.h: No such file …
URL:
https://github.com/apache/incubator-nuttx-apps/pull/2#issuecomment-570016581
Hello @xiaoxiang781216 ,
I noticed that this PR caused a build error for lc823450-xgevk:ipl2
xiaoxiang781216 commented on issue #2: fix builtin_list.c:58:10: fatal error:
builtin_proto.h: No such file …
URL:
https://github.com/apache/incubator-nuttx-apps/pull/2#issuecomment-570017440
I will take a look at this afternoon.
---
masayuki2009 commented on issue #2: fix builtin_list.c:58:10: fatal error:
builtin_proto.h: No such file …
URL:
https://github.com/apache/incubator-nuttx-apps/pull/2#issuecomment-570018779
> I will take a look at this afternoon.
@xiaoxiang781216 Thanks!
xiaoxiang781216 opened a new pull request #3: Add .updated target to handle the
no builtin app case correctly
URL: https://github.com/apache/incubator-nuttx-apps/pull/3
Change-Id: Ia61ff63b4b1e4cb6ec52ac216626bbb76fdf3a33
Signed-off-by: Xiang Xiao
--
xiaoxiang781216 commented on issue #2: fix builtin_list.c:58:10: fatal error:
builtin_proto.h: No such file …
URL:
https://github.com/apache/incubator-nuttx-apps/pull/2#issuecomment-570019713
@masayuki2009 try this PR:
https://github.com/apache/incubator-nuttx-apps/pull/3
I can build
masayuki2009 commented on issue #2: fix builtin_list.c:58:10: fatal error:
builtin_proto.h: No such file …
URL:
https://github.com/apache/incubator-nuttx-apps/pull/2#issuecomment-570024309
> @masayuki2009 try this PR:
> #3
> I can build lc823450-xgevk:ipl2 without error with this pat
patacongo merged pull request #3: Add .updated target to handle the no builtin
app case correctly
URL: https://github.com/apache/incubator-nuttx-apps/pull/3
This is an automated message from the Apache Git Service.
To respon
patacongo closed pull request #14: Fixed includes in
arch/arm/src/stm32l4/hardware/.
URL: https://github.com/apache/incubator-nuttx/pull/14
This is an automated message from the Apache Git Service.
To respond to the message,
patacongo commented on issue #14: Fixed includes in
arch/arm/src/stm32l4/hardware/.
URL: https://github.com/apache/incubator-nuttx/pull/14#issuecomment-570074562
I don't believe this change should be incorporated upstream. It does not
handle the include paths and it takes perfectly compli
acassis commented on issue #14: Fixed includes in
arch/arm/src/stm32l4/hardware/.
URL: https://github.com/apache/incubator-nuttx/pull/14#issuecomment-570075877
Hi wingunder, please note that normally header files included inside
stm32l4/hardware/ directory are mainly used for internal chip
Ouss4 commented on issue #6: publish the website
URL:
https://github.com/apache/incubator-nuttx-website/pull/6#issuecomment-570094059
As far as publishing the website, the change looks good.
This is an automated message from
btashton commented on issue #6: publish the website
URL:
https://github.com/apache/incubator-nuttx-website/pull/6#issuecomment-570095220
I'll take a look tonight, but this does not look right to me. If we are
manually generating the site branch content then I would think it should only
be
yukihiratype2 opened a new pull request #22: Add FMC SDRAM for STM32H7x3 chip
URL: https://github.com/apache/incubator-nuttx/pull/22
The STM32H7 chip's FMC is different from F7 or F4. H7 doesn't have BUSY
register, instead, H7 requires set FMCEN on FMC_BCR1 after configured FMC
registers.
raiden00pl commented on a change in pull request #22: Add FMC SDRAM for
STM32H7x3 chip
URL: https://github.com/apache/incubator-nuttx/pull/22#discussion_r362400857
##
File path: arch/arm/src/stm32h7/Kconfig
##
@@ -41,6 +41,7 @@ config STM32H7_STM32H7X3XX
select ARM
raiden00pl commented on a change in pull request #22: Add FMC SDRAM for
STM32H7x3 chip
URL: https://github.com/apache/incubator-nuttx/pull/22#discussion_r362401691
##
File path: arch/arm/src/stm32h7/stm32_fmc.c
##
@@ -0,0 +1,193 @@
+/***
raiden00pl commented on a change in pull request #22: Add FMC SDRAM for
STM32H7x3 chip
URL: https://github.com/apache/incubator-nuttx/pull/22#discussion_r362402038
##
File path: arch/arm/src/stm32h7/stm32_fmc.c
##
@@ -0,0 +1,193 @@
+/***
raiden00pl commented on a change in pull request #22: Add FMC SDRAM for
STM32H7x3 chip
URL: https://github.com/apache/incubator-nuttx/pull/22#discussion_r362402369
##
File path: arch/arm/src/stm32h7/stm32_fmc.c
##
@@ -0,0 +1,193 @@
+/***
raiden00pl commented on a change in pull request #22: Add FMC SDRAM for
STM32H7x3 chip
URL: https://github.com/apache/incubator-nuttx/pull/22#discussion_r362403221
##
File path: arch/arm/src/stm32h7/stm32_fmc.h
##
@@ -0,0 +1,159 @@
+/***
raiden00pl commented on a change in pull request #22: Add FMC SDRAM for
STM32H7x3 chip
URL: https://github.com/apache/incubator-nuttx/pull/22#discussion_r362403843
##
File path: arch/arm/src/stm32h7/hardware/stm32_fmc.h
##
@@ -0,0 +1,390 @@
+/**
yukihiratype2 commented on a change in pull request #22: Add FMC SDRAM for
STM32H7x3 chip
URL: https://github.com/apache/incubator-nuttx/pull/22#discussion_r362404120
##
File path: arch/arm/src/stm32h7/stm32_fmc.h
##
@@ -0,0 +1,159 @@
+/
raiden00pl commented on a change in pull request #22: Add FMC SDRAM for
STM32H7x3 chip
URL: https://github.com/apache/incubator-nuttx/pull/22#discussion_r362405230
##
File path: arch/arm/src/stm32h7/Make.defs
##
@@ -141,6 +141,10 @@ ifeq ($(CONFIG_STM32H7_DMA),y)
CHIP_CSR
yukihiratype2 commented on a change in pull request #22: Add FMC SDRAM for
STM32H7x3 chip
URL: https://github.com/apache/incubator-nuttx/pull/22#discussion_r362405763
##
File path: arch/arm/src/stm32h7/Make.defs
##
@@ -141,6 +141,10 @@ ifeq ($(CONFIG_STM32H7_DMA),y)
CHIP_
201 - 300 of 588 matches
Mail list logo
