davids5 commented on a change in pull request #12: nxstyle improvements with No
tooling
URL: https://github.com/apache/incubator-nuttx/pull/12#discussion_r362035720
##########
File path: tools/nxstyle.c
##########
@@ -386,24 +467,26 @@ int main(int argc, char **argv, char **envp)
{
if (!bcrs)
{
- fprintf(stderr, "Carriage returns found. "
- "First detected at line %d:%d\n", lineno, n);
+ ERROR("Carriage returns found. "
+ "First detected", lineno, n);
bcrs = true;
}
}
break;
default:
{
- fprintf(stderr,
- "Unexpected white space character %02x found at line
%d:%d\n",
- line[n], lineno, n);
+ snprintf(buffer, sizeof(buffer),
Review comment:
@xiaoxiang781216 -
To make this conform to a very simple API and not lose any of Greg's work in
formatting.
I will not be investing any more time on this.
Please feel free to have your team make any further changes like adding var
args it xiaimi needs them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
