Hello,
I understand the need for improvement but I think there is a better
solution that I am describing at the bottom of this email after the
rationale.
I will keep my request to not break crc16
Also I explain why changing it is useless.
-- why it is useless to change crc16 --
Again, the
What if you need both versions at the same time? Rather than an option to use
one or the the other, options to enable one or both would be more flexible.
Hi Sebastien,
Yes, maybe your suggestion to create a simple/base crc16 that will be the
base for other crc16 variants could make more sense.
It would be nice to have something similar for crc32 as well.
There are many variations listed in this wikipedia page:
https://en.wikipedia.org/wiki/Cycli
+1 if there is backwards compatibility and proper documentation
On Tue, 8 Apr 2025, 04:00 chao an, wrote:
> Hi, Greg，
>
> Glad to hear your voice.
>
> In the current crc16 implementation, we have provided 3 variants. The
> default crc16 semantics is CRC-16/XMODEM:
>
> CRC-16/XMODEM:
> crc16
>
Hello all,
Apache NuttX 12.9.0 RC0 has been staged under [1] and it's
time to vote on accepting it for release. Voting will be open for 72hr.
A minimum of 3 binding +1 votes and more binding +1 than binding -1 are
required to pass.
The Apache requirements for approving a release can be found here
-1 from me, sorry, reading previous messages this seems to break too
many things, just to adhere to a specific solution that is not
standard compliant too.. we need to search for better solution :-)
Would it be possible to create generic crc16() and crc32() calls, like
Alan and Sebastien suggests,
+1
On Mon, 2025-04-07 at 17:13 +0800, chao an wrote:
> Hi community,
>
> Some green hand and individual developer who are not familiar with nuttx
> may be confused by the naming of modlib, in currect implement, modlib as an
> elf loader and parser, does not provide any features other than elf.
>
Hi, Greg，
Glad to hear your voice.
In the current crc16 implementation, we have provided 3 variants. The
default crc16 semantics is CRC-16/XMODEM:
CRC-16/XMODEM:
crc16
crc16part
https://github.com/apache/nuttx/blob/master/libs/libc/misc/lib_crc16.c
CRC-16/CCITT-TRUE:
crc16ccitt
crc16c
I still insist on my opinion that compatibility with popular operating
systems is the best choice
The issues we are discussing now are limited to the premise of not breaking
existing products, but your decision has broken all future programs that
want to compatible NuttX but these programs have
+1 for Milk-V Duo S, Ox64, Star64 and PinePhone
= Milk-V Duo S Compiler
+ riscv-none-elf-gcc -v
Using built-in specs.
COLLECT_GCC=riscv-none-elf-gcc
COLLECT_LTO_WRAPPER=/Users/luppy/xpack-riscv-none-elf-gcc-13.2.0-2/bin/../libexec/gcc/riscv-none-elf/13.2.0/lto-wrapper
Target: riscv-none-elf
Co
+1
Lup
On Mon, Apr 7, 2025 at 5:13 PM chao an wrote:
> Hi community,
>
> Some green hand and individual developer who are not familiar with nuttx
> may be confused by the naming of modlib, in currect implement, modlib as an
> elf loader and parser, does not provide any features other than elf.
There was a lot of comments in the github and I may have missed the
whole of it.
Your information was reassuring, I am not opposing it anymore.
Care is being taken about this issue, that is the most important of all.
Sebastien
On 07/04/2025 15:35, chao an wrote:
@ Sebastien Lorquet
> - br
@ Sebastien Lorquet
> - breaks several build you had to fix incrementally
> However, I see a genuine concern from many members around this change,
actual tests are being made and additional required fixes have been found.
> Also communication efforts have been made beforehand.
This commit does n
Hi, sebastien
I fully understand your concerns, and I agree that changing the default
algorithm may cause trouble to currently active projects.
However, I have searched the code for the application scope of crc16 in
nuttx, and I found that many drivers are using customized CRC-16/IBM
implementatio
+1
Am Mo., 7. Apr. 2025 um 16:49 Uhr schrieb Laczen JMS :
> +1
>
> On Mon, Apr 7, 2025, 11:36 chao an wrote:
>
>> Hi community,
>>
>> Some green hand and individual developer who are not familiar with nuttx
>> may be confused by the naming of modlib, in currect implement, modlib as an
>> elf loa
Hi Sebastien,
This is a case where compatibility is more important than API stability.
New developers are spending a lot of time trying to figure out why existing
code is not working and end up discovering that the issue is the CRC
incompatible with Linux or other OS.
If breaking API is an issue
Hello,
Compatibility with other OSes in this domain is dubious.
What is the actual need for cross-OS crc16 compatibility?
Self-compatibilty is much more important. What is a non volatile storage
structure was created by the old CRC (old release) is checked with the
new CRC?
This will be an
Hi Community,
I plan to switch the default CRC16 algorithm directory of NuttX from
CRC-16/XMODEM to CRC-16/IBM:
https://github.com/apache/nuttx/pull/16147
CRC-16/XMODEM as the default implementation has significant limitations,
especially when communicating with popular operating systems and it c
Hello,
No. No way I will EVER be convinced by this change. The default CRC MUST
NOT change.
I have been maintaining proprietary code bases for 15 years, and I very
well know this frustration, but the answer is still no. A default
cryptographic algorithm can NOT change.
All you can do is m
Hello,
This rename:
- breaks several build you had to fix incrementally
- it fixes nothing not the name.
The modlib name is unfortunate but I think we can live with it.
Also why is the commit showing the name as "ELF" and not "LIBELF"?
That is not acceptable for me. Also -1.
However, I
+1
On Mon, 7 Apr 2025 at 04:58, chao an wrote:
> Hi Community,
>
> I plan to switch the default CRC16 algorithm directory of NuttX from
> CRC-16/XMODEM to CRC-16/IBM:
> https://github.com/apache/nuttx/pull/16147
>
> CRC-16/XMODEM as the default implementation has significant limitations,
> espe
Hi community,
Some green hand and individual developer who are not familiar with nuttx
may be confused by the naming of modlib, in currect implement, modlib as an
elf loader and parser, does not provide any features other than elf.
In this pull request, I plan to rename modlib to elf, and adjust
+1
On Mon, Apr 7, 2025, 11:36 chao an wrote:
> Hi community,
>
> Some green hand and individual developer who are not familiar with nuttx
> may be confused by the naming of modlib, in currect implement, modlib as an
> elf loader and parser, does not provide any features other than elf.
>
> In th
23 matches
Mail list logo
