Hello,
This rename:
- breaks several build you had to fix incrementally
- it fixes nothing not the name.
The modlib name is unfortunate but I think we can live with it.
Also why is the commit showing the name as "ELF" and not "LIBELF"?
That is not acceptable for me. Also -1.
However, I see a genuine concern from many members around this change,
actual tests are being made and additional required fixes have been found.
Also communication efforts have been made beforehand.
I am grateful for this.
Best regards,
Sebastien
On 07/04/2025 11:13, chao an wrote:
Hi community,
Some green hand and individual developer who are not familiar with
nuttx may be confused by the naming of modlib, in currect implement,
modlib as an elf loader and parser, does not provide any features
other than elf.
In this pull request, I plan to rename modlib to elf, and adjust it
from the architecture level as follows:
https://github.com/apache/nuttx/pull/15765
image.png
In addition from other popular operating systems, different loadable
types are all implemented in binfmt. Therefore, it is also impossible
for modlib to support formats other than ELF in the future:
https://github.com/torvalds/linux/blob/master/fs/binfmt_elf.c
https://github.com/torvalds/linux/blob/master/fs/binfmt_elf_fdpic.c
https://github.com/torvalds/linux/blob/master/fs/binfmt_flat.c
https://github.com/torvalds/linux/blob/master/fs/binfmt_misc.c
https://github.com/torvalds/linux/blob/master/fs/binfmt_script.c
https://github.com/alexbousso/kernel_2.4.18-14/blob/master/fs/binfmt_coff.c
This is where they belong:
https://github.com/apache/nuttx/tree/master/binfmt
So I need your vote here:
If you prefer modlib, please reply with -1.
If you recommend libelf, please reply with +1.
BRs,
