Nxstyle is really helpfull...
Verstuurd vanaf mijn iPhone
> Op 22 dec. 2019 om 08:05 heeft Abdelatif Guettouche
> het volgende geschreven:
>
> Hi Justin,
>
> Nxstyle is a C file that you can find under tools.
>
> You can build it under any OS.
> Greg is just using Windows.
>
>> On Sun, Dec
Thank you Nathan!
On 2019/12/22 06:01:55, Nathan Hartman wrote:
> On Sat, Dec 21, 2019 at 7:26 PM Gregory Nutt wrote:
>
> > Let me start by stating a few [obvious] objectives:
> > Keep things simple for those NuttX users who prefer to work with a zip’d
> > release.
> > provide best-practice to
Hi,
> Please point me to where this work should be done and any guide you have on
> how to use Confluence.
NuttX space is here [1] it's easy to use, so you probably don’t need
documentation on how to use it, but if you do it can be found here. [2]
Currently only PPMC members has permission to
Ok, maybe more progress. I re-flashed the SPI NOR flash with new files from
the linux4sam website. Now I can see the serial terminal on the debug port
during boot. I can stop the boot process using U-Boot, and use U-Boot to
load a nuttx.bin image. This process is suggested in the board README.
But
TLDNR; But you really should. Because I will ask for some discussion and votes
on the subject matter.
We all come from different places in the world. We all have had different
experiences. We all have learned different things. We all have learned in
different ways. We all have different commu
This works!
On 2019/12/22 02:05:56, Brennan Ashton wrote:
> I really want to let people to contribute (myself included) ASAP so I was
> to propose this as an option to get going and can be amended later. I know
> it does not resolve all the issues, but offers what I think is a reasonable
> avenu
+1.
It's impotant to let people start the contribution.
The committer could/should do more work to ensure the correction in
review process before the automation tool is ready.
Thanks
Xiang
On Sun, Dec 22, 2019 at 8:57 PM David Sidrane wrote:
>
> This works!
>
> On 2019/12/22 02:05:56, Brennan As
+1
On Sun, Dec 22, 2019, 15:57 Xiang Xiao wrote:
> +1.
> It's impotant to let people start the contribution.
> The committer could/should do more work to ensure the correction in
> review process before the automation tool is ready.
>
> Thanks
> Xiang
>
> On Sun, Dec 22, 2019 at 8:57 PM David Si
Writing directly into the repository was certainly the wrong thing at
the wrong time since I was tasked to maintain the repository. But I
relinquish both the task of personally reviewing and managing the flow
all changes. So now it is a fair thing to be address. Now I would say
what committe
+1
On Sat, Dec 21, 2019, 10:04 Disruptive Solutions <
disruptivesolution...@gmail.com> wrote:
> +1
>
> Verstuurd vanaf mijn iPhone
>
> > Op 21 dec. 2019 om 08:27 heeft David Sidrane
> het volgende geschreven:
> >
> > +1
> >
> > -Original Message-
> > From: Brennan Ashton [mailto:bash...
0
I think is a terrible idea. Doing something for expediency usually is.
But I will go along with the group think.
On 12/22/2019 7:59 AM, Alin Jerpelea wrote:
+1
On Sun, Dec 22, 2019, 15:57 Xiang Xiao wrote:
+1.
It's impotant to let people start the contribution.
The committer could/sho
Did someone call a vote on this? This is all very confusing.
First, we have adopted the shorthand of +1 just to mean you agree with
something. That is not a vote and a little confusing in most contexts.
Votes should be formally called with [VOTE] in the subject. Otherwise,
how can I tell i
patacongo commented on issue #1: imxrt fixes
URL: https://github.com/apache/incubator-nuttx/pull/1#issuecomment-568266571
'master' has never been 'dev' in this repository. You are thinking of a
different repository that was managed by a single person.
davids5 commented on issue #1: imxrt fixes
URL: https://github.com/apache/incubator-nuttx/pull/1#issuecomment-568267090
> 'master' has never been 'dev' in this repository. You are thinking of a
different repository that was managed by a single person.
Yes - I am so glad you are so e
patacongo commented on issue #1: imxrt fixes
URL: https://github.com/apache/incubator-nuttx/pull/1#issuecomment-568268123
With a single committer, you can greatly simplify things since it is the
sole reponsibility of that single committed to go from the patch to PR to its
clean incorporat
Again, is this a formal vote? it is not clear to me. Did someone in
the PPMC call a vote? There is not [VOTE] in the message title?
Just point of order which I do not know the answer too. Brennan is not
yet listed as a PPMC member or a as a committer (but he should be and,
hopefully, will
All,
Let's dispense with the ALL ambiguity
We should assume if it does not say [VOTE] it is not a vote?
David
-Original Message-
From: Gregory Nutt [mailto:spudan...@gmail.com]
Sent: Sunday, December 22, 2019 7:09 AM
To: dev@nuttx.apache.org
Subject: Re: Simple Workflow Proposal
Aga
+1 binding
On 2019/12/22 15:13:03, David Sidrane wrote:
> All,
>
> Let's dispense with the ALL ambiguity
>
> We should assume if it does not say [VOTE] it is not a vote?
>
> David
>
>
>
> -Original Message-
> From: Gregory Nutt [mailto:spudan...@gmail.com]
> Sent: Sunday, December
+1
(sorry, I couldn't help it)
On 12/22/2019 9:13 AM, David Sidrane wrote:
All,
Let's dispense with the ALL ambiguity
We should assume if it does not say [VOTE] it is not a vote?
David
-Original Message-
From: Gregory Nutt [mailto:spudan...@gmail.com]
Sent: Sunday, December 22, 2
I thought I was being humorous in replying with +1. But [VOTE] is in
the title so I guess this is a real, binding vote. That wasn't clear
from the text. I am so confused. Anway, my +1 vote still stands, just
not as funny anymore.
On 12/22/2019 9:14 AM, Gregory Nutt wrote:
+1
(sorry, I co
Removing the initial [VOTE] in an attempt at removing ambiguity
(although [VOTE] is still in the tile).
Let's dispense with the ALL ambiguity
We should assume if it does not say [VOTE] it is not a vote?
A follow on questions is who can call a binding vote? I searched apache
a little, but did
Should the [VOTE] phase also be preceded by a [DISCUSS] phase so that
people can have a chance to discuss, debate, haggle, argue, first?
Calling a vote out the blue leaves people in a position of having to
make a decision cold.
On 12/22/2019 9:26 AM, Gregory Nutt wrote:
Removing the initial [
I thought I was being humorous in replying with +1. But [VOTE] is in
the title so I guess this is a real, binding vote. That wasn't clear
from the text. I am so confused. Anway, my +1 vote still stands,
just not as funny anymore.
You did not mention how long the vote will be open for.
I thought I was being humorous in replying with +1. But [VOTE] is in
the title so I guess this is a real, binding vote. That wasn't clear
from the text. I am so confused. Anway, my +1 vote still stands,
just not as funny anymore.
You did not mention how long the vote will be open for.
+1
On Sun, Dec 22, 2019, 17:45 Gregory Nutt wrote:
>
> > I thought I was being humorous in replying with +1. But [VOTE] is in
> > the title so I guess this is a real, binding vote. That wasn't clear
> > from the text. I am so confused. Anway, my +1 vote still stands,
> > just not as funny an
I did not call for a vote because I did not think I could as I'm just a
community member, I would like my proposal formally voted it on as is.
As for the two concerns that I saw raised.
1) The timeline. Two weeks over the holiday to come to a formal agreement
is going to be tough and I also don'
Let's get everyone's thoughts on the table
I did not call for a vote because I did not think I could as I'm just a
community member, I would like my proposal formally voted it on as is.
As for the two concerns that I saw raised.
1) The timeline. Two weeks over the holiday to come to a formal
1) The timeline. Two weeks over the holiday to come to a formal
agreement
is going to be tough and I also don't think just because we have a path
forward people will stop caring about proposing a better solution. From
what I'm seeing the longer term proposal will likely get into the
weeds of
Let's get everyone's thoughts on the table
I suppose that we should keep the discussion for 72 hours then call the
vote. We need to allow time for everyone to comment and with the
holidays, we may not be able to get good feedback. Should we still call
a vote if people are not participatin
I don't think that were will be much that has to be acted on during
the holidays. And, in any event, I would rather see a backlog of work
build up than to to see an interim, wrong workflow put in place. Doing
things right is more important that doing things quickly.
I would add that I do no
On Sun, Dec 22, 2019 at 9:00 AM Gregory Nutt wrote:
> Writing directly into the repository was certainly the wrong thing at
> the wrong time since I was tasked to maintain the repository. But I
> relinquish both the task of personally reviewing and managing the flow
> all changes. So now it is
Hopefully someone with technical writing skills will volunteer to read that
email and start working on that document. If not, I'll do it, but it will
be delayed because I am completely swamped right now.
I think that the other people most active in the discussion are DavidS
and myself, but f
Enjoy vacation!
On Sat, Dec 21, 2019, 08:18 David Sidrane wrote:
> Enjoy!
>
> -Original Message-
> From: Justin Mclean [mailto:jus...@classsoftware.com]
> Sent: Friday, December 20, 2019 5:07 PM
> To: dev@nuttx.apache.org
> Subject: Away for two weeks
>
> H,
>
> I’m off on a two week bre
Hopefully someone with technical writing skills will volunteer to
read that
email and start working on that document. If not, I'll do it, but it
will
be delayed because I am completely swamped right now.
I think that the other people most active in the discussion are DavidS
and myself, b
On Sun, Dec 22, 2019 at 2:16 PM Gregory Nutt wrote:
>
> >
> >> Hopefully someone with technical writing skills will volunteer to
> >> read that
> >> email and start working on that document. If not, I'll do it, but it
> >> will
> >> be delayed because I am completely swamped right now.
> >
> > I
Don't feel bad if there is haggling. Any document, no matter who writes it
or how well, will need more work to fill in missing pieces, edit, etc., to
bring it to "shipping quality." I will try to help as much as I can in the
coming days, but as I said I'm really swamped right now.
But there a
davids5 opened a new pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2
@patacongo -
This will get us off the ground on the formatting tool we can get in to the
workfow.
We are going to need your expertise on the the makefile
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725335
##
File path: tools/nxstyle.c
##
@@ -50,6 +50,45 @@
#define LINE_SIZE512
+#define FATAL(m) message(F
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725352
##
File path: tools/nxstyle.c
##
@@ -50,6 +50,45 @@
#define LINE_SIZE512
+#define FATAL(m) message(F
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725366
##
File path: tools/nxstyle.c
##
@@ -50,6 +50,45 @@
#define LINE_SIZE512
+#define FATAL(m) message(F
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725385
##
File path: tools/nxstyle.c
##
@@ -61,6 +100,34 @@ static void show_usage(char *progname, int exitcode)
exit(e
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725443
##
File path: tools/nxstyle.c
##
@@ -50,6 +50,45 @@
#define LINE_SIZE512
+#define FATAL(m) message(FATA
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725416
##
File path: tools/nxstyle.c
##
@@ -50,6 +50,45 @@
#define LINE_SIZE512
+#define FATAL(m) message(FATA
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725475
##
File path: tools/nxstyle.c
##
@@ -477,7 +543,7 @@ int main(int argc, char **argv, char **envp)
(strcm
Ouss4 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725448
##
File path: tools/nxstyle.c
##
@@ -50,6 +50,45 @@
#define LINE_SIZE512
+#define FATAL(m) message(FATAL,
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725490
##
File path: tools/nxstyle.c
##
@@ -477,7 +543,7 @@ int main(int argc, char **argv, char **envp)
(strcm
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725573
##
File path: tools/Makefile.unix
##
@@ -192,11 +192,18 @@ NUTTXNAME = nuttx
BIN = $(NUTTXNAME)$(EXEEXT)
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725585
##
File path: tools/nxstyle.c
##
@@ -477,7 +543,7 @@ int main(int argc, char **argv, char **envp)
(strcmp(l
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725573
##
File path: tools/Makefile.unix
##
@@ -192,11 +192,18 @@ NUTTXNAME = nuttx
BIN = $(NUTTXNAME)$(EXEEXT)
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725633
##
File path: tools/Makefile.unix
##
@@ -192,11 +192,18 @@ NUTTXNAME = nuttx
BIN = $(NUTTXNAME)$(EXEEXT)
all
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725723
##
File path: tools/nxstyle.c
##
@@ -171,20 +238,21 @@ int main(int argc, char **argv, char **envp)
}
else
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725817
##
File path: tools/nxstyle.c
##
@@ -50,6 +50,45 @@
#define LINE_SIZE512
+#define FATAL(m) message(FATA
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725490
##
File path: tools/nxstyle.c
##
@@ -477,7 +543,7 @@ int main(int argc, char **argv, char **envp)
(strcm
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725833
##
File path: tools/nxstyle.c
##
@@ -50,6 +50,45 @@
#define LINE_SIZE512
+#define FATAL(m) message(FATA
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360726015
##
File path: tools/nxstyle.c
##
@@ -50,6 +50,45 @@
#define LINE_SIZE512
+#define FATAL(m) message(F
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725880
##
File path: tools/nxstyle.c
##
@@ -50,6 +50,45 @@
#define LINE_SIZE512
+#define FATAL(m) message(FATA
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725846
##
File path: tools/nxstyle.c
##
@@ -50,6 +50,45 @@
#define LINE_SIZE512
+#define FATAL(m) message(FATA
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725908
##
File path: tools/nxstyle.c
##
@@ -61,6 +100,34 @@ static void show_usage(char *progname, int exitcode)
exit(exit
Ouss4 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360726048
##
File path: tools/nxstyle.c
##
@@ -50,6 +50,45 @@
#define LINE_SIZE512
+#define FATAL(m) message(FATAL,
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725892
##
File path: tools/nxstyle.c
##
@@ -50,6 +50,45 @@
#define LINE_SIZE512
+#define FATAL(m) message(FATA
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360725965
##
File path: tools/nxstyle.c
##
@@ -477,7 +543,7 @@ int main(int argc, char **argv, char **envp)
(strcmp(l
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360726228
##
File path: tools/nxstyle.c
##
@@ -50,6 +50,45 @@
#define LINE_SIZE512
+#define FATAL(m) message(F
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360726498
##
File path: tools/Makefile.unix
##
@@ -192,11 +192,18 @@ NUTTXNAME = nuttx
BIN = $(NUTTXNAME)$(EXEEXT)
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360726623
##
File path: tools/Makefile.unix
##
@@ -697,3 +704,8 @@ apps_distclean:
ifneq ($(APPDIR),)
$(Q) $(MAKE) -
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360726623
##
File path: tools/Makefile.unix
##
@@ -697,3 +704,8 @@ apps_distclean:
ifneq ($(APPDIR),)
$(Q) $(MAKE) -
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360727266
##
File path: tools/Makefile.unix
##
@@ -697,3 +704,8 @@ apps_distclean:
ifneq ($(APPDIR),)
$(Q) $(MAKE) -
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360727266
##
File path: tools/Makefile.unix
##
@@ -697,3 +704,8 @@ apps_distclean:
ifneq ($(APPDIR),)
$(Q) $(MAKE) -
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360727425
##
File path: tools/check_code_style.sh
##
@@ -0,0 +1,33 @@
+#!/usr/bin/env bash
+
+if [ -z "$1" ]; then
+ FI
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360727398
##
File path: tools/check_code_style.sh
##
@@ -0,0 +1,33 @@
+#!/usr/bin/env bash
+
+if [ -z "$1" ]; then
+ FI
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360727667
##
File path: tools/Makefile.unix
##
@@ -192,11 +192,18 @@ NUTTXNAME = nuttx
BIN = $(NUTTXNAME)$(EXEEXT)
all
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360727717
##
File path: tools/Makefile.unix
##
@@ -697,3 +704,8 @@ apps_distclean:
ifneq ($(APPDIR),)
$(Q) $(MAKE) -C "
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360727720
##
File path: tools/check_code_style.sh
##
@@ -0,0 +1,33 @@
+#!/usr/bin/env bash
+
+if [ -z "$1" ]; then
+ FILES
davids5 commented on a change in pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360727718
##
File path: tools/check_code_style.sh
##
@@ -0,0 +1,33 @@
+#!/usr/bin/env bash
+
+if [ -z "$1" ]; then
+ FILES
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360728147
##
File path: tools/Makefile.unix
##
@@ -192,11 +192,18 @@ NUTTXNAME = nuttx
BIN = $(NUTTXNAME)$(EXEEXT)
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360728147
##
File path: tools/Makefile.unix
##
@@ -192,11 +192,18 @@ NUTTXNAME = nuttx
BIN = $(NUTTXNAME)$(EXEEXT)
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360728415
##
File path: tools/Makefile.unix
##
@@ -192,11 +192,18 @@ NUTTXNAME = nuttx
BIN = $(NUTTXNAME)$(EXEEXT)
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360728732
##
File path: tools/Makefile.unix
##
@@ -697,3 +704,8 @@ apps_distclean:
ifneq ($(APPDIR),)
$(Q) $(MAKE) -
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360726623
##
File path: tools/Makefile.unix
##
@@ -697,3 +704,8 @@ apps_distclean:
ifneq ($(APPDIR),)
$(Q) $(MAKE) -
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360728789
##
File path: tools/Makefile.unix
##
@@ -697,3 +704,8 @@ apps_distclean:
ifneq ($(APPDIR),)
$(Q) $(MAKE) -
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360728886
##
File path: tools/nxstyle.c
##
@@ -171,20 +238,21 @@ int main(int argc, char **argv, char **envp)
}
else
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360729083
##
File path: tools/nxstyle.c
##
@@ -140,7 +207,7 @@ int main(int argc, char **argv, char **envp)
maxline = 7
HI,
> Should the [VOTE] phase also be preceded by a [DISCUSS] phase so that people
> can have a chance to discuss, debate, haggle, argue, first?
It’s best if that is done, as I’ve mentioned before yes. Votes shod be used to
confirm consensus not split the community.
> A follow on questions is
HI,
> Also, if you don't specify the criteria for accepting the vote, I assume that
> it must be a simple majority of those who vote.
Votes, are almost never a simple majority, releases come close where a -1 is
not a veto but you need 3 +1 votes. Please see [1] and [2]. For most decision
make
Hi,
I want to contribute to Nuttx,
I want to share some idea to Nuttx.
BR
NiiJyeni
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360730399
##
File path: tools/Makefile.unix
##
@@ -697,3 +704,8 @@ apps_distclean:
ifneq ($(APPDIR),)
$(Q) $(MAKE) -
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360730444
##
File path: tools/Makefile.unix
##
@@ -697,3 +704,8 @@ apps_distclean:
ifneq ($(APPDIR),)
$(Q) $(MAKE) -
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360730444
##
File path: tools/Makefile.unix
##
@@ -697,3 +704,8 @@ apps_distclean:
ifneq ($(APPDIR),)
$(Q) $(MAKE) -
patacongo commented on a change in pull request #2: Master pr nxstyle
improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#discussion_r360732967
##
File path: tools/check_code_style.sh
##
@@ -0,0 +1,33 @@
+#!/usr/bin/env bash
+
Review comment:
Missing li
patacongo closed pull request #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
patacongo commented on issue #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#issuecomment-568309238
I added Xiao Xiang to the reviewers. We need to have a lot of concurrence
here since this PR implements a portion of the workflow while there no workf
patacongo edited a comment on issue #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#issuecomment-568309238
I added Xiao Xiang to the reviewers. We need to have a lot of concurrence
here since this PR implements a portion of the workflow while there n
Please accept my most humble apologies for not including the correct
details in the original email
This is a Consensus approval vote and it will close 72 hours after it was
opened.
-- Forwarded message -
From: David Sidrane
Date: Sun, Dec 22, 2019, 7:14 AM
Subject: Re: [VOTE] - vo
There are several things I don't like about this proposal:
- It is in complete conflict with everything we have discussed about
the commit workflow
- I think is is suggest out of panic. We have plenty of times to do
things right or to do things better. There will be no pressing nee
There are several things I don't like about this proposal:
- It is in complete conflict with everything we have discussed
about the commit workflow
- I think is is suggest out of panic. We have plenty of times to
do things right or to do things better. There will be no pressi
I proposed this because I think it is a solid flow and in alignment with
other stable opensource projects that I contribute to including one under
the FSF complexity.
It is NOT a rush and I don't think it is out of line. Multiple +1 were
given, so I don't think it's that far off what will work.
Please send an email to dev-subscr...@nuttx.apache.org for subscribing.
Nii Jyeni 于2019年12月23日周一 上午5:25写道：
> Hi,
> I want to contribute to Nuttx,
> I want to share some idea to Nuttx.
>
> BR
> NiiJyeni
>
I don't like it because it is not the workflow that has been discussed
and I can never support a slam dunk of any workflow that is not
described in the workflow requirements document.
I will vote -1 if we cannot be assured that this this cannot become a
disease that we cannot shake. My propos
patacongo commented on issue #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#issuecomment-568317600
What is this? How did I do this? What does closed mean? What was closed?
This is an
patacongo edited a comment on issue #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#issuecomment-568317600
What is this? How did I do this? What does closed mean? Is that like
declined? What was closed?
Do I need to unclose something?
-
patacongo edited a comment on issue #2: Master pr nxstyle improvments
URL: https://github.com/apache/incubator-nuttx/pull/2#issuecomment-568317600
What is this? How did I do this? What does closed mean? Is that like
declined? What was closed?
Do I need to unclose something?
...
1 - 100 of 120 matches
Mail list logo
