Re: Vote for using system dd instead of nsh dd, avoid duplicate code

2025-04-15 Thread Alan C. Assis
Yes, if we can merge both in a single dd command, but keep the configuration to have a small dd (like that from nshlib) for small microcontroller as Sebastien suggested, it will be fine. +1 On Mon, Apr 14, 2025 at 10:59 AM Xiang Xiao wrote: > The functionality in system/dd and nshlib is unsync,

Re: Vote for using system dd instead of nsh dd, avoid duplicate code

2025-04-14 Thread chao an
+1 The duplication of the same features in the system is a nuisance to developers, who do not understand which version to use or which version has more advantages. In addition, removing redundancy also helps optimize the usage of flash/ram. BRs, Tomek CEDRO 于2025年4月14日周一 22:18写道: > Thanks Xiang

Re: Vote for using system dd instead of nsh dd, avoid duplicate code

2025-04-14 Thread Tomek CEDRO
Thanks Xiang for the details :-) Why not add the unsync to the nsh/dd and keep this one still as minimal default with more features delectable instead removing? :-) Aside question did NuttX consider `/bin/dd` versus built-in `dd` (something like built-in `time` versus `/usr/bin/time` in Unix)? We

Re: Vote for using system dd instead of nsh dd, avoid duplicate code

2025-04-14 Thread Sebastien Lorquet
Great, thanks for the precision. I still wonder about the increased flash use but it is still possible to improve that later. +1 Sebastien On 14/04/2025 15:58, Xiang Xiao wrote: The functionality in system/dd and nshlib is unsync, this patch: 1. update system/dd to get the same functio

Re: Vote for using system dd instead of nsh dd, avoid duplicate code

2025-04-14 Thread Xiang Xiao
The functionality in system/dd and nshlib is unsync, this patch: 1. update system/dd to get the same functionality as nshlib/dd 2. remove one copy(nshlib/dd) to avoid the inconsistency in the future. Good work! thanks. On Mon, Apr 14, 2025 at 9:07 PM 董九柱 wrote: > Hello Community, > > I

Sv: Vote for using system dd instead of nsh dd, avoid duplicate code

2025-04-14 Thread alin.jerpe...@sony.com
+1 Best Alin Från: Lee, Lup Yuen Skickat: den 14 april 2025 15:53 Till: dev@nuttx.apache.org Ämne: Re: Vote for using system dd instead of nsh dd, avoid duplicate code +1 Hi Donny: Please remember to close the voting in 72 hours. Thanks :-) Lup On Mon, Apr 14

Re: Vote for using system dd instead of nsh dd, avoid duplicate code

2025-04-14 Thread Lee, Lup Yuen
+1 Hi Donny: Please remember to close the voting in 72 hours. Thanks :-) Lup On Mon, Apr 14, 2025 at 9:07 PM 董九柱 wrote: > Hello Community, > > I submit some PRs about using system/dd app instead of dd command from > nshlib. > > PR link: > https://github.com/apache/nuttx-apps/pull/3057 > https:

Re: Vote for using system dd instead of nsh dd, avoid duplicate code

2025-04-14 Thread Sebastien Lorquet
Hello 1 - code duplication has never been rejected in nuttx 2 - it hurts no one since each of them can be selected individually. My vote: Do nothing unless you actually justify the real life problem you're facing that requires this. Ideally: -1 because that's just cosmetics. But I know you

Vote for using system dd instead of nsh dd, avoid duplicate code

2025-04-14 Thread 董九柱
Hello Community, I submit some PRs about using system/dd app instead of dd command from nshlib. PR link: https://github.com/apache/nuttx-apps/pull/3057 https://github.com/apache/nuttx/pull/16198 Why do? There are two implementations of dd in the current system, one under nshlib and the other und