Hello
1 - code duplication has never been rejected in nuttx
2 - it hurts no one since each of them can be selected individually.
My vote: Do nothing unless you actually justify the real life problem
you're facing that requires this.
Ideally: -1 because that's just cosmetics.
But I know you all hate anyone opposing "change".
Since it would not break nuttx, I'm not going to spend many spoons on
this. That's just one more useless change stirring the code soup.
The nsh dd is interesting as a SMALL program.
The system dd is interesting as a FEATURED program.
Maybe just make sure that both programs are merged into one and no
functions are lost? Add options to disable secondary features for use in
small microcontrollers?
Sebastien
On 14/04/2025 15:05, 董九柱 wrote:
Hello Community,
I submit some PRs about using system/dd app instead of dd command from
nshlib.
PR link:
https://github.com/apache/nuttx-apps/pull/3057
https://github.com/apache/nuttx/pull/16198
Why do?
There are two implementations of dd in the current system, one under nshlib
and the other under system/dd.
we need to remove one to avoid duplication code and function lost. The
discuss: https://github.com/apache/nuttx-apps/pull/3048
From the current perspective, the system "dd" is a better choice, as it
allows for the separate configuration of its corresponding stack and
compilation into an independent wasm module.
How do?
1. Align the functionality of "dd" in nshlib with that in the system "dd"
to ensure consistent functionality.
2. Remove implement of dd in nshlib, include
config(CONFIG_NSH_DISABLE_DD、NSH_CMDOPT_DD_STATS) and
file(nshlib/nsh_ddcmd.c)
3. Adjust all board configurations to ensure backward and forward
compatibility.
So I need your vote here:
If you accept the breaking PR, please reply with +1.
If you reject the PR, please reply with -1.
BRs,
