Helping someone is not a bad thing.
Consider the effect on the community and the code.
What use to happen with patches: patches were emailed, ***modified*** and
committed.
Submitted != Committed - Was that BAD Etiquette?
What use to happen with a PR: PR were submitted, 1-N more commits were mad
Completely forbidding this functionality will deprive us from a useful feature.
We may need it now to help with overwhelming style complaints that
were not introduced by the PR or in the future if the contributor asks
for some sort of help.
We just need some moderation and resort to this only after
Hi,
> So what you suggest it that we as committer don't need disscuss
> anything with the contributor, we just need take his PR and do what we
> think the right modification then merge directly.
You could either discuss it with them or accept the PR and improve it. What you
do may be decided on
On Sun, Mar 15, 2020 at 12:59 PM Justin Mclean wrote:
>
> Hi,
>
> > Yes, this is last resort. It's better to discuss PR in the github and
> > let the contributor fix the problem by self. The collaboration model
> > can decrease the divergence and improve the community health.
>
> In my experience
On Sun, Mar 15, 2020 at 12:59 AM Justin Mclean
wrote:
> Hi,
>
> > Yes, this is last resort. It's better to discuss PR in the github and
> > let the contributor fix the problem by self. The collaboration model
> > can decrease the divergence and improve the community health.
>
> In my experience t
Hi,
> Yes, this is last resort. It's better to discuss PR in the github and
> let the contributor fix the problem by self. The collaboration model
> can decrease the divergence and improve the community health.
In my experience this has the opposite effect, it discourages newcomers from
contribu
On Sun, Mar 15, 2020 at 5:31 AM Gregory Nutt wrote:
>
> Question: Github permits committer to modify the content of
> contributors PRs through this mechanism:
> https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/committing-changes-to-a-pull-request-branch-created-from-a
