On Sun, Mar 15, 2020 at 12:59 AM Justin Mclean <jus...@classsoftware.com>
wrote:

> Hi,
>
> > Yes, this is last resort. It's better to discuss PR in the github and
> > let the contributor fix the problem by self. The collaboration model
> > can decrease the divergence and improve the community health.
>
> In my experience this has the opposite effect, it discourages newcomers
> from contributing. You want to help contributors out so that they become
> committers over time. But as they say you milage may vary. You want a low
> bar for new people to be able to become contributors and to become
> committers.
>
> > It's better to limit this direct modification in some special case,
> > for example the owner don't response PR for a long time.
>
> If they don’t respond it mean you have driven them away, and that teh best
> time to ask yourself what could you have done differently to keep them
> involved?


I fear that I might have prompted this discussion because I created PR558
and then didn't get around to fixing the items that were brought up. It was
*not* my intention to abandon the PR, and I wasn't driven away by the
discussion that ensued there. I've just had a lot on my plate lately and
others were faster than me. Thanks to everyone who reviewed, corrected, and
merged it (in the form of replacement PR565).
Nathan

Reply via email to