Re: [EXT] socketcan ioctl(...SIOCSCANBITRATE...) brings the interface up

2025-04-16 Thread Carlos Sanchez
> > While testing this, I think I have discovered a small mistake on my > > previous, Nuttx-side PR, which slipped by me and by revision: "ret" > > might be used uninitialized now because I removed the assignment on > > stm32_fdcan_sock:1976 > Yes, please make a PR to fix that!! When it's ready, p

Re: [EXT] socketcan ioctl(...SIOCSCANBITRATE...) brings the interface up

2025-04-15 Thread Xiang Xiao
On Wed, Apr 16, 2025 at 1:25 AM Carlos Sanchez wrote: > Related PR on the apps side, to make slcan work after the "bitrate no > longer brings interface up" change: > https://github.com/apache/nuttx-apps/pull/3059 > > While testing this, I think I have discovered a small mistake on my > previous,

Re: [EXT] socketcan ioctl(...SIOCSCANBITRATE...) brings the interface up

2025-04-15 Thread Nathan Hartman
On Tue, Apr 15, 2025 at 1:25 PM Carlos Sanchez wrote: > Related PR on the apps side, to make slcan work after the "bitrate no > longer brings interface up" change: > https://github.com/apache/nuttx-apps/pull/3059 > > While testing this, I think I have discovered a small mistake on my > previous,

Re: [EXT] socketcan ioctl(...SIOCSCANBITRATE...) brings the interface up

2025-04-15 Thread Carlos Sanchez
Related PR on the apps side, to make slcan work after the "bitrate no longer brings interface up" change: https://github.com/apache/nuttx-apps/pull/3059 While testing this, I think I have discovered a small mistake on my previous, Nuttx-side PR, which slipped by me and by revision: "ret" might be

Re: [EXT] socketcan ioctl(...SIOCSCANBITRATE...) brings the interface up

2025-04-11 Thread Carlos Sanchez
Hi Peter, that is the same flow I was thinking of. I will create a PR affecting all the existing drivers. Thanks, Carlos On Fri, Apr 11, 2025 at 1:42 PM Peter van der Perk wrote: > > Hi Carlos, > > I think your concern is valid and that the current implementation of > SIOCSCANBITRATE is a bu

RE: [EXT] socketcan ioctl(...SIOCSCANBITRATE...) brings the interface up

2025-04-11 Thread Peter van der Perk
Hi Carlos, I think your concern is valid and that the current implementation of SIOCSCANBITRATE is a bugged. I think the solution would be to only allow SIOCSCANBITRATE when the interface is down. My proposal would be that SIOCSCANBITRATE checks if the interface is already up and if that's th