Re: [EXT] [PROPOSAL] New nxstyle tool roadmap

2025-03-17 Thread Filipe Cavalcanti
Hi all, I'm a strong supporter of linting tools that can save us work during development. In fact, I added the pre-commit-config to NuttX so I can apply nxstyle at each commit in a "nicer" way (even though I'm sure most people are not aware of it). Honestly, if this was a new project, I would

Re: Re: [VOTE] ROUND2 NuttX Contributing Guidelines update 202502.

2025-02-27 Thread Filipe Cavalcanti
1. Contributing Guidelines with hints for Reviewers. > We are adding additional section for Reviewers to Contributing > Guidelines in order to provide checklist and complementary set of > rules that should filter out breaking code as much as possible also on > our side. +1 Tomek +1 Alin +1 Tiago

Re: [VOTE] NuttX Contributing Guidelines update 202502.

2025-02-13 Thread Filipe Cavalcanti
Hi all, here's my update on items 18 and 19 recently added. 18: +1 Following suggestions from my colleagues, please also add documentation to this. 19: +1 Makes sense to me. I strongly support this as we don't have that many people to review and approve. We can't stop going forward, but this ite

Re: [VOTE] NuttX Contributing Guidelines update 202502.

2025-02-11 Thread Filipe Cavalcanti
Hi all, Here's my two cents. 1. +1 2. +1 3. +1 4. +1 5. +1 6. +1 7. +1 8. +1 9. +1 with a consideration: Some changes might affect multiple boards and it may not be possible for a user to test it all. I think this is where input from reviewers come in by making sure, at least in theory, that th

Re: nuttx-apps/testing reorganization

2025-01-10 Thread Filipe Cavalcanti
ed opinion. From: Tomek CEDRO Sent: Thursday, January 9, 2025 9:28 PM To: dev@nuttx.apache.org Subject: Re: nuttx-apps/testing reorganization [External: This email originated outside Espressif] On Thu, Jan 9, 2025 at 4:51 PM Filipe Cavalcanti wrote: > Hi there! > I think ha

Re: nuttx-apps/testing reorganization

2025-01-09 Thread Filipe Cavalcanti
Hi there! I think having tests under `testing/` is good if it mirrors the directory structure of the OS. `testing/sched/clock`: sched/clock specific tests `testing/mm/iob`: mm/IOB specific tests `testing/sched/signal`: signal tests Seems the PR you mentioned goes towards this idea, but I unders

Re: [VOTE] Apache NuttX 12.8.0 RC0 release

2025-01-03 Thread Filipe Cavalcanti
ess and >> delay the release. >> Adding features on demand during the vote may trigger a new feature >> request >> which may delay the release again (the process may repeat many times since >> we did it once) >> >> My proposal is to continue the release as it is a

Re: [VOTE] Apache NuttX 12.8.0 RC0 release

2025-01-02 Thread Filipe Cavalcanti
Sorry for the broken email response. Found some style issues on many include files on arch/xtensa. We suspect those came up due to adding SPDX identifier, causing the files to be checked by the CI. We'll fix it and submit a PR. Thanks. Filipe From: F

Re: [VOTE] Apache NuttX 12.8.0 RC0 release

2025-01-02 Thread Filipe Cavalcanti
-1 We are having issues testing ESP32C3 on this tag, due to a missing fix. Can we backport this PR? https://github.com/apache/nuttx/pull/15321 [https://opengraph.githubassets.com/81ba79de2d577149394fe3e933d244bb47903f11701e3954febfdae67530b95c/apache/nuttx/pull/15321]

Re: [VOTE] Apache NuttX 12.7.0 RC1 release

2024-10-28 Thread Filipe Cavalcanti
+1 for Espressif supported boards and chips. The following devices were tested using the internal CI with all available defconfigs. - esp32_devkitc - esp32_ethernet_kit - esp32_lyrat - esp32_pico_kit - esp32_wrover_kit - esp32c3_devkit - esp32c3_generic - esp32c6_devkitc - esp32c6_devkitm - esp3