Hi there! I think having tests under `testing/` is good if it mirrors the directory structure of the OS.
`testing/sched/clock`: sched/clock specific tests `testing/mm/iob`: mm/IOB specific tests `testing/sched/signal`: signal tests Seems the PR you mentioned goes towards this idea, but I understand some tests do not exactly fit into the structure as we want. For those cases, I'm sure some structure could be developed. I have seen and used this structure (mirroring the OS directories) when the testing source is also on the main project folder, but I'm sure it could work on the apps repo. Regarding item 2, I don't see why we would need to put `cmocka` on the path. In the PR you showed (2935), `test_<feature>.c` looks clean. Looking forward to hear from others. Filipe ________________________________ From: Tomek CEDRO <to...@cedro.info> Sent: Thursday, January 9, 2025 10:53 AM To: dev@nuttx.apache.org <dev@nuttx.apache.org> Subject: nuttx-apps/testing reorganization [External: This email originated outside Espressif] Hello world :-) There is a interesting PR to move and group existing nuttx-apps/testing tests into directories by feature: https://github.com/apache/nuttx-apps/pull/2931 As I understand this is not about test rewrite just reorganization at this point. We are discussing the feature names where tests can be moved to things are intuitive and self-explanatory. If you have ideas and comments on the feature names and test locations your feedback is highly welcome :-) Particular points: 1. Do we want generic OS tests like stress tests time etc in `sched/` (scheduler) category or the generic `os/` category while `sched/` would contain scheduler specific tests? 2. There are lots of generic test cases implemeneted with CMOCKA framework. These tests would go to `mm/cmocka`, `net/cmocka`, `sched/cmocka`, etc. The question is cmocka the right name for the tests (it shows the feature and that tests are implemented with cmocka) or `mm/generic` or `mm/basic` is better name (it would not imply cmocka framework used)? For instance today a proposition for nettest using cmocka showed up (https://github.com/apache/nuttx-apps/pull/2935) but that would duplicate `net/cmocka`.. so I think keeping the cmocka may not be the bad choice :-) Any hints welcome, please join the discussion :-) Tomek -- CeDeROM, SQ7MHZ, http://www.tomek.cedro.info
