Re: Vote for default crc16 directory to be CRC-16/XMODEM or CRC-16/IBM

I can empathize. But we just don't want to fill this regret again in the new building. The lack of standards is currently the biggest issue hindering the promotion of this proposal. Another interesting thing, I'd like to share another data from github: if we search for the lookup table of crc16 on

Re: Vote for default crc16 directory to be CRC-16/XMODEM or CRC-16/IBM

On Wed, Apr 9, 2025 at 3:45 AM chao an wrote: > > > > On Tue, Apr 8, 2025 at 7:17 PM Lwazi Dube wrote: > > > > An open source project's ability to innovate should not be > > > > held up by your preferences. > > > > > > The last sentence is completely wrong. Its not about "preference" but > > > im

Re: Vote for default crc16 directory to be CRC-16/XMODEM or CRC-16/IBM

I am neutral to map crc16 to crc16ibmpart unconditionally, but against changing the map by Kconfig. On Wed, Apr 9, 2025 at 9:56 AM chao an wrote: > I want to reach a consensus with everyone > We have spent too much time explaining similar issues to different > developers. we can see that @Alan

Re: Vote for default crc16 directory to be CRC-16/XMODEM or CRC-16/IBM

I want to reach a consensus with everyone We have spent too much time explaining similar issues to different developers. we can see that @Alan has wanted to promote this for a long time. As Lwazi said, the discussion in the community is for code and future directions, not for politics. If the expe

Re: Vote for default crc16 directory to be CRC-16/XMODEM or CRC-16/IBM

> > > > The last sentence is completely wrong. Its not about "preference" but > > impacting self-compatibility and long term maintenance. Messing the > > foundations and defaults is not innovation. Try building a home when > > the project constantly changes during the process, when you have 10 > >

Re: [VOTE] Apache NuttX 12.9.0 RC0 release

Yes, but there are coupled changes: this commit changed the SPI flash frequency for ESP32-H2 (it doesn't support 48MHz, but it must be flashed at this speed). However, for MCUboot, it relies on `CONFIG_ESPTOOLPY_FLASH

Re: Vote for rename modlib to libelf

Hi Takashi :-) There were long discussions on the mailing list, then voting, then discussion on the PR, and comes after lots of breaking changes being too freely merged into the upstream, sometimes with laconic description and sometimes without even testing. This is to focus more on long term self

Re: Vote for rename modlib to libelf

On Wed, Apr 9, 2025 at 9:22 AM Tomek CEDRO wrote: > > Hi Takashi :-) > > There were long discussions on the mailing list, then voting, then > discussion on the PR, and comes after lots of breaking changes being > too freely merged into the upstream, sometimes with laconic > description and sometim

Re: Vote for default crc16 directory to be CRC-16/XMODEM or CRC-16/IBM

On Tue, 8 Apr 2025 at 13:32, Xiang Xiao wrote: > On Wed, Apr 9, 2025 at 1:16 AM Lwazi Dube wrote: > > > On Tue, 8 Apr 2025 at 05:23, Sebastien Lorquet > > wrote: > > > > > Hello, > > > > > > Nathan proposal to have a kconfig, with a default to the historical > > > algorithm, is a good solution.

Re: Vote for rename modlib to libelf

-1 reading the recently added text in CONTRIBUTING.md, this change doesn't seem even eligible for voting because it is not "absolutely necessary and unavoidable". i personally like the change itself and prefer loosening the rules in CONTRIBUTING.md though. On Mon, Apr 7, 2025 at 6:13 PM chao an

Re: Vote for rename modlib to libelf

> > > If you prefer modlib, please reply with -1. > > > If you recommend libelf, please reply with +1. Rules for voting are a little different for code changes. The required Apache voting process is here: https://www.apache.org/foundation/voting.html For code changes, that document says: "Vot

Re: [VOTE] Apache NuttX 12.9.0 RC0 release

Hi, thanks for the explanation For the future please mark this kind of commits so that they are included We will see if there are other -1 ans add it to RC1 Thanks for testing and reporting the issue On Tue, 8 Apr 2025, 20:10 Tiago Medicci Serrano, wrote: > Yes, but there are coupled changes:

Re: Vote for default crc16 directory to be CRC-16/XMODEM or CRC-16/IBM

There was some false information in his comments but I am here for the code not the politics. Are you -1 on @anchao's original vote? On Tue, 8 Apr 2025 at 14:54, Peter Barada wrote: > +1 regarding Tomek's comments. > > I'm all for documenting the current semantics of CRCs used by Nuttx and > ex

Re: Vote for default crc16 directory to be CRC-16/XMODEM or CRC-16/IBM

On Tue, 8 Apr 2025 at 14:49, Xiang Xiao wrote: > On Wed, Apr 9, 2025 at 2:02 AM Lwazi Dube wrote: > > > On Tue, 8 Apr 2025 at 13:32, Xiang Xiao > wrote: > > > > > On Wed, Apr 9, 2025 at 1:16 AM Lwazi Dube wrote: > > > > > > > On Tue, 8 Apr 2025 at 05:23, Sebastien Lorquet > > > > > wrote: > >

Re: Vote for default crc16 directory to be CRC-16/XMODEM or CRC-16/IBM

+1 regarding Tomek's comments. I'm all for documenting the current semantics of CRCs used by Nuttx and expanding function names where they match well known standard CRCs, but any effort to change(or worse make configurable) the semantics of CRCs as currently used in Nuttx leads to a world of h

Re: Vote for default crc16 directory to be CRC-16/XMODEM or CRC-16/IBM

On Wed, Apr 9, 2025 at 2:02 AM Lwazi Dube wrote: > On Tue, 8 Apr 2025 at 13:32, Xiang Xiao wrote: > > > On Wed, Apr 9, 2025 at 1:16 AM Lwazi Dube wrote: > > > > > On Tue, 8 Apr 2025 at 05:23, Sebastien Lorquet > > > wrote: > > > > > > > Hello, > > > > > > > > Nathan proposal to have a kconfig,

Re: Vote for default crc16 directory to be CRC-16/XMODEM or CRC-16/IBM

On Tue, Apr 8, 2025 at 7:17 PM Lwazi Dube wrote: > No. The open source project provides the ability for proprietary forks to > override the master branch default with the company default. Your approach > stalls the development process. A trivial change like this should not take > a week to commit.

Re: [VOTE] Apache NuttX 12.9.0 RC0 release

the spi flas selection is not a fix but a feature! On Tue, 8 Apr 2025, 18:37 Tiago Medicci Serrano, wrote: > -1. > > Unfortunately, `esp32h2-devkit:mcuboot_nsh` is broken. To build the MCUboot > bootloader, the following PR is required: > https://github.com/apache/nuttx/pull/16131 > > Em ter., 8

Re: [VOTE] Apache NuttX 12.9.0 RC0 release

-1. Unfortunately, `esp32h2-devkit:mcuboot_nsh` is broken. To build the MCUboot bootloader, the following PR is required: https://github.com/apache/nuttx/pull/16131 Em ter., 8 de abr. de 2025 às 03:41, Lee, Lup Yuen escreveu: > +1 for Milk-V Duo S, Ox64, Star64 and PinePhone > > = Milk-V Du

Re: Vote for default crc16 directory to be CRC-16/XMODEM or CRC-16/IBM

On Wed, Apr 9, 2025 at 1:16 AM Lwazi Dube wrote: > On Tue, 8 Apr 2025 at 05:23, Sebastien Lorquet > wrote: > > > Hello, > > > > Nathan proposal to have a kconfig, with a default to the historical > > algorithm, is a good solution. > > > > Kconfig will work if you mean this: > > int16_t crc16(FAR

Re: Vote for default crc16 directory to be CRC-16/XMODEM or CRC-16/IBM

On Tue, 8 Apr 2025 at 05:23, Sebastien Lorquet wrote: > Hello, > > Nathan proposal to have a kconfig, with a default to the historical > algorithm, is a good solution. > Kconfig will work if you mean this: int16_t crc16(FAR const uint8_t *src, size_t len) { #if defined(CONFIG_CRC16_IBM) retur

Re: Vote for rename modlib to libelf

+1 On Tue, Apr 8, 2025 at 8:55 AM Tiago Medicci Serrano wrote: > > +1 > > Em seg., 7 de abr. de 2025 às 21:16, Yanfeng Liu > escreveu: > > > +1 > > On Mon, 2025-04-07 at 17:13 +0800, chao an wrote: > > > Hi community, > > > > > > Some green hand and individual developer who are not familiar with

Re: Vote for rename modlib to libelf

+1 Em seg., 7 de abr. de 2025 às 21:16, Yanfeng Liu escreveu: > +1 > On Mon, 2025-04-07 at 17:13 +0800, chao an wrote: > > Hi community, > > > > Some green hand and individual developer who are not familiar with nuttx > > may be confused by the naming of modlib, in currect implement, modlib as >

Re: Vote for default crc16 directory to be CRC-16/XMODEM or CRC-16/IBM

Hello, Nathan proposal to have a kconfig, with a default to the historical algorithm, is a good solution. I Maintain, DO NOT CHANGE THE DEFAULT CRC ROUTINE. CRCs are relied upon for data structure integrity validation. If you change the default, new code will consider valid data record as