Re: NuttX 10.3 release plan

2022-03-28 Thread Nathan Hartman
On Mon, Mar 28, 2022 at 8:32 AM alin.jerpe...@sony.com < alin.jerpe...@sony.com> wrote: > > @Nathan Hartman please check if you can fix the format > https://cwiki.apache.org/confluence/display/NUTTX/NuttX+10.3 > Hi Alin, What needs to be fixed? Cheers Nathan > >

Re: NuttX github code review practices

2022-03-28 Thread Abdelatif Guettouche
> Have a few custom boards in the test process. we're talking build > testing, not runtime. No need for a farm. We actually should do this. It should be possible to have a few custom boards in another repository (the old testing repo for instance) and trigger its workflow on PRs. I believe once G

Re: NuttX 10.3 release plan

2022-03-28 Thread Abdelatif Guettouche
I am OK with removing the disclaimer for 10.3. Thank you for your work on this, Alin! On Mon, Mar 28, 2022 at 2:32 PM alin.jerpe...@sony.com wrote: > > Hi all, > > I am happy to announce the confluence release notes are ready and we can > proceed with the NuttX 10.3-RC0 release > > @Nathan Hartm

Re: usleep can't wake up incidentally in tickless mode

2022-03-28 Thread fft
Hi Alan, I'm tried enable the CONFIG_PRIORITY_INHERITANCE and the problem remains, thanks for your reply Best regard Zou    -- Original -- From:  "Alan Carvalho de Assis"

Re: NuttX github code review practices

2022-03-28 Thread Sebastien Lorquet
Sorry, I cant possibly test every commit and tell you what breaks Have a few custom boards in the test process. we're talking build testing, not runtime. No need for a farm. I am not actively developing in nuttx. I'm just using it. Your request is ONLY possible for contributors working on Nu

RE: NuttX 10.3 release plan

2022-03-28 Thread alin.jerpe...@sony.com
Hi all, I am happy to announce the confluence release notes are ready and we can proceed with the NuttX 10.3-RC0 release @Nathan Hartman please check if you can fix the format https://cwiki.apache.org/confluence/display/NUTTX/NuttX+10.3 Does anyone oppose to the removal of the DISCLAIMER for 1

Re: NuttX github code review practices

2022-03-28 Thread Alan Carvalho de Assis
On 3/28/22, Sebastien Lorquet wrote: > In this example it's Xiaomi and Sony. > > NuttX has a code review problem and it has to be identified and addressed. > > I have the same feeling here, last time I tried to send a pull request, > it took several day to fix style issues for a ONE LINE code typo

Re: NuttX github code review practices

2022-03-28 Thread Xiang Xiao
On Mon, Mar 28, 2022 at 6:02 PM Sebastien Lorquet wrote: > In this example it's Xiaomi and Sony. > > NuttX has a code review problem and it has to be identified and addressed. > The review strictly follows the process setup and agreed by the community, and the process is also similar to other Ap

Re: NuttX github code review practices

2022-03-28 Thread Xiang Xiao
On Mon, Mar 28, 2022 at 5:30 PM Jukka Laitinen wrote: > Another example: > > https://github.com/apache/incubator-nuttx/pull/5731 > > A PR which looks like 0 gain, 100 risk of breaking everything (breaks > our stuff at least), This patch can improve the context switch performance, since it could

Re: NuttX github code review practices

2022-03-28 Thread Sebastien Lorquet
In this example it's Xiaomi and Sony. NuttX has a code review problem and it has to be identified and addressed. I have the same feeling here, last time I tried to send a pull request, it took several day to fix style issues for a ONE LINE code typo. And a lot of board breaking changes are co

Re: NuttX github code review practices

2022-03-28 Thread Jukka Laitinen
Another example: https://github.com/apache/incubator-nuttx/pull/5731 A PR which looks like 0 gain, 100 risk of breaking everything (breaks our stuff at least), and can only work in FLAT_BUILD mode (if even in that?). How does stuff like this get in? Xiaomi does and approves by themselves? S