On 3/28/22, Sebastien Lorquet <sebast...@lorquet.fr> wrote: > In this example it's Xiaomi and Sony. > > NuttX has a code review problem and it has to be identified and addressed. > > I have the same feeling here, last time I tried to send a pull request, > it took several day to fix style issues for a ONE LINE code typo. >
Most probably you didn't follow the process to verify for code style errors etc: https://nuttx.apache.org/docs/latest/contributing/making-changes.html#git-workflow-with-an-upstream-repository > And a lot of board breaking changes are committed regularly. when you > have a custom board it's not fun. > Please help us to test! We don't have CI with a board farm test to help us. > I believe a LOT of things including new features happens "silently" in > github comments only, and very little is discussed on this mailing list. > This mailing list purpose it not for code reviewing, but you can subscribe on github or apache repository to receive an email with each PR and with each comment other people are doing. We need more people to review the code, not more people to complain! BR, Alan
