Re: Support of SPARC architecture

2022-01-15 Thread Gregory Nutt
I use tools/indent.sh when I need to reformat a file. It is imperfect, but can reduce the 1000's to 100's (see the README for quirks). It doesn't fix naming, of course. On Sat, Jan 15, 2022 at 6:30 AM fft wrote: > It seems that there are thousands of coding style problem,I was > frightened

RE: Move to C99 for common code

2022-01-15 Thread Gregory Nutt
I suppose that if someone really wants to use z80, they would need to hunt down a better compiler. When we removed those SDCC hacks from the code, we were under the belief that SDCC had corrected that problem. But obviously not. I would not recommend restoring them. They are too invasive and

Re: Move to C99 for common code

2022-01-15 Thread Alan Carvalho de Assis
Just to let you know, I tested the Z80 and it was broken: https://acassis.wordpress.com/2022/01/14/testing-nuttx-rtos-on-z80-simulator/ As Mr. Greg commented in this post, the guilt was this commit: https://github.com/apache/incubator-nuttx/commit/67ec3d7926d871c515fb1a55a11da8630fe53649 If I g

Re: Support of SPARC architecture

2022-01-15 Thread Alan Carvalho de Assis
In the past someone tried to create a tool to autoformat the coding style of NuttX, but it wasn't finished and the result wasn't that great. Most of issues reported on your PR are alignment, maybe some editor can help you to fix it automatically. But the remaining long lines should be fixed manual

Re: Support of SPARC architecture

2022-01-15 Thread fft
It seems that there are thousands of coding style problem,I was frightenedthis is a difficult task for me,Is there any tools that can automatically modify the coding style problem?    -- Original -- From:  "Alan Carvalho de Assis"https://github.com/apache/incub

Re: Support of SPARC architecture

2022-01-15 Thread Alan Carvalho de Assis
That is a great news mister Zou! I saw there are some file that need to have its coding style fixed to pass in the CI test: https://github.com/apache/incubator-nuttx/runs/4826456444?check_suite_focus=true You can also check locally the coding style using the checkpatch, this way: $ ./tools/check