[GitHub] [incubator-nuttx-testing] patacongo commented on issue #2: Multibranch pipeline job example

2020-02-06 Thread GitBox
patacongo commented on issue #2: Multibranch pipeline job example URL: https://github.com/apache/incubator-nuttx-testing/pull/2#issuecomment-583058333 As an Apache project, we do have follow certain rules before bringing in any 3rd party software. I think we need a software grant now.

[GitHub] [incubator-nuttx-testing] davids5 commented on issue #2: Multibranch pipeline job example

2020-02-06 Thread GitBox
davids5 commented on issue #2: Multibranch pipeline job example URL: https://github.com/apache/incubator-nuttx-testing/pull/2#issuecomment-583018447 > Well, in theory, that should be true. In practice, usually not, as far as I have seen in all my career. Yes and No. I am sp

Re: [PATCH] Small fix to add support to STM32F030CC

2020-02-06 Thread Alan Carvalho de Assis
Thank you! On 2/6/20, Abdelatif Guettouche wrote: > Hi Alan, > > Committed. > > On Thu, Feb 6, 2020 at 4:41 PM Alan Carvalho de Assis > wrote: >> >> Please apply attached patch to include support to STM32F030CC, >> suggested by Florian. >> >> BR, >> >> Alan >

Re: [PATCH] Small fix to add support to STM32F030CC

2020-02-06 Thread Abdelatif Guettouche
Hi Alan, Committed. On Thu, Feb 6, 2020 at 4:41 PM Alan Carvalho de Assis wrote: > > Please apply attached patch to include support to STM32F030CC, > suggested by Florian. > > BR, > > Alan

[PATCH] Small fix to add support to STM32F030CC

2020-02-06 Thread Alan Carvalho de Assis
Please apply attached patch to include support to STM32F030CC, suggested by Florian. BR, Alan From 4baa1734b62b3bc669594da8ea396520d08c4457 Mon Sep 17 00:00:00 2001 From: Alan Carvalho de Assis Date: Thu, 6 Feb 2020 13:33:13 -0300 Subject: [PATCH] Small fix to add support to STM32F030CC --- ar

[GitHub] [incubator-nuttx-testing] patacongo commented on issue #2: Multibranch pipeline job example

2020-02-06 Thread GitBox
patacongo commented on issue #2: Multibranch pipeline job example URL: https://github.com/apache/incubator-nuttx-testing/pull/2#issuecomment-582917813 PX4 software is welcome provided that it is properly donated via a software grant, has an Apache 2 license, and goes through the same PR pr

Re: [PATCH] Add MemoryMap and PinMap support to STM32F030RC

2020-02-06 Thread Alan Carvalho de Assis
Hi Florian, Nice to hear from you. Yes it is already included in the master branch. In order to support to STM32F030CC you just need this modification: $ git diff arch/arm/include/stm32f0l0g0/chip.h diff --git a/arch/arm/include/stm32f0l0g0/chip.h b/arch/arm/include/stm32f0l0g0/chip.h index 6c9

Re: [PATCH] Add MemoryMap and PinMap support to STM32F030RC

2020-02-06 Thread Florian Wehmeyer
Hi Alan, thanks a lot! I also already had included the CONFIG_ARCH_CHIP_STM32F030CC and tested (but not built a patch, as I'm still not an advanced nuttx user nor contributor) , and can confirm the modifications in your patch. Additionally, I was able to include and successfully test the TIM3