Re: [VOTE] Release Lucene 10.0.0 RC4

2024-10-10 Thread Patrick Zhai
SUCCESS! [1:13:39.316068] +1 I also have run an extra knn benchmark with 9.12 and 10.0, verified no recall degradation On Thu, Oct 10, 2024 at 1:51 PM Benjamin Trent wrote: > SUCCESS! [0:56:23.261438] > > + 1! > > On Thu, Oct 10, 2024 at 1:16 PM Dawid Weiss wrote: > > > > SUCCESS! [1:20:05.96

Re: [VOTE] Release Lucene 10.0.0 RC4

2024-10-10 Thread Michael McCandless
+1 SUCCESS! [0:18:16.706133] Mike McCandless http://blog.mikemccandless.com On Thu, Oct 10, 2024 at 1:26 AM Luca Cavanna wrote: > Please vote for release candidate 4 for Lucene 10.0.0 > > I published a draft of the release notes at > https://cwiki.apache.org/confluence/display/LUCENE/Release

Re: [JENKINS] Lucene-9.x-MacOSX (64bit/hotspot/jdk-17.0.9) - Build # 4409 - Failure!

2024-10-10 Thread Luca Cavanna
That's a good question, I've seen some failed builds on Jenkins due to the missing branch, for instance https://ci-builds.apache.org/job/Lucene/job/Lucene-NightlyTests-9.x/1014/console . I think I meant to remove those jobs when I created the new ones for 10x, but I must have forgotten. Going to t

Re: branch_9x removed from origin?

2024-10-10 Thread Luca Cavanna
Hey Dawid, it was brought up in this thread: https://lists.apache.org/thread/8nvnqm7njjho7df99fjx6dxm4zcr7dhj . Like Chris said in that thread, branch_9_12 has all the 9x commits, if we wish to recreate branch_9x we can from branch_9_12 but I would not think that's necessary. I don't know why bran

Re: branch_9x removed from origin?

2024-10-10 Thread Chris Hegarty
Hi Dawid, > On 10 Oct 2024, at 10:57, Dawid Weiss wrote: > > > Hmm... Has someone removed branch_9x entirely from the origin git? Yes, that was me, see https://lists.apache.org/thread/8nvnqm7njjho7df99fjx6dxm4zcr7dhj Before removing I checked that there was nothing in that branch that is not

Re: branch_9x removed from origin?

2024-10-10 Thread Chris Hegarty
To close the loop on this. Tombstone branch_9x PR raised and merged. https://github.com/apache/lucene/pull/13882 -Chris. > On 10 Oct 2024, at 11:27, Dawid Weiss wrote: > > > Thank you, Chris! > > Dawid > > On Thu, Oct 10, 2024 at 12:23 PM Chris Hegarty > wrote: > If that is what was do

Re: [VOTE] Release Lucene 10.0.0 RC4

2024-10-10 Thread Chris Hegarty
+1 SUCCESS! [3:08:50.803948] I ran the smoktester with JDK 21.0.x, 22.0.x, and 23. Hence the long run time :-) -Chris. > On 10 Oct 2024, at 08:24, Luca Cavanna wrote: > > Please vote for release candidate 4 for Lucene 10.0.0 > > I published a draft of the release notes at > https://cwiki

Re: [JENKINS] Lucene-9.x-MacOSX (64bit/hotspot/jdk-17.0.9) - Build # 4409 - Failure!

2024-10-10 Thread Luca Cavanna
Instead of removing those 9.x jobs, I have configured them to point to branch_9_12 and renamed them. I thought we already had specific 9.12 jobs but that was not the case and it seemed correct to keep those running. On Thu, Oct 10, 2024 at 3:34 PM Luca Cavanna wrote: > That's a good question, I'

Re: branch_9x removed from origin?

2024-10-10 Thread Dawid Weiss
Thank you. I think this is better. Some of the dev branches we have in the repo don't make any particular sense but these long-standing dev branches from which releases were cut seem more important. Dawid On Thu, Oct 10, 2024 at 3:01 PM Chris Hegarty wrote: > > To close the loop on this. > > To

Re: [VOTE] Release Lucene 10.0.0 RC3

2024-10-10 Thread Luca Cavanna
No worries at all Mike, thanks for the hard work everyone involved! I am happy we fixed the issue and were able to backport a couple more fixes. Cheers Luca On Thu, Oct 10, 2024 at 1:50 AM Michael McCandless < luc...@mikemccandless.com> wrote: > OK I cherry-pick'd to 10.0.x and 10.x ... I think

[VOTE] Release Lucene 10.0.0 RC4

2024-10-10 Thread Luca Cavanna
Please vote for release candidate 4 for Lucene 10.0.0 I published a draft of the release notes at https://cwiki.apache.org/confluence/display/LUCENE/Release+Notes+10.0.0 . Feedback is welcome. Feel free to edit directly. The artifacts can be downloaded from: https://dist.apache.org/repos/dist/dev

Re: branch_9x removed from origin?

2024-10-10 Thread Dawid Weiss
Ok, thank you. Disappearing branches are a bit puzzling if you have a tracking branch locally. For branch_8x, we removed the content and left a note stating what happened: https://github.com/apache/lucene-solr/tree/branch_8x This still refers to branch_9x, for example. Maybe we should do the same

Re: branch_9x removed from origin?

2024-10-10 Thread Chris Hegarty
If that is what was done previously, then sure let’s just do that. I’ll restore branch_9x and then prepare PR to wipe it’s contents and place with a readme pointing to branch_9_12. -Chris. > On 10 Oct 2024, at 11:17, Dawid Weiss wrote: > > > Ok, thank you. Disappearing branches are a bit puz

Re: branch_9x removed from origin?

2024-10-10 Thread Dawid Weiss
Thank you, Chris! Dawid On Thu, Oct 10, 2024 at 12:23 PM Chris Hegarty wrote: > If that is what was done previously, then sure let’s just do that. > > I’ll restore branch_9x and then prepare PR to wipe it’s contents and place > with a readme pointing to branch_9_12. > > -Chris. > > > On 10 Oct

branch_9x removed from origin?

2024-10-10 Thread Dawid Weiss
Hmm... Has someone removed branch_9x entirely from the origin git? I'd think we'd like to keep the label, even if the branch is not meant for any future development, similar to branch_8x that still exists in lucene-solr repo. Dawid

Re: [JENKINS] Lucene-9.x-MacOSX (64bit/hotspot/jdk-17.0.9) - Build # 4409 - Failure!

2024-10-10 Thread Michael McCandless
This build timed out ... but how is it even able to run? We had deleted branch_9x... (soon to be restored with only a tombstone). Mike McCandless http://blog.mikemccandless.com On Wed, Oct 9, 2024 at 3:17 PM Policeman Jenkins Server wrote: > Build: https://jenkins.thetaphi.de/job/Lucene-9.x-

Re: [VOTE] Release Lucene 10.0.0 RC4

2024-10-10 Thread Tomás Fernández Löbbe
+1 SUCCESS! [1:07:20.700731] On Thu, Oct 10, 2024 at 7:03 AM Chris Hegarty wrote: > +1 > > SUCCESS! [3:08:50.803948] > > I ran the smoktester with JDK 21.0.x, 22.0.x, and 23. Hence the long run > time :-) > > -Chris. > > > On 10 Oct 2024, at 08:24, Luca Cavanna wrote: > > > > Please vote for r

Re: [JENKINS] Lucene-main-Linux (64bit/hotspot/jdk-21.0.1) - Build # 50504 - Failure!

2024-10-10 Thread Michael McCandless
Hmm: java.lang.VirtualMachineError: Out of space in CodeCache for adapters Mike McCandless http://blog.mikemccandless.com On Thu, Oct 10, 2024 at 11:32 AM Policeman Jenkins Server < jenk...@thetaphi.de> wrote: > Build: https://jenkins.thetaphi.de/job/Lucene-main-Linux/50504/ > Java: 64bit/h

Re: [JENKINS] Lucene-9.x-Linux (64bit/hotspot/jdk-11.0.21) - Build # 18991 - Still Failing!

2024-10-10 Thread Michael McCandless
I think we need Uwe to turn this off -- 9.x is now just a tombstone. Mike McCandless http://blog.mikemccandless.com On Thu, Oct 10, 2024 at 12:01 PM Policeman Jenkins Server < jenk...@thetaphi.de> wrote: > Build: https://jenkins.thetaphi.de/job/Lucene-9.x-Linux/18991/ > Java: 64bit/hotspot/jdk

Re: [VOTE] Release Lucene 10.0.0 RC4

2024-10-10 Thread Chris Hegarty
Hi Stefan, > On 10 Oct 2024, at 16:41, Stefan Vodita wrote: > > ... > > We didn't mention the new aggregation engine [1] in the release notes for 9.12 > and that seems like a missed opportunity. It's a significant change, which > improves over the existing faceting functionality in terms of fle

Re: [VOTE] Release Lucene 10.0.0 RC4

2024-10-10 Thread Stefan Vodita
+1 SUCCESS! [0:35:35.851448] We didn't mention the new aggregation engine [1 ] in the release notes for 9.12 and that seems like a missed opportunity. It's a significant change, which improves over the existing faceting functionality in terms of flexibi

Re: [JENKINS] Lucene-9.x-MacOSX (64bit/hotspot/jdk-17.0.9) - Build # 4409 - Failure!

2024-10-10 Thread Michael McCandless
Thanks Luca. Mike McCandless http://blog.mikemccandless.com On Thu, Oct 10, 2024 at 7:40 AM Luca Cavanna wrote: > Instead of removing those 9.x jobs, I have configured them to point to > branch_9_12 and renamed them. I thought we already had specific 9.12 jobs > but that was not the case and

Re: [VOTE] Release Lucene 10.0.0 RC4

2024-10-10 Thread Michael Sokolov
+1 SUCCESS! [1:25:19.133719] On Thu, Oct 10, 2024 at 9:42 AM Stefan Vodita wrote: > > +1 SUCCESS! [0:35:35.851448] > > We didn't mention the new aggregation engine [1] in the release notes for 9.12 > and that seems like a missed opportunity. It's a significant change, which > improves over the

Re: [VOTE] Release Lucene 10.0.0 RC4

2024-10-10 Thread Dawid Weiss
SUCCESS! [1:20:05.964755] +1. I've reviewed the artifacts, ran Luke, etc. Nothing caught my attention other than the NOTICE.txt file - Apache Lucene Copyright 2001-2022 The Apache Software Foundation Don't know if this should be updated (perhaps). Not a blocker, definitely. Dawid On Thu, Oc

Re: [VOTE] Release Lucene 10.0.0 RC4

2024-10-10 Thread Benjamin Trent
SUCCESS! [0:56:23.261438] + 1! On Thu, Oct 10, 2024 at 1:16 PM Dawid Weiss wrote: > > SUCCESS! [1:20:05.964755] > > +1. > > I've reviewed the artifacts, ran Luke, etc. Nothing caught my attention other > than the NOTICE.txt file - > > Apache Lucene > Copyright 2001-2022 The Apache Software Foun