[jira] [Commented] (KAFKA-774) Periodic refresh of topic metadata on the producer does not check for error code in the response

2013-02-26 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587614#comment-13587614 ] Swapnil Ghike commented on KAFKA-774: - Useful stuff, +1. > Periodic re

[jira] [Updated] (KAFKA-773) kafka.integration.PrimitiveApiTest fails intermittently

2013-02-26 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-773: Attachment: kafka-773-v2.patch Yes you're right. Attached patch v2. > kafka.integra

[jira] [Commented] (KAFKA-774) Periodic refresh of topic metadata on the producer does not check for error code in the response

2013-02-26 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587737#comment-13587737 ] Swapnil Ghike commented on KAFKA-774: - I doubt if the v2 patch will do what it intends

[jira] [Commented] (KAFKA-774) Periodic refresh of topic metadata on the producer does not check for error code in the response

2013-02-26 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587747#comment-13587747 ] Swapnil Ghike commented on KAFKA-774: - Yes, your change consolidates everything, which

[jira] [Comment Edited] (KAFKA-774) Periodic refresh of topic metadata on the producer does not check for error code in the response

2013-02-26 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587747#comment-13587747 ] Swapnil Ghike edited comment on KAFKA-774 at 2/26/13 11:55 PM: --

[jira] [Commented] (KAFKA-774) Periodic refresh of topic metadata on the producer does not check for error code in the response

2013-02-26 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587788#comment-13587788 ] Swapnil Ghike commented on KAFKA-774: - Yup, looks good. +1 > Periodic

[jira] [Updated] (KAFKA-513) Add state change log to Kafka brokers

2013-02-26 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-513: Attachment: kafka-513-v3.patch Rebased. All comments are the same as those on patch v2.

[jira] [Commented] (KAFKA-513) Add state change log to Kafka brokers

2013-02-27 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13588677#comment-13588677 ] Swapnil Ghike commented on KAFKA-513: - Um just curious, did you look at my comments whi

[jira] [Work started] (KAFKA-776) Changing ZK format breaks some tools

2013-02-27 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-776 started by Swapnil Ghike. > Changing ZK format breaks some tools > > > Key: KAFKA-776 >

[jira] [Commented] (KAFKA-776) Changing ZK format breaks some tools

2013-02-27 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13588922#comment-13588922 ] Swapnil Ghike commented on KAFKA-776: - >From what I see in the code, kafka.admin.Shutdo

[jira] [Updated] (KAFKA-776) Changing ZK format breaks some tools

2013-02-27 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-776: Attachment: kafka-776-v1.patch Attached a patch to fix the 4 tools. > Changing ZK f

[jira] [Updated] (KAFKA-776) Changing ZK format breaks some tools

2013-02-27 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-776: Attachment: kafka-776-v2.patch Attached the changes. > Changing ZK format breaks so

[jira] [Commented] (KAFKA-513) Add state change log to Kafka brokers

2013-02-28 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13590216#comment-13590216 ] Swapnil Ghike commented on KAFKA-513: - There are many changes, the non-tool part of the

[jira] [Comment Edited] (KAFKA-513) Add state change log to Kafka brokers

2013-02-28 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13590216#comment-13590216 ] Swapnil Ghike edited comment on KAFKA-513 at 3/1/13 3:53 AM: - T

[jira] [Updated] (KAFKA-513) Add state change log to Kafka brokers

2013-03-01 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-513: Attachment: kafka-513-v4.patch Uploading patch v4. The comments on the merge tool are written above.

[jira] [Created] (KAFKA-779) Standardize Zk data structures for Re-assign partitions and Preferred replication election

2013-03-01 Thread Swapnil Ghike (JIRA)
Swapnil Ghike created KAFKA-779: --- Summary: Standardize Zk data structures for Re-assign partitions and Preferred replication election Key: KAFKA-779 URL: https://issues.apache.org/jira/browse/KAFKA-779

[jira] [Created] (KAFKA-780) Reassign partition tool produces NPE in shutdown handler

2013-03-03 Thread Swapnil Ghike (JIRA)
Swapnil Ghike created KAFKA-780: --- Summary: Reassign partition tool produces NPE in shutdown handler Key: KAFKA-780 URL: https://issues.apache.org/jira/browse/KAFKA-780 Project: Kafka Issue Type

[jira] [Updated] (KAFKA-780) Reassign partitions tool produces NPE in shutdown handler

2013-03-03 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-780: Summary: Reassign partitions tool produces NPE in shutdown handler (was: Reassign partition tool pr

[jira] [Commented] (KAFKA-780) Reassign partitions tool produces NPE in shutdown handler

2013-03-03 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13591727#comment-13591727 ] Swapnil Ghike commented on KAFKA-780: - Probably the same issue occurs in PrefferedRepli

[jira] [Comment Edited] (KAFKA-779) Standardize Zk data structures for Re-assign partitions and Preferred replication election

2013-03-03 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13591980#comment-13591980 ] Swapnil Ghike edited comment on KAFKA-779 at 3/4/13 4:29 AM: - C

[jira] [Updated] (KAFKA-779) Standardize Zk data structures for Re-assign partitions and Preferred replication election

2013-03-03 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-779: Attachment: kafka-779-v1.patch Changes: 1. Zk data format standardization for admin/reassign_partit

[jira] [Updated] (KAFKA-763) Add an option to replica from the largest offset during unclean leader election

2013-03-04 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-763: Labels: kafka-0.8 p2 (was: p2) > Add an option to replica from the largest offset during unclea

[jira] [Updated] (KAFKA-779) Standardize Zk data structures for Re-assign partitions and Preferred replication election

2013-03-04 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-779: Attachment: kafka-779-v2.patch Modified the description of the --path-to-json-file option required b

[jira] [Created] (KAFKA-785) jsonFileOpt in PreferredReplicaLeaderElectionTool should not be "required"

2013-03-04 Thread Swapnil Ghike (JIRA)
Swapnil Ghike created KAFKA-785: --- Summary: jsonFileOpt in PreferredReplicaLeaderElectionTool should not be "required" Key: KAFKA-785 URL: https://issues.apache.org/jira/browse/KAFKA-785 Project: Kafka

[jira] [Assigned] (KAFKA-785) jsonFileOpt in PreferredReplicaLeaderElectionTool should not be "required"

2013-03-04 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike reassigned KAFKA-785: --- Assignee: Sriram Subramanian (was: Swapnil Ghike) > jsonFileOpt in PreferredReplicaLeader

[jira] [Assigned] (KAFKA-780) Reassign partitions tool produces NPE in shutdown handler

2013-03-04 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike reassigned KAFKA-780: --- Assignee: Sriram Subramanian > Reassign partitions tool produces NPE in shutdown handler >

[jira] [Assigned] (KAFKA-785) jsonFileOpt in PreferredReplicaLeaderElectionTool should not be "required"

2013-03-04 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike reassigned KAFKA-785: --- Assignee: Swapnil Ghike (was: Sriram Subramanian) > jsonFileOpt in PreferredReplicaLeader

[jira] [Updated] (KAFKA-785) Resolve bugs in PreferredReplicaLeaderElection admin tool

2013-03-04 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-785: Summary: Resolve bugs in PreferredReplicaLeaderElection admin tool (was: jsonFileOpt in PreferredRe

[jira] [Assigned] (KAFKA-785) Resolve bugs in PreferredReplicaLeaderElection admin tool

2013-03-04 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike reassigned KAFKA-785: --- Assignee: Sriram Subramanian (was: Swapnil Ghike) > Resolve bugs in PreferredReplicaLeade

[jira] [Updated] (KAFKA-785) Resolve bugs in PreferredReplicaLeaderElection admin tool

2013-03-04 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-785: Description: 1. Since we run the preferred replica election on all partitions if the jsonFile is em

[jira] [Updated] (KAFKA-780) Reassign partitions tool produces NPE in shutdown handler

2013-03-04 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-780: Issue Type: Sub-task (was: Bug) Parent: KAFKA-785 > Reassign partitions tool produces N

[jira] [Commented] (KAFKA-785) Resolve bugs in PreferredReplicaLeaderElection admin tool

2013-03-04 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13592837#comment-13592837 ] Swapnil Ghike commented on KAFKA-785: - Can we use val jsonString = if (options.has(json

[jira] [Commented] (KAFKA-785) Resolve bugs in PreferredReplicaLeaderElection admin tool

2013-03-04 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13592844#comment-13592844 ] Swapnil Ghike commented on KAFKA-785: - Well, you avoid a small jump in logic (jsonFile

<    1   2   3   4   5