[
https://issues.apache.org/jira/browse/KAFKA-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13587737#comment-13587737
]
Swapnil Ghike commented on KAFKA-774:
-------------------------------------
I doubt if the v2 patch will do what it intends to. In the big try catch block
that you idented, we catch all exceptions and throw LeaderNotAvailableException
and ReplicaNotAvailableException, which is what is caught by the last catch
block.
Apart from that, it was unnecessary to have two separate cases in the last
catch block, we can consolidate them into one.
> Periodic refresh of topic metadata on the producer does not check for error
> code in the response
> ------------------------------------------------------------------------------------------------
>
> Key: KAFKA-774
> URL: https://issues.apache.org/jira/browse/KAFKA-774
> Project: Kafka
> Issue Type: Bug
> Components: producer
> Affects Versions: 0.8
> Reporter: Neha Narkhede
> Assignee: Neha Narkhede
> Priority: Blocker
> Labels: p1
> Attachments: kafka-774.patch, kafka-774-v2.patch
>
>
> The producer does a periodic refresh of the metadata but marks the attempt as
> successful based only on whether the response was received or not. It does
> not check for error codes in the response. This is probably ok since those
> produce requests will fail and the required topics will enter the list for
> topic metadata refresh in the next attempt. However, it will be good to log
> this since it looks like the metadata was refreshed but actually there could
> be failures.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
