[jira] [Created] (KAFKA-786) Use "withRequiredArg" while parsing jopt options in all tools

2013-03-04 Thread Swapnil Ghike (JIRA)
Swapnil Ghike created KAFKA-786: --- Summary: Use "withRequiredArg" while parsing jopt options in all tools Key: KAFKA-786 URL: https://issues.apache.org/jira/browse/KAFKA-786 Project: Kafka Issu

[jira] [Commented] (KAFKA-786) Use "withRequiredArg" while parsing jopt options in all tools

2013-03-04 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13592863#comment-13592863 ] Swapnil Ghike commented on KAFKA-786: - Also note that withRequiredArg() does not check

[jira] [Comment Edited] (KAFKA-786) Use "withRequiredArg" while parsing jopt options in all tools

2013-03-04 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13592863#comment-13592863 ] Swapnil Ghike edited comment on KAFKA-786 at 3/5/13 12:46 AM: --

[jira] [Assigned] (KAFKA-785) Resolve bugs in PreferredReplicaLeaderElection admin tool

2013-03-04 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike reassigned KAFKA-785: --- Assignee: Swapnil Ghike (was: Sriram Subramanian) > Resolve bugs in PreferredReplicaLeade

[jira] [Assigned] (KAFKA-785) Resolve bugs in PreferredReplicaLeaderElection admin tool

2013-03-04 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike reassigned KAFKA-785: --- Assignee: Sriram Subramanian (was: Swapnil Ghike) > Resolve bugs in PreferredReplicaLeade

[jira] [Updated] (KAFKA-786) Use "withRequiredArg" while parsing jopt options in all tools

2013-03-04 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-786: Attachment: kafka-786.patch Attached a patch. > Use "withRequiredArg" while parsing

[jira] [Assigned] (KAFKA-786) Use "withRequiredArg" while parsing jopt options in all tools

2013-03-04 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike reassigned KAFKA-786: --- Assignee: Swapnil Ghike > Use "withRequiredArg" while parsing jopt options in all tools >

[jira] [Updated] (KAFKA-786) Use "withRequiredArg" while parsing jopt options in all tools

2013-03-05 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-786: Attachment: kafka-786-v2.patch Jun raised a good question: What do we do for options like "print" or

[jira] [Updated] (KAFKA-513) Add state change log to Kafka brokers

2013-03-05 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-513: Attachment: kafka-513-v5.patch Thank you for the detailed suggestions, they were incredibly helpful.

[jira] [Updated] (KAFKA-513) Add state change log to Kafka brokers

2013-03-06 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-513: Attachment: kafka-513-v5-corrected.patch Does it work now? > Add state change log t

[jira] [Commented] (KAFKA-513) Add state change log to Kafka brokers

2013-03-06 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13595025#comment-13595025 ] Swapnil Ghike commented on KAFKA-513: - Thanks for making the corrections Neha. Jun: Pe

[jira] [Updated] (KAFKA-779) Standardize Zk data structures for Re-assign partitions and Preferred replication election

2013-03-06 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-779: Attachment: kafka-779-v3.patch Patch v3: 1. Ok, not asking the user to provide version in both the

[jira] [Created] (KAFKA-793) Include controllerId in all requests sent by controller

2013-03-06 Thread Swapnil Ghike (JIRA)
Swapnil Ghike created KAFKA-793: --- Summary: Include controllerId in all requests sent by controller Key: KAFKA-793 URL: https://issues.apache.org/jira/browse/KAFKA-793 Project: Kafka Issue Type:

[jira] [Updated] (KAFKA-793) Include controllerId in all requests sent by controller

2013-03-06 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-793: Labels: kafka-0.8 p1 (was: ) > Include controllerId in all requests sent by controller > --

[jira] [Commented] (KAFKA-794) Clean up controller logging

2013-03-07 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13596142#comment-13596142 ] Swapnil Ghike commented on KAFKA-794: - This should wait till KAFKA-793 is checked in.

[jira] [Assigned] (KAFKA-793) Include controllerId in all requests sent by controller

2013-03-07 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike reassigned KAFKA-793: --- Assignee: Swapnil Ghike > Include controllerId in all requests sent by controller > --

[jira] [Updated] (KAFKA-793) Include controllerId in all requests sent by controller

2013-03-07 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-793: Attachment: kafka-793-v1.patch Patch v1. Created a val for "state.change.logger" in KafkaController

[jira] [Created] (KAFKA-795) Improvements to PreferredReplicaLeaderElection tool

2013-03-07 Thread Swapnil Ghike (JIRA)
Swapnil Ghike created KAFKA-795: --- Summary: Improvements to PreferredReplicaLeaderElection tool Key: KAFKA-795 URL: https://issues.apache.org/jira/browse/KAFKA-795 Project: Kafka Issue Type: Bug

[jira] [Created] (KAFKA-798) Use biased histograms instead of uniform histograms in KafkaMetricsGroup

2013-03-08 Thread Swapnil Ghike (JIRA)
Swapnil Ghike created KAFKA-798: --- Summary: Use biased histograms instead of uniform histograms in KafkaMetricsGroup Key: KAFKA-798 URL: https://issues.apache.org/jira/browse/KAFKA-798 Project: Kafka

[jira] [Updated] (KAFKA-798) Use biased histograms instead of uniform histograms in KafkaMetricsGroup

2013-03-08 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-798: Attachment: kafka-798.patch One word fix. > Use biased histograms instead of unifor

[jira] [Commented] (KAFKA-797) Cannot start Kafka 0.8 per Quick Start instructions

2013-03-08 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13597831#comment-13597831 ] Swapnil Ghike commented on KAFKA-797: - Bob, are you using 0.8 HEAD? We did a bunch of c

[jira] [Commented] (KAFKA-779) Standardize Zk data structures for Re-assign partitions and Preferred replication election

2013-03-09 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13597913#comment-13597913 ] Swapnil Ghike commented on KAFKA-779: - Jay had a great suggestion about combining Json

[jira] [Commented] (KAFKA-797) Cannot start Kafka 0.8 per Quick Start instructions

2013-03-09 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13598074#comment-13598074 ] Swapnil Ghike commented on KAFKA-797: - Bob, yes, if you cloned the repo two days ago, t

[jira] [Commented] (KAFKA-799) Infinite loop trying to start a broker

2013-03-09 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13598169#comment-13598169 ] Swapnil Ghike commented on KAFKA-799: - Hmm, I tried booting up zookeeper and a kafka br

[jira] [Commented] (KAFKA-799) Infinite loop trying to start a broker

2013-03-09 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13598178#comment-13598178 ] Swapnil Ghike commented on KAFKA-799: - Yes, booting up a kafka 0.8 server after having

[jira] [Updated] (KAFKA-799) Infinite loop trying to start a broker

2013-03-09 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-799: Resolution: Not A Problem Assignee: Swapnil Ghike (was: Neha Narkhede) Status: Resolve

[jira] [Commented] (KAFKA-798) Use biased histograms instead of uniform histograms in KafkaMetricsGroup

2013-03-11 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599068#comment-13599068 ] Swapnil Ghike commented on KAFKA-798: - Yes, timer includes a biased histogram by defaul

[jira] [Commented] (KAFKA-686) 0.8 Kafka broker should give a better error message when running against 0.7 zookeeper

2013-03-11 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599208#comment-13599208 ] Swapnil Ghike commented on KAFKA-686: - How do we differentiate whether the 0.8 broker i

[jira] [Updated] (KAFKA-763) Add an option to replica from the largest offset during unclean leader election

2013-03-11 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-763: Attachment: kafka-763-new-v1.patch Copy pasting the comments from patch new-v1: 1. The leader's log

[jira] [Updated] (KAFKA-763) Add an option to replica from the largest offset during unclean leader election

2013-03-11 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-763: Status: Patch Available (was: Open) > Add an option to replica from the largest offset during u

[jira] [Updated] (KAFKA-763) Add an option to replica from the largest offset during unclean leader election

2013-03-12 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-763: Attachment: kafka-763-new-v2.patch 1. Moved earliestOrLatestOffset to SimpleConsumer class. Checking

[jira] [Updated] (KAFKA-763) Add an option to replica from the largest offset during unclean leader election

2013-03-13 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-763: Attachment: kafka-763-new-v3.patch Since patch new-v2 has been committed, this patch contains diff o

[jira] [Updated] (KAFKA-763) Add an option to replica from the largest offset during unclean leader election

2013-03-13 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-763: Attachment: kafka-763-new-v4.patch Modified ConsumerFetcherThread to use SimpleConsumer.earliestOrLa

[jira] [Created] (KAFKA-811) Fix clientId in migration tool

2013-03-18 Thread Swapnil Ghike (JIRA)
Swapnil Ghike created KAFKA-811: --- Summary: Fix clientId in migration tool Key: KAFKA-811 URL: https://issues.apache.org/jira/browse/KAFKA-811 Project: Kafka Issue Type: Bug Affects Versions

[jira] [Updated] (KAFKA-811) Fix clientId in migration tool

2013-03-18 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-811: Attachment: kafka-811.patch > Fix clientId in migration tool > -- >

[jira] [Updated] (KAFKA-811) Fix clientId in migration tool

2013-03-18 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-811: Status: Patch Available (was: Open) > Fix clientId in migration tool >

[jira] [Created] (KAFKA-813) Minor cleanup in Controller

2013-03-18 Thread Swapnil Ghike (JIRA)
Swapnil Ghike created KAFKA-813: --- Summary: Minor cleanup in Controller Key: KAFKA-813 URL: https://issues.apache.org/jira/browse/KAFKA-813 Project: Kafka Issue Type: Bug Affects Versions: 0

[jira] [Updated] (KAFKA-813) Minor cleanup in Controller

2013-03-18 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-813: Description: Before starting work on delete topic support, uploading a patch first to address some

[jira] [Updated] (KAFKA-813) Minor cleanup in Controller

2013-03-18 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-813: Attachment: kafka-813-v1.patch Unit tests pass. > Minor cleanup in Controller > ---

[jira] [Commented] (KAFKA-813) Minor cleanup in Controller

2013-03-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606672#comment-13606672 ] Swapnil Ghike commented on KAFKA-813: - @Neha: 2. If the target state is not OfflinePart

[jira] [Updated] (KAFKA-811) Fix clientId in migration tool

2013-03-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-811: Attachment: kafka-811-v2.patch Can we check in this patch ? The 1st one had a real stupid mistake.

[jira] [Comment Edited] (KAFKA-813) Minor cleanup in Controller

2013-03-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606672#comment-13606672 ] Swapnil Ghike edited comment on KAFKA-813 at 3/19/13 7:06 PM: --

[jira] [Commented] (KAFKA-811) Fix clientId in migration tool

2013-03-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606683#comment-13606683 ] Swapnil Ghike commented on KAFKA-811: - The 1st patch will pass client ids like abc-0, a

[jira] [Updated] (KAFKA-813) Minor cleanup in Controller

2013-03-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-813: Attachment: kafka-813-v2.patch Addressing comments: [~junrao]: 1. Renamed the exception to Partiti

[jira] [Updated] (KAFKA-813) Minor cleanup in Controller

2013-03-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-813: Priority: Blocker (was: Major) > Minor cleanup in Controller > --- > >

[jira] [Updated] (KAFKA-813) Minor cleanup in Controller

2013-03-19 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-813: Labels: kafka-0.8 (was: ) > Minor cleanup in Controller > --- > >

[jira] [Commented] (KAFKA-813) Minor cleanup in Controller

2013-03-20 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13608130#comment-13608130 ] Swapnil Ghike commented on KAFKA-813: - A couple of comments/questions before uploading

[jira] [Updated] (KAFKA-813) Minor cleanup in Controller

2013-03-20 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-813: Attachment: kafka-813-v3.patch Patch v3 takes care of the comments made above. > Mi

[jira] [Comment Edited] (KAFKA-330) Add delete topic support

2013-03-20 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13608564#comment-13608564 ] Swapnil Ghike edited comment on KAFKA-330 at 3/21/13 2:47 AM: --

[jira] [Commented] (KAFKA-330) Add delete topic support

2013-03-20 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13608564#comment-13608564 ] Swapnil Ghike commented on KAFKA-330: - Delete topic admin patch schema updated at http

[jira] [Created] (KAFKA-822) Reassignment of partitions needs a cleanup

2013-03-21 Thread Swapnil Ghike (JIRA)
Swapnil Ghike created KAFKA-822: --- Summary: Reassignment of partitions needs a cleanup Key: KAFKA-822 URL: https://issues.apache.org/jira/browse/KAFKA-822 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-821) specifying a non-existent partition to ./bin/kafka-reassign-partitions.sh breaks all reassignment ops

2013-03-21 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13609713#comment-13609713 ] Swapnil Ghike commented on KAFKA-821: - We can make this a sub-task of KAFKA-822 if this

[jira] [Updated] (KAFKA-822) Reassignment of partitions needs a cleanup

2013-03-21 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-822: Description: 1. This is probably a left-over from when the ReassignPartitionsCommand used to be blo

[jira] [Updated] (KAFKA-822) Reassignment of partitions needs a cleanup

2013-03-21 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-822: Assignee: Swapnil Ghike (was: Neha Narkhede) > Reassignment of partitions needs a cleanup > ---

[jira] [Commented] (KAFKA-813) Minor cleanup in Controller

2013-03-22 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13610100#comment-13610100 ] Swapnil Ghike commented on KAFKA-813: - 30. port has been included to maintain consisten

[jira] [Updated] (KAFKA-813) Minor cleanup in Controller

2013-03-23 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-813: Attachment: kafka-813-v4.patch Thanks for pointing that out. Attached patch v4. When the leader goes

[jira] [Commented] (KAFKA-822) Reassignment of partitions needs a cleanup

2013-03-24 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13612355#comment-13612355 ] Swapnil Ghike commented on KAFKA-822: - Listing additional changes: 6. On the creation

[jira] [Created] (KAFKA-828) Preferred Replica Election does not delete the admin on controller failover

2013-03-26 Thread Swapnil Ghike (JIRA)
Swapnil Ghike created KAFKA-828: --- Summary: Preferred Replica Election does not delete the admin on controller failover Key: KAFKA-828 URL: https://issues.apache.org/jira/browse/KAFKA-828 Project: Kafka

[jira] [Updated] (KAFKA-828) Preferred Replica Election does not delete the admin path on controller failover

2013-03-26 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-828: Summary: Preferred Replica Election does not delete the admin path on controller failover (was: Pre

[jira] [Updated] (KAFKA-828) Preferred Replica Election does not delete the admin path on controller failover

2013-03-26 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-828: Attachment: kafka-828-v1.patch 1. Moving removePartitionsFromPreferredReplicaElection() to onPrefer

[jira] [Updated] (KAFKA-814) Controller should not throw exception when a preferred replica is already the leader for a partition

2013-03-26 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-814: Issue Type: Sub-task (was: Bug) Parent: KAFKA-828 > Controller should not throw excepti

[jira] [Updated] (KAFKA-828) Preferred Replica Election does not delete the admin path on controller failover

2013-03-26 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-828: Attachment: kafka-828-v2.patch Converted KAFKA-814 to subtask of this as Sriram asked to. Added a on

[jira] [Updated] (KAFKA-828) Preferred Replica Election does not delete the admin path on controller failover

2013-03-26 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-828: Attachment: kafka-828-v3.patch Actually since preferred replica election is not a heavy weight opera

[jira] [Commented] (KAFKA-830) partition replica assignment map in the controller should be a Set

2013-03-27 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13615645#comment-13615645 ] Swapnil Ghike commented on KAFKA-830: - collection.mutable.LinkedHashSet will iterate th

[jira] [Updated] (KAFKA-828) Preferred Replica Election does not delete the admin path on controller failover

2013-03-27 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-828: Attachment: kafka-828-v4.patch Agree with all comments, uploading patch v4. Defined a new LeaderEl

[jira] [Created] (KAFKA-840) Controller tries to perform preferred replica election on failover before state machines have started up

2013-03-28 Thread Swapnil Ghike (JIRA)
Swapnil Ghike created KAFKA-840: --- Summary: Controller tries to perform preferred replica election on failover before state machines have started up Key: KAFKA-840 URL: https://issues.apache.org/jira/browse/KAFKA-840

[jira] [Updated] (KAFKA-840) Controller tries to perform preferred replica election on failover before state machines have started up

2013-03-28 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-840: Attachment: kafka-840.patch I think the right solution is to move initializeAndMaybeTriggerPartit

[jira] [Commented] (KAFKA-831) Controller does not send the complete list of partitions to a newly started broker

2013-03-28 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13616827#comment-13616827 ] Swapnil Ghike commented on KAFKA-831: - This patch may not fix the issue. In the Offline

[jira] [Commented] (KAFKA-831) Controller does not send the complete list of partitions to a newly started broker

2013-03-28 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13616843#comment-13616843 ] Swapnil Ghike commented on KAFKA-831: - One way to avoid it could be that in the Online/

[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x

2013-03-29 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13617646#comment-13617646 ] Swapnil Ghike commented on KAFKA-826: - [~dragosm]: Could you upload a patch using the a

[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x

2013-03-29 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13617818#comment-13617818 ] Swapnil Ghike commented on KAFKA-826: - Hi Dragos, I am still not able to cleanly apply

[jira] [Updated] (KAFKA-784) creating topic without partitions, deleting then creating with partition causes errors in 'kafka-list-topic'

2013-03-29 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-784: Issue Type: Sub-task (was: Bug) Parent: KAFKA-330 > creating topic without partitions,

[jira] [Assigned] (KAFKA-784) creating topic without partitions, deleting then creating with partition causes errors in 'kafka-list-topic'

2013-03-29 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike reassigned KAFKA-784: --- Assignee: Swapnil Ghike > creating topic without partitions, deleting then creating with p

[jira] [Commented] (KAFKA-840) Controller tries to perform preferred replica election on failover before state machines have started up

2013-03-29 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13617919#comment-13617919 ] Swapnil Ghike commented on KAFKA-840: - 1. Renamed inShuttingdown in partition/replica s

[jira] [Updated] (KAFKA-840) Controller tries to perform preferred replica election on failover before state machines have started up

2013-03-29 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-840: Attachment: kafka-840-v2.patch > Controller tries to perform preferred replica election on failo

[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x

2013-04-01 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619153#comment-13619153 ] Swapnil Ghike commented on KAFKA-826: - Hi Dragos, sorry for bugging you again. I think

[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x

2013-04-01 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619172#comment-13619172 ] Swapnil Ghike commented on KAFKA-826: - The take2 patch applies quite smoothly! Thanks a

[jira] [Updated] (KAFKA-840) Controller tries to perform preferred replica election on failover before state machines have started up

2013-04-01 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-840: Attachment: kafka-840-after-commit-v1.patch I made a mistake. Patch v2 ignores a broker/topic change

[jira] [Commented] (KAFKA-840) Controller tries to perform preferred replica election on failover before state machines have started up

2013-04-02 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620165#comment-13620165 ] Swapnil Ghike commented on KAFKA-840: - Makes sense. Should we also de-register the topi

[jira] [Updated] (KAFKA-840) Controller tries to perform preferred replica election on failover before state machines have started up

2013-04-02 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-840: Attachment: kafka-840-after-commit-v2.patch Cool, attached a new patch 'after-commit-v2'.

[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x

2013-04-02 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620428#comment-13620428 ] Swapnil Ghike commented on KAFKA-826: - Dragos, thanks for the input. We can definitely

[jira] [Updated] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x

2013-04-02 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-826: Assignee: Dragos Manolescu (was: Jun Rao) > Make Kafka 0.8 depend on metrics 2.2.0 instead of 3

[jira] [Commented] (KAFKA-330) Add delete topic support

2013-04-03 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620816#comment-13620816 ] Swapnil Ghike commented on KAFKA-330: - Patch v1 attached. How topics are deleted: 1.

[jira] [Updated] (KAFKA-330) Add delete topic support

2013-04-03 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-330: Attachment: kafka-330-v1.patch > Add delete topic support > - > >

[jira] [Updated] (KAFKA-330) Add delete topic support

2013-04-03 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-330: Fix Version/s: 0.8 Status: Patch Available (was: Open) > Add delete topic support >

[jira] [Commented] (KAFKA-330) Add delete topic support

2013-04-03 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620856#comment-13620856 ] Swapnil Ghike commented on KAFKA-330: - Actually scratch 5 in "How topics are deleted".

[jira] [Commented] (KAFKA-330) Add delete topic support

2013-04-03 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621397#comment-13621397 ] Swapnil Ghike commented on KAFKA-330: - Replying to a few comments, will follow up with

[jira] [Commented] (KAFKA-330) Add delete topic support

2013-04-03 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621847#comment-13621847 ] Swapnil Ghike commented on KAFKA-330: - Thanks for the excellent explanation. Some of th

[jira] [Commented] (KAFKA-840) Controller tries to perform preferred replica election on failover before state machines have started up

2013-04-03 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621849#comment-13621849 ] Swapnil Ghike commented on KAFKA-840: - Did we check in the 'after-commit-v2' patch? Tha

[jira] [Updated] (KAFKA-330) Add delete topic support

2013-04-04 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-330: Attachment: kafka-330-v2.patch Yes, I agree with you Jun. Attaching a temporary patch v2 for the rec

[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x

2013-04-04 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13622833#comment-13622833 ] Swapnil Ghike commented on KAFKA-826: - Dragos, it seems like we are headed towards agre

[jira] [Commented] (KAFKA-849) Bug in controller's startup/failover logic fails to update in memory leader and isr cache causing other state changes to work incorrectly

2013-04-04 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13623240#comment-13623240 ] Swapnil Ghike commented on KAFKA-849: - +1 Both were great catches! > B

[jira] [Commented] (KAFKA-851) Broken handling of leader and isr request leads to incorrect high watermark checkpoint file

2013-04-04 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13623253#comment-13623253 ] Swapnil Ghike commented on KAFKA-851: - +1 Great catch! > Broken handli

[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x

2013-04-08 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625222#comment-13625222 ] Swapnil Ghike commented on KAFKA-826: - Thanks, the unit tests were ok. But while trying

[jira] [Comment Edited] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x

2013-04-08 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625222#comment-13625222 ] Swapnil Ghike edited comment on KAFKA-826 at 4/8/13 8:04 AM: - T

[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x

2013-04-09 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13626374#comment-13626374 ] Swapnil Ghike commented on KAFKA-826: - Thanks Matt for verifying! This patch works well

[jira] [Commented] (KAFKA-649) Cleanup log4j logging

2013-04-10 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628447#comment-13628447 ] Swapnil Ghike commented on KAFKA-649: - In DefaultEventhandler, we have a few warn("Fail

[jira] [Created] (KAFKA-871) Rename ZkConfig properties

2013-04-22 Thread Swapnil Ghike (JIRA)
Swapnil Ghike created KAFKA-871: --- Summary: Rename ZkConfig properties Key: KAFKA-871 URL: https://issues.apache.org/jira/browse/KAFKA-871 Project: Kafka Issue Type: Bug Reporter: Sw

[jira] [Updated] (KAFKA-871) Rename ZkConfig properties

2013-04-22 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil Ghike updated KAFKA-871: Attachment: kafka-871-v1.patch Unit tests pass. > Rename ZkConfig properties >

[jira] [Commented] (KAFKA-871) Rename ZkConfig properties

2013-04-22 Thread Swapnil Ghike (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13638696#comment-13638696 ] Swapnil Ghike commented on KAFKA-871: - [~jfung]: Could you take a look at this patch? S

  1   2   3   4   5   >