[DISCUSS] KIP-1045 Decide MockAdminClient to move to public api or not

2024-05-16 Thread Muralidhar Basani
t depend on Admin. (Mentioned by Mickael Maison in KAFKA-15258 <https://issues.apache.org/jira/browse/KAFKA-15258>) Thanks, Murali Muralidhar Basani Staff Software Engineer, Aiven muralidhar.bas...@aiven.io

Re: [DISCUSS] KIP-1042 support for wildcard when creating new acls

2024-05-17 Thread Muralidhar Basani
Updated KIP with the provided suggestions from Greg and Claude. We shall optimize matching acls with Trie based solutions for PREFIXED and LITERAL acls. Basically we define trie structures, populate trie and retrieve acls which seems very efficient. This way, we aim to reduce the time to authorize

Re: [DISCUSS] KIP-1045 Decide MockAdminClient to move to public api or not

2024-05-20 Thread Muralidhar Basani
beneficial. MockProducer and MockConsumer are part of the public api already. Thanks, Murali On Thu, May 16, 2024 at 11:10 AM Muralidhar Basani < muralidhar.bas...@aiven.io> wrote: > Hello, > > As part of this KIP, I would like to take your opinions in > moving MockAdminClient to the

Re: [DISCUSS] KIP-1042 support for wildcard when creating new acls

2024-05-21 Thread Muralidhar Basani
@greg which library of trie you were thinking of ? There is one in the commons-collection I see. On Fri, May 17, 2024 at 3:55 PM Claude Warren wrote: > > > > This has implications for execution complexity: If we can't compute > > whether two patterns overlap, then we need to run both of them on

Re: [DISCUSS] KIP-1042 support for wildcard when creating new acls

2024-05-23 Thread Muralidhar Basani
fcf0b8f78574f2f73/metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizerData.java#L319-L339 > [2] > https://github.com/apache/kafka/blob/9fe3932e5c110443f7fa545fcf0b8f78574f2f73/server-common/src/main/java/org/apache/kafka/server/immutable/pcollections/PCollectionsImmuta

Re: [DISCUSS] KIP-1042 support for wildcard when creating new acls

2024-05-28 Thread Muralidhar Basani
Hi all, Any other suggestions or objections to the proposal? Thanks, Murali On Thu, May 23, 2024 at 10:18 AM Muralidhar Basani < muralidhar.bas...@aiven.io> wrote: > Thanks Greg. > I have updated KIP with details on optimisation of LITERAL too. > > Regarding limitations

Re: [DISCUSS] KIP-1042 support for wildcard when creating new acls

2024-06-03 Thread Muralidhar Basani
Hi, Just bumping this thread again. It seems no concerns have been raised so far. I'll request votes in 2 weeks. Thanks, Murali On Tue, May 28, 2024 at 1:24 PM Muralidhar Basani < muralidhar.bas...@aiven.io> wrote: > Hi all, > > Any other suggestions or objections to the

Re: [DISCUSS] KIP-1045 Decide MockAdminClient to move to public api or not

2024-06-06 Thread Muralidhar Basani
er and MockConsumer. Thanks, Murali On Mon, May 20, 2024 at 10:51 PM Muralidhar Basani < muralidhar.bas...@aiven.io> wrote: > Hi all, > > Any thoughts on this ? In my view, it helps developers in having an end to > end testing framework embedded into their applications, right from mock

Re: [DISCUSS] KIP-1045 Decide MockAdminClient to move to public api or not

2024-06-06 Thread Muralidhar Basani
oving MockConsumer and MockProducer to the > test src folder . > > Muralidhar Basani 于2024年6月6日周四 > 17:23写道: > > > Hi, > > I have updated this KIP > > < > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1045%3A+Move+MockAdminClient+to+pub

[DISCUSS] KIP-1056: Remove `default.` prefix for exception handler StreamsConfig

2024-06-09 Thread Muralidhar Basani
Hello all, With this KIP , I would like to mention that a couple of exception handler configs in StreamsConfig are defined as default configs, despite having no alternati

Re: [DISCUSS] KIP-1056: Remove `default.` prefix for exception handler StreamsConfig

2024-06-13 Thread Muralidhar Basani
which ones are newly added. > >> > >> > >> 101: Nit. In "Propose Changes" there is the template placeholder text > >> > >>> Describe the new thing you want to do in appropriate detail. This may > be > >> fairly extensive and ha

Re: [DISCUSS] KIP-1056: Remove `default.` prefix for exception handler StreamsConfig

2024-06-14 Thread Muralidhar Basani
serializer can catch and handle an exception without the > > configured default.deserialization.exception.handler being invoked. > > > > I think this would better align these with JVM norms, e.g. > > Thread#setUncaughtExceptionHandler, which behaves the same (albeit > &g

[VOTE] KIP-1042: Support for wildcard when creating new acls

2024-06-17 Thread Muralidhar Basani
Hi all, I would like to call a vote on KIP-1042 which extends creation of acls with MATCH pattern type. KIP - https://cwiki.apache.org/confluence/display/KAFKA/KIP-1042%3A+Support+for+wildcard+when+creating+new+acls Discussion thread - https://lists.apache.org/thread/xx3lcg60kp4v34x0j9p6xobby8l4

[VOTE] KIP-1056 - Deprecate `default.` prefix for exception handler in StreamsConfig

2024-06-19 Thread Muralidhar Basani
Hi all, I would like to call a vote on KIP-1056 - Deprecate `default.` exception handler configs in StreamsConfig. KIP - https://cwiki.apache.org/confluence/display/KAFKA/KIP-1056%3A+Remove+%60default.%60+prefix+for+exception+handler+StreamsConfig Discussion thread - https://lists.apache.org/thr

Re: [VOTE] KIP-1042: Support for wildcard when creating new acls

2024-06-19 Thread Muralidhar Basani
of ACL matches, and adding > another "degree of freedom" seems likely to make things worse. > > It would be useful to understand how much faster or slower the code is > with the propsed changes, versus without them. > > best, > Colin > > > On Mon, Jun 17, 2024,

Re: [VOTE] KIP-1056 - Deprecate `default.` prefix for exception handler in StreamsConfig

2024-06-27 Thread Muralidhar Basani
lly > discarded. > > > -Matthias > > On 6/19/24 11:33 AM, Muralidhar Basani wrote: > > Hi all, > > > > I would like to call a vote on KIP-1056 - Deprecate `default.` exception > > handler configs in StreamsConfig. > > > > KIP - > > > https://cwiki.ap

[DISCUSS] - KIP-1064: Upgrade slf4j to 2.x

2024-07-01 Thread Muralidhar Basani
Hello, Regarding KIP-1064 [0], I would like to start a discussion on upgrading slf4j to 2.x, which is currently at 1.7.36, and with an option to provide slf4j provider in run class. This is also discussed in jira [1] and git pr [2], and thought we should have a kip. Please note this kip is inten

Re: [DISCUSS] KIP-1056: Remove `default.` prefix for exception handler StreamsConfig

2024-07-02 Thread Muralidhar Basani
ving a problem > >>> that doesn't exist and just being pedantic in a way that is going to > >> affect > >>> many users? > >>> > >>> I won't vote -1 on this and am happy to let it go through if others are > >>> strongly in favor

Re: [VOTE] KIP-1056 - Deprecate `default.` prefix for exception handler in StreamsConfig

2024-07-02 Thread Muralidhar Basani
that > >> -- if we hear from users who actively support this change and want it to > >> happen then I'll even cast a +1 binding vote to help it get passed. > >> > >> Best, > >> Sophie > >> > >> On Thu, Jun 27, 2024 at 2:04 PM Mural

Re: [DISCUSS] - KIP-1064: Upgrade slf4j to 2.x

2024-07-04 Thread Muralidhar Basani
luding > all binding jars in kafka is a solution, as we can take control over all > binding jars. WDYT? > > Best, > Chia-Ping > > Muralidhar Basani 於 2024年7月2日 週二 > 上午3:30寫道: > > > Hello, > > > > Regarding KIP-1064 [0], I would like to start a discussion

Re: [VOTE] 3.8.0 RC3

2024-07-24 Thread Muralidhar Basani
Hi Josep, Thanks for running the release! I am +1 (non binding) Downloaded from sources https://github.com/apache/kafka/archive/refs/tags/3.8.0-rc3.tar.gz and built with java 17. I performed the following validations: 1. I deleted a partition.metadata for a topic manually, and tried starting th

Re: [ANNOUNCE] New committer: Lianet Magrans

2024-08-28 Thread Muralidhar Basani
Congratulations Lianet !! Murali On Thu, 29 Aug 2024 at 05:48, Kamal Chandraprakash < kamal.chandraprak...@gmail.com> wrote: > Congrats Lianet! > > On Thu, Aug 29, 2024 at 8:07 AM Luke Chen wrote: > > > Congratulations Lianet! > > > > Luke > > > > On Thu, Aug 29, 2024 at 9:54 AM Lianet M. wrot

[VOTE] KIP-1064 - Upgrade slf4j to 2.x

2024-09-10 Thread Muralidhar Basani
Hi all, I would like to call a vote on KIP-1064 - Upgrade slf4j to 2.x Target version : 4.0.0 KIP - https://cwiki.apache.org/confluence/display/KAFKA/KIP-1064%3A+Upgrade+slf4j+to+2.x Discussion thread - https://lists.apache.org/thread/z05rlzbjv89rpvzjmzsr8v4w17qn21r1 Jira with some discussion

Re: [VOTE] KIP-1064 - Upgrade slf4j to 2.x

2024-09-11 Thread Muralidhar Basani
be equal to slf4j API [0]. Including > both in kafka distribution can avoid compatibility issue; > > [0] https://www.slf4j.org/manual.html#compatibility > > Muralidhar Basani 於 2024年9月11日 週三 > 上午4:02寫道: > > > Hi all, > > > > I would like to call a vote o

Re: [VOTE] KIP-1064 - Upgrade slf4j to 2.x

2024-09-15 Thread Muralidhar Basani
Hi Colin and Chia, thank you for your feedback. Currently we have only reload4j binding dependency, and we can continue with the same. I have updated kip with only reload4j, and removed all other providers. And if users have a different slf4j provider, they can continue to keep it in the classpath

Re: [VOTE] KIP-1064 - Upgrade slf4j to 2.x

2024-09-16 Thread Muralidhar Basani
Thanks Chia. I have updated KIP with this quote, in the migration plan section. Thanks, Murali On Sun, Sep 15, 2024 at 3:30 PM Chia-Ping Tsai wrote: > > > Muralidhar Basani 於 2024年9月15日 > 晚上9:02 寫道: > > > > With this, I think, users don't have to make any explici

Request for contribution to Kafka

2022-09-19 Thread Muralidhar Basani
Hi! I would like to start contributing to Apache Kafka, can you please add my Jira username to the contributors list? My username is: muralibasani Thanks a bunch in advance. Best Regards, Murali Basani

Re: [VOTE] KIP-1064 - Upgrade slf4j to 2.x

2024-09-23 Thread Muralidhar Basani
Hi, I wanted to gently follow up on this thread in case anyone has any thoughts or would like to take a look. Thanks, Murali On Mon, Sep 16, 2024 at 10:23 AM Muralidhar Basani < muralidhar.bas...@aiven.io> wrote: > Thanks Chia. > > I have updated KIP with this quote, in the

Re: [DISCUSS] - Kafka topic deletion improvement

2024-09-23 Thread Muralidhar Basani
Hi Jose, You're right, ACLs are typically created before topic creation to prevent authorization issues during deployment. However, when it comes to deleting a topic via CLI, it's really just two steps: running the topic deletion command and the ACL deletion command. I had considered combining th

Re: [DISCUSS] - Kafka topic deletion improvement

2024-09-19 Thread Muralidhar Basani
hat had been deleted/truncated, and observing negative > lag and non-delivery of the "rewritten" offsets. I wonder if we could > improve the referential integrity there too. > > > Thanks, > Greg > > On Thu, Sep 19, 2024, 10:27 AM Muralidhar Basani > wrote: > >

[DISCUSS] - Kafka topic deletion improvement

2024-09-19 Thread Muralidhar Basani
Hello everyone, I’d like to propose an improvement to the Kafka topic deletion process, specifically regarding ACLs. Currently, when we delete a topic using the kafka-topics.sh cli, the topic is removed without any consideration for the ACLs that were applied to it. This could lead to stale ACLs

[jira] [Created] (KAFKA-16880) Update equals and hashcode for two new *threadPool attributes

2024-06-03 Thread Muralidhar Basani (Jira)
Muralidhar Basani created KAFKA-16880: - Summary: Update equals and hashcode for two new *threadPool attributes Key: KAFKA-16880 URL: https://issues.apache.org/jira/browse/KAFKA-16880 Project

[jira] [Created] (KAFKA-16884) Refactor RemoteLogManagerConfig with a Builder

2024-06-03 Thread Muralidhar Basani (Jira)
Muralidhar Basani created KAFKA-16884: - Summary: Refactor RemoteLogManagerConfig with a Builder Key: KAFKA-16884 URL: https://issues.apache.org/jira/browse/KAFKA-16884 Project: Kafka