[jira] [Updated] (KAFKA-2026) Logging of unused options always shows null for the value and is misleading if the option is used by serializers

2015-06-13 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2026: --- Assignee: Manikumar Reddy (was: Ewen Cheslack-Postava) Status: Patch Available (was

[jira] [Commented] (KAFKA-2026) Logging of unused options always shows null for the value and is misleading if the option is used by serializers

2015-06-13 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584544#comment-14584544 ] Manikumar Reddy commented on KAFKA-2026: Created reviewboard h

[jira] [Updated] (KAFKA-2234) Partition reassignment of a nonexistent topic prevents future reassignments

2015-06-13 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2234: --- Assignee: Manikumar Reddy Status: Patch Available (was: Open) > Partition reassignm

[jira] [Commented] (KAFKA-2234) Partition reassignment of a nonexistent topic prevents future reassignments

2015-06-13 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584589#comment-14584589 ] Manikumar Reddy commented on KAFKA-2234: Created reviewboard h

Review Request 35424: Patch for KAFKA-2234

2015-06-13 Thread Manikumar Reddy O
912b718ec9ad58b1c2d42337ed85bbb1b88162d6 Diff: https://reviews.apache.org/r/35424/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Updated] (KAFKA-2234) Partition reassignment of a nonexistent topic prevents future reassignments

2015-06-13 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2234: --- Attachment: KAFKA-2234.patch > Partition reassignment of a nonexistent topic prevents fut

[jira] [Commented] (KAFKA-2218) reassignment tool needs to parse and validate the json

2015-06-13 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584945#comment-14584945 ] Manikumar Reddy commented on KAFKA-2218: [~charmalloc] I am not able to repro

[jira] [Commented] (KAFKA-2267) kafka-reassign-partitions.sh --generate doesn't work when reducing replication factor

2015-06-13 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14584951#comment-14584951 ] Manikumar Reddy commented on KAFKA-2267: AFAIK, kafka-reassign-partition

[jira] [Resolved] (KAFKA-2233) Log deletion is not removing log metrics

2015-06-14 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy resolved KAFKA-2233. Resolution: Duplicate Fix Version/s: 0.8.3 This got fixed in KAFKA-1866 >

[jira] [Resolved] (KAFKA-1083) Unregister JMX MBean when shutting down ConsumerConnector

2015-06-14 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy resolved KAFKA-1083. Resolution: Duplicate > Unregister JMX MBean when shutting down ConsumerConnec

[jira] [Updated] (KAFKA-2202) ConsumerPerformance reports a throughput much higher than the actual one

2015-06-14 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2202: --- Attachment: KAFKA-2202.patch > ConsumerPerformance reports a throughput much higher than

Review Request 35437: Patch for KAFKA-2202

2015-06-14 Thread Manikumar Reddy O
903318d15893af08104a97499798c9ad0ba98013 Diff: https://reviews.apache.org/r/35437/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Commented] (KAFKA-2202) ConsumerPerformance reports a throughput much higher than the actual one

2015-06-14 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14585040#comment-14585040 ] Manikumar Reddy commented on KAFKA-2202: Created reviewboard h

[jira] [Updated] (KAFKA-2202) ConsumerPerformance reports a throughput much higher than the actual one

2015-06-14 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2202: --- Assignee: Manikumar Reddy Status: Patch Available (was: Open) > ConsumerPerforma

[jira] [Commented] (KAFKA-1828) [ConsumerPerformance] the test result is negative number

2015-06-14 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14585041#comment-14585041 ] Manikumar Reddy commented on KAFKA-1828: Submitted a simple patch for KAFKA-

[jira] [Resolved] (KAFKA-2250) ConcurrentModificationException in metrics reporting

2015-06-14 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy resolved KAFKA-2250. Resolution: Fixed Fix Version/s: 0.8.3 code related to this issue is removed as part

[jira] [Commented] (KAFKA-2252) Socket connection closing is logged, but not corresponding opening of socket

2015-06-15 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14585519#comment-14585519 ] Manikumar Reddy commented on KAFKA-2252: Some of these logs are removed/modi

[jira] [Resolved] (KAFKA-2251) "Connection reset by peer" IOExceptions should not be logged as ERROR

2015-06-15 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy resolved KAFKA-2251. Resolution: Fixed Fix Version/s: 0.8.3 This got fixed in KAFKA-1928. Log level

Review Request 35454: Patch for KAFKA-2159

2015-06-15 Thread Manikumar Reddy O
2d75186a110075e0c322db4b9f7a8c964a7a3e88 core/src/main/scala/kafka/server/KafkaServer.scala b320ce9f6a12c0ee392e91beb82e8804d167f9f4 Diff: https://reviews.apache.org/r/35454/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Updated] (KAFKA-2159) offsets.topic.segment.bytes and offsets.topic.retention.minutes are ignored

2015-06-15 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2159: --- Attachment: KAFKA-2159.patch > offsets.topic.segment.bytes

[jira] [Updated] (KAFKA-2159) offsets.topic.segment.bytes and offsets.topic.retention.minutes are ignored

2015-06-15 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2159: --- Assignee: Manikumar Reddy Status: Patch Available (was: Open

[jira] [Commented] (KAFKA-2159) offsets.topic.segment.bytes and offsets.topic.retention.minutes are ignored

2015-06-15 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14585800#comment-14585800 ] Manikumar Reddy commented on KAFKA-2159: Created reviewboard h

[jira] [Commented] (KAFKA-2159) offsets.topic.segment.bytes and offsets.topic.retention.minutes are ignored

2015-06-15 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14585806#comment-14585806 ] Manikumar Reddy commented on KAFKA-2159: [~jjkoshy] Curre

[jira] [Updated] (KAFKA-2012) Broker should automatically handle corrupt index files

2015-06-16 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2012: --- Attachment: KAFKA-2012.patch > Broker should automatically handle corrupt index fi

Review Request 35503: Patch for KAFKA-2012

2015-06-16 Thread Manikumar Reddy O
8e095d652851f05365e1d3bbe3e9e1c3345b7a40 Diff: https://reviews.apache.org/r/35503/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Commented] (KAFKA-2012) Broker should automatically handle corrupt index files

2015-06-16 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1458#comment-1458 ] Manikumar Reddy commented on KAFKA-2012: Created reviewboard h

[jira] [Updated] (KAFKA-2012) Broker should automatically handle corrupt index files

2015-06-16 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2012: --- Assignee: Manikumar Reddy Status: Patch Available (was: Open) > Broker sho

Re: Review Request 35454: Patch for KAFKA-2159

2015-06-16 Thread Manikumar Reddy O
scala b320ce9f6a12c0ee392e91beb82e8804d167f9f4 core/src/main/scala/kafka/server/OffsetManager.scala 5cca85cf727975f6d3acb2223fd186753ad761dc Diff: https://reviews.apache.org/r/35454/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Commented] (KAFKA-2159) offsets.topic.segment.bytes and offsets.topic.retention.minutes are ignored

2015-06-16 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14589362#comment-14589362 ] Manikumar Reddy commented on KAFKA-2159: Updated reviewboard h

[jira] [Updated] (KAFKA-2159) offsets.topic.segment.bytes and offsets.topic.retention.minutes are ignored

2015-06-16 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2159: --- Attachment: KAFKA-2159_2015-06-17_11:44:03.patch > offsets.topic.segment.bytes

Re: Review Request 34805: Patch for KAFKA-2213

2015-06-17 Thread Manikumar Reddy O
sage with offset 15. Can you explain how can we can achive this with relative start offset? - Manikumar Reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34805/#review88148 ---

Re: Review Request 34805: Patch for KAFKA-2213

2015-06-17 Thread Manikumar Reddy O
Diff: https://reviews.apache.org/r/34805/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Commented] (KAFKA-2213) Log cleaner should write compacted messages using configured compression type

2015-06-17 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14589610#comment-14589610 ] Manikumar Reddy commented on KAFKA-2213: Updated reviewboard h

[jira] [Updated] (KAFKA-2213) Log cleaner should write compacted messages using configured compression type

2015-06-17 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2213: --- Status: Patch Available (was: In Progress) > Log cleaner should write compacted messa

[jira] [Updated] (KAFKA-2213) Log cleaner should write compacted messages using configured compression type

2015-06-17 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2213: --- Attachment: KAFKA-2213_2015-06-17_16:05:53.patch > Log cleaner should write compac

[jira] [Commented] (KAFKA-2200) kafkaProducer.send() should not call callback.onCompletion()

2015-06-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591531#comment-14591531 ] Manikumar Reddy commented on KAFKA-2200: In KafkaProducer.send() method

Review Request 35610: Patch for KAFKA-2265

2015-06-18 Thread Manikumar Reddy O
/ Testing --- Thanks, Manikumar Reddy O

[jira] [Updated] (KAFKA-2265) creating a topic with large number of partitions takes a long time

2015-06-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2265: --- Attachment: KAFKA-2265.patch > creating a topic with large number of partitions takes a l

[jira] [Updated] (KAFKA-2265) creating a topic with large number of partitions takes a long time

2015-06-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2265: --- Assignee: Manikumar Reddy Status: Patch Available (was: Open) > creating a topic w

[jira] [Commented] (KAFKA-2265) creating a topic with large number of partitions takes a long time

2015-06-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591963#comment-14591963 ] Manikumar Reddy commented on KAFKA-2265: Created reviewboard h

[jira] [Commented] (KAFKA-2265) creating a topic with large number of partitions takes a long time

2015-06-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591976#comment-14591976 ] Manikumar Reddy commented on KAFKA-2265: For each partition, we are par

[jira] [Comment Edited] (KAFKA-2265) creating a topic with large number of partitions takes a long time

2015-06-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591976#comment-14591976 ] Manikumar Reddy edited comment on KAFKA-2265 at 6/18/15 3:3

[jira] [Resolved] (KAFKA-1465) kafka-reassign-partitions.sh fails when topic name contains dash/hyphen

2015-06-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy resolved KAFKA-1465. Resolution: Fixed Fix Version/s: 0.8.3 Not able to reproduce this issue on trunk

[jira] [Commented] (KAFKA-2283) scheduler exception on non-controller node when shutdown

2015-06-19 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14593154#comment-14593154 ] Manikumar Reddy commented on KAFKA-2283: looks like this got fixed in t

[jira] [Resolved] (KAFKA-1656) "replica-assignment" option in "bin/kakfa-topics.sh" doesn't work with "alter"

2015-06-19 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy resolved KAFKA-1656. Resolution: Duplicate This got fixed in KAFKA-1947 > "replica-assignment" op

Re: Review Request 35503: Patch for KAFKA-2012

2015-06-19 Thread Manikumar Reddy O
scala a8e57c2348e694a1e0d5407ae8ae105fb1f1bf59 Diff: https://reviews.apache.org/r/35503/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Commented] (KAFKA-2012) Broker should automatically handle corrupt index files

2015-06-19 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14593418#comment-14593418 ] Manikumar Reddy commented on KAFKA-2012: Updated reviewboard h

[jira] [Updated] (KAFKA-2012) Broker should automatically handle corrupt index files

2015-06-19 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2012: --- Attachment: KAFKA-2012_2015-06-19_18:55:11.patch > Broker should automatically handle corr

Re: Review Request 35503: Patch for KAFKA-2012

2015-06-19 Thread Manikumar Reddy O
rrect? The mmapping of the index file happens in the > > initialization of OffsetIndex. It seems that we need to re-create the > > LogSegment after the index file is deleted. index file gets recreated in OffsetIndex.mmap() method (val newlyCreated = file.create

[jira] [Updated] (KAFKA-2012) Broker should automatically handle corrupt index files

2015-06-19 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2012: --- Status: Patch Available (was: In Progress) > Broker should automatically handle corr

Re: Review Request 35503: Patch for KAFKA-2012

2015-06-19 Thread Manikumar Reddy O
scala a8e57c2348e694a1e0d5407ae8ae105fb1f1bf59 Diff: https://reviews.apache.org/r/35503/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Commented] (KAFKA-2012) Broker should automatically handle corrupt index files

2015-06-19 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14593535#comment-14593535 ] Manikumar Reddy commented on KAFKA-2012: Updated reviewboard h

[jira] [Updated] (KAFKA-2012) Broker should automatically handle corrupt index files

2015-06-19 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2012: --- Attachment: KAFKA-2012_2015-06-19_21:09:22.patch > Broker should automatically handle corr

[jira] [Commented] (KAFKA-2012) Broker should automatically handle corrupt index files

2015-06-19 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14594420#comment-14594420 ] Manikumar Reddy commented on KAFKA-2012: I am not sure if we can find out

[jira] [Comment Edited] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

2015-06-23 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597558#comment-14597558 ] Manikumar Reddy edited comment on KAFKA-1901 at 6/23/15 12:1

[jira] [Commented] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

2015-06-23 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597558#comment-14597558 ] Manikumar Reddy commented on KAFKA-1901: Probably the easiest thing to do w

[jira] [Comment Edited] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

2015-06-23 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597558#comment-14597558 ] Manikumar Reddy edited comment on KAFKA-1901 at 6/23/15 12:1

[jira] [Commented] (KAFKA-2199) Make signing artifacts optional, setting maven repository possible from command line

2015-06-24 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599700#comment-14599700 ] Manikumar Reddy commented on KAFKA-2199: ./gradlew build is failing with b

Review Request 35867: Patch for KAFKA-1901

2015-06-25 Thread Manikumar Reddy O
/MetricsTest.java 544e120594de78c43581a980b1e4087b4fb98ccb core/src/main/scala/kafka/common/AppInfo.scala d642ca555f83c41451d4fcaa5c01a1f86eff0a1c Diff: https://reviews.apache.org/r/35867/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Commented] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

2015-06-25 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14600961#comment-14600961 ] Manikumar Reddy commented on KAFKA-1901: Created reviewboard h

[jira] [Updated] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

2015-06-25 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1901: --- Attachment: KAFKA-1901.patch > Move Kafka version to be generated in code by build (inst

[jira] [Updated] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

2015-06-25 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1901: --- Assignee: Manikumar Reddy Status: Patch Available (was: Open) > Move Kafka version

Re: Review Request 35867: Patch for KAFKA-1901

2015-06-25 Thread Manikumar Reddy O
ributes. Example MBean: kafka.producer:type=AppInfo,client-id=producer1 kafka.producer:type=AppInfo,client-id=producer2 kafka.consumer:type=AppInfo,client-id=consumer1 kafka.consumer:type=AppInfo,client-id=conusmer2 - Manikumar Reddy --- T

Review Request 35880: Patch for KAFKA-2295

2015-06-25 Thread Manikumar Reddy O
168a18d380c200ee566eccb6988dd1ae85ed5b09 Diff: https://reviews.apache.org/r/35880/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 35880: Patch for KAFKA-2295

2015-06-25 Thread Manikumar Reddy O
/CoreUtils.scala 168a18d380c200ee566eccb6988dd1ae85ed5b09 Diff: https://reviews.apache.org/r/35880/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Updated] (KAFKA-2295) Dynamically loaded classes (encoders, etc.) may not be found by Kafka Producer

2015-06-25 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2295: --- Assignee: Manikumar Reddy (was: Jun Rao) Status: Patch Available (was: Open

[jira] [Updated] (KAFKA-2295) Dynamically loaded classes (encoders, etc.) may not be found by Kafka Producer

2015-06-25 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2295: --- Attachment: KAFKA-2295.patch > Dynamically loaded classes (encoders, etc.) may not be fo

[jira] [Commented] (KAFKA-2295) Dynamically loaded classes (encoders, etc.) may not be found by Kafka Producer

2015-06-25 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601476#comment-14601476 ] Manikumar Reddy commented on KAFKA-2295: Created reviewboard h

[jira] [Resolved] (KAFKA-1540) Gradle error "Could not create task of type 'ScalaDoc'"

2015-06-25 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy resolved KAFKA-1540. Resolution: Not A Problem This is gradle related issue with java8. This got fixed in gradle

Re: Review Request 35867: Patch for KAFKA-1901

2015-06-26 Thread Manikumar Reddy O
someone is running/testing with. However, it is > > obviously not foolproof since you could have local changes that are > > staged/unstaged but not committed. > > > > This is probably good enough, but can you think about whether it is > > possible

[jira] [Updated] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

2015-06-26 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1901: --- Attachment: KAFKA-1901_2015-06-26_13:16:29.patch > Move Kafka version to be generated in c

Re: Review Request 35867: Patch for KAFKA-1901

2015-06-26 Thread Manikumar Reddy O
98ccb core/src/main/scala/kafka/common/AppInfo.scala d642ca555f83c41451d4fcaa5c01a1f86eff0a1c core/src/main/scala/kafka/server/KafkaServer.scala 52dc728bb1ab4b05e94dc528da1006040e2f28c9 Diff: https://reviews.apache.org/r/35867/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Commented] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

2015-06-26 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602524#comment-14602524 ] Manikumar Reddy commented on KAFKA-1901: Updated reviewboard h

[jira] [Resolved] (KAFKA-1100) metrics shouldn't have generation/timestamp specific names

2015-06-26 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy resolved KAFKA-1100. Resolution: Fixed Fix Version/s: 0.8.2.1 This got fixed in KAFKA-1481. Hence closing

[jira] [Commented] (KAFKA-2302) Currently iterated chunk is not cleared during consumer shutdown

2015-06-26 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602910#comment-14602910 ] Manikumar Reddy commented on KAFKA-2302: After calling shutdown method, we

Re: Review Request 35880: Patch for KAFKA-2295

2015-07-04 Thread Manikumar Reddy O
t; > > How about add a createObject function in Utils.java like > > coreUtils.scala and let other java code calls it? we already have Utils.newInstance() method. If required, we can add createObject() method. - Manikumar Reddy

Re: Review Request 35880: Patch for KAFKA-2295

2015-07-05 Thread Manikumar Reddy O
.java db1b0ee9113215b5ad7fda0f93915f3bdd34ac55 core/src/main/scala/kafka/utils/CoreUtils.scala 168a18d380c200ee566eccb6988dd1ae85ed5b09 Diff: https://reviews.apache.org/r/35880/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Updated] (KAFKA-2295) Dynamically loaded classes (encoders, etc.) may not be found by Kafka Producer

2015-07-05 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2295: --- Attachment: KAFKA-2295_2015-07-06_11:32:58.patch > Dynamically loaded classes (encoders,

[jira] [Commented] (KAFKA-2295) Dynamically loaded classes (encoders, etc.) may not be found by Kafka Producer

2015-07-05 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14614582#comment-14614582 ] Manikumar Reddy commented on KAFKA-2295: Updated reviewboard h

Re: Review Request 35880: Patch for KAFKA-2295

2015-07-10 Thread Manikumar Reddy O
reviews.apache.org/r/35880/diff/2/?file=999581#file999581line221> > > > > Can we use scala's Utils.createObject here? Are you sugessting to use Utils.newInstance()? We dont have scala's Utils.scala. Am I missing something? - Manikumar Reddy -

Re: Review Request 35867: Patch for KAFKA-1901

2015-07-10 Thread Manikumar Reddy O
/main/scala/kafka/common/AppInfo.scala d642ca555f83c41451d4fcaa5c01a1f86eff0a1c core/src/main/scala/kafka/server/KafkaServer.scala 18917bc4464b9403b16d85d20c3fd4c24893d1d3 Diff: https://reviews.apache.org/r/35867/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Commented] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

2015-07-10 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622151#comment-14622151 ] Manikumar Reddy commented on KAFKA-1901: Updated reviewboard h

[jira] [Updated] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

2015-07-10 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1901: --- Attachment: KAFKA-1901_2015-07-10_16:42:53.patch > Move Kafka version to be generated in c

[jira] [Commented] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

2015-07-10 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622154#comment-14622154 ] Manikumar Reddy commented on KAFKA-1901: [~jjkoshy] pinging for review &g

Re: Review Request 34805: Patch for KAFKA-2213

2015-07-10 Thread Manikumar Reddy O
://reviews.apache.org/r/34805/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Updated] (KAFKA-2213) Log cleaner should write compacted messages using configured compression type

2015-07-10 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2213: --- Attachment: KAFKA-2213_2015-07-10_20:18:06.patch > Log cleaner should write compac

[jira] [Commented] (KAFKA-2213) Log cleaner should write compacted messages using configured compression type

2015-07-10 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622399#comment-14622399 ] Manikumar Reddy commented on KAFKA-2213: Updated reviewboard h

Re: Review Request 34805: Patch for KAFKA-2213

2015-07-10 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34805/#review91298 --- Joel, need your inputs for proceeding further on this. - Manikumar

Re: Review Request 35454: Patch for KAFKA-2159

2015-07-10 Thread Manikumar Reddy O
/ Testing --- Thanks, Manikumar Reddy O

[jira] [Updated] (KAFKA-2159) offsets.topic.segment.bytes and offsets.topic.retention.minutes are ignored

2015-07-10 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2159: --- Attachment: KAFKA-2159_2015-07-10_21:14:26.patch > offsets.topic.segment.bytes

[jira] [Commented] (KAFKA-2159) offsets.topic.segment.bytes and offsets.topic.retention.minutes are ignored

2015-07-10 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622495#comment-14622495 ] Manikumar Reddy commented on KAFKA-2159: Updated reviewboard h

Re: Review Request 34641: Patch for KAFKA-2214

2015-07-10 Thread Manikumar Reddy O
/ Testing --- Thanks, Manikumar Reddy O

[jira] [Updated] (KAFKA-2214) kafka-reassign-partitions.sh --verify should return non-zero exit codes when reassignment is not completed yet

2015-07-10 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2214: --- Attachment: KAFKA-2214_2015-07-10_21:56:04.patch > kafka-reassign-partitions.sh --ver

[jira] [Commented] (KAFKA-2214) kafka-reassign-partitions.sh --verify should return non-zero exit codes when reassignment is not completed yet

2015-07-10 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622551#comment-14622551 ] Manikumar Reddy commented on KAFKA-2214: Updated reviewboard h

[jira] [Commented] (KAFKA-2214) kafka-reassign-partitions.sh --verify should return non-zero exit codes when reassignment is not completed yet

2015-07-10 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622553#comment-14622553 ] Manikumar Reddy commented on KAFKA-2214: [~junrao] pinging for review >

Re: Review Request 34403: Patch for KAFKA-2198

2015-07-10 Thread Manikumar Reddy O
--- Thanks, Manikumar Reddy O

[jira] [Updated] (KAFKA-2198) kafka-topics.sh exits with 0 status on failures

2015-07-10 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2198: --- Attachment: KAFKA-2198_2015-07-10_22:02:02.patch > kafka-topics.sh exits with 0 status

[jira] [Commented] (KAFKA-2198) kafka-topics.sh exits with 0 status on failures

2015-07-10 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622559#comment-14622559 ] Manikumar Reddy commented on KAFKA-2198: Updated reviewboard h

[jira] [Commented] (KAFKA-2198) kafka-topics.sh exits with 0 status on failures

2015-07-10 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622561#comment-14622561 ] Manikumar Reddy commented on KAFKA-2198: [~junrao] pinging for review >

[jira] [Commented] (KAFKA-2198) kafka-topics.sh exits with 0 status on failures

2015-07-10 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622637#comment-14622637 ] Manikumar Reddy commented on KAFKA-2198: [~gwenshap] Thanks for the re

<    9   10   11   12   13   14   15   16   17   18   >