Re: Last sprint to finish line: Replace EasyMock/Powermock with Mockito

2022-08-15 Thread Christo
/pull/12505*  https://github.com/apache/kafka/pull/12509 Best,Christo On Thursday, 4 August 2022, 18:27:17 BST, Divij Vaidya wrote: Hi everyone To provide you with quick updates on the progress. Open PRs (pending review):   1. Streams - https://github.com/apache/kafka/pull/1244

Re: Last sprint to finish line: Replace EasyMock/Powermock with Mockito

2022-09-05 Thread Christo
Hello! Apologies for the delay in my reply. I have started working on migrating the  TaskManagerTest to Mockito, but have not raised a pull request yet. It is on the list in https://issues.apache.org/jira/browse/KAFKA-14133 and I will add you as a reviewer the moment I publish it. Best,Christo

[DISCUSS] KIP-895: Dynamically refresh partition count of __consumer_offsets

2022-12-29 Thread Christo
the cluster. https://cwiki.apache.org/confluence/display/KAFKA/KIP-895%3A+Dynamically+refresh+partition+count+of+__consumer_offsets Let me know your thoughts on the matter! Best,Christo

Re: [DISCUSS] KIP-833: Mark KRaft as Production Ready

2022-06-20 Thread Christo
Hello Colin, Thank you for the swift and informative reply! I will have a look at the suggested tickets and pick up one of the free ones. Best, Christo On Sunday, 19 June 2022, 22:46:41 BST, Colin McCabe wrote: Hi Christo NUKK, We have been trying to label KRaft issues on JIRA with

[DISCUSS] Cluster-wide disablement of Tiered Storage

2023-08-04 Thread Christo Lolov
provision a whole new cluster which just doesn't have it enabled. My preference would be for option 4.1 without a KIP followed by option 4.2 in the future with a KIP once KIP-950 makes it in. Please let me know your thoughts! Best, Christo

[DISCUSS] KIP-963: Upload and delete lag metrics in Tiered Storage

2023-08-08 Thread Christo Lolov
. Thanks in advance for leaving a review! Best, Christo

Re: [DISCUSS] KIP-963: Upload and delete lag metrics in Tiered Storage

2023-08-09 Thread Christo Lolov
with whether I need to change *remote.log.manager.task.interval.ms <http://remote.log.manager.task.interval.ms> *to a lower or higher value. What are your thoughts on the above? Would you find some of them more useful than others? Best, Christo On Tue, 8 Aug 2023 at 16:43, Kamal Chandrap

Re: [VOTE] 3.6.0 RC0

2023-09-19 Thread Christo Lolov
title in the KIPs page, that's my miss Best, Christo On Tue, 19 Sept 2023 at 13:21, Divij Vaidya wrote: > Hey Satish > > Thank you for managing this release. I have a few comments: > > Documentation > > 1. Section: Zookeeper/Stable Version - The documentation states &q

Re: [DISCUSS] KIP-963: Upload and delete lag metrics in Tiered Storage

2023-10-13 Thread Christo Lolov
back to you. Best, Christo On Mon, 25 Sept 2023 at 10:49, Gantigmaa Selenge wrote: > Hi Christo, > > Thank you for writing the KIP. > > I recently raised a PR to add metrics for tracking remote segment deletions > (https://github.com/apache/kafka/pull/14375) but realised th

Re: [DISCUSS] KIP-963: Upload and delete lag metrics in Tiered Storage

2023-10-24 Thread Christo Lolov
metrics and their granularity! Best, Christo On Fri, 13 Oct 2023 at 10:14, Christo Lolov wrote: > Heya Gantigmaa, > > Apologies for the (very) late reply! > > Now that 3.6 has been released and reviewers have a bit more time I will > be picking up this KIP again. I am more

Re: [DISCUSS] KIP-963: Upload and delete lag metrics in Tiered Storage

2023-10-30 Thread Christo Lolov
ri, 27 Oct 2023 at 15:24, Jorge Esteban Quilcate Otoya < quilcate.jo...@gmail.com> wrote: > Hi Christo, > > Thanks for proposing KIP, this metrics will certainly be useful to operate > Kafka Tiered Storage as it becomes production-ready. > > 1. Given that the scope of the KI

Re: [DISCUSS] KIP-963: Upload and delete lag metrics in Tiered Storage

2023-11-14 Thread Christo Lolov
will aim to include it. *re: Kamal* 1. I can add this to the KIP, but similar to what I have mentioned earlier, I believe these are better left to plugin implementations, no? 2. Yeah, this makes sense. Best, Christo On Fri, 10 Nov 2023 at 09:33, Satish Duggana wrote: > Thanks Christo for

Re: [DISCUSS] KIP-963: Upload and delete lag metrics in Tiered Storage

2023-11-17 Thread Christo Lolov
, hence we will be serving requests for those from remote. Am I wrong? Best, Christo On Thu, 16 Nov 2023 at 08:45, Satish Duggana wrote: > Thanks Christo for your reply. > > 101 and 102 We have conclusion on them. > > 103. I am not strongly opinionated on this. I am fine if

[VOTE] KIP-963: Additional metrics in Tiered Storage

2023-11-20 Thread Christo Lolov
Hello all! Now that the discussion for KIP-963 has winded down, I would like to open it for a vote targeting 3.7.0 as the release. You can find the current version of the KIP at https://cwiki.apache.org/confluence/display/KAFKA/KIP-963%3A+Additional+metrics+in+Tiered+Storage Best, Christo

[DISCUSS] KIP-1005: Add EarliestLocalOffset to GetOffsetShell

2023-11-20 Thread Christo Lolov
changing the AdminClient and in particular the GetOffsetShell tool. I am looking forward to your suggestions for improvement! Best, Christo

Re: [DISCUSS] KIP-1005: Add EarliestLocalOffset to GetOffsetShell

2023-11-21 Thread Christo Lolov
Heya! Thanks a lot for this. I have updated the KIP to include exposing the tiered-offset as well. Let me know whether the Public Interfaces section needs more explanations regarding the changes needed to the OffsetSpec or others. Best, Christo On Tue, 21 Nov 2023 at 04:20, Satish Duggana

Re: [VOTE] KIP-963: Additional metrics in Tiered Storage

2023-11-23 Thread Christo Lolov
Hello all, With 3 +1 binding and 1 +1 non-binding votes KIP-963 is adopted 🥳! I will get down to implementing it. Best, Christo On Tue, 21 Nov 2023 at 07:22, Luke Chen wrote: > +1 (binding) from me. > Thanks for the KIP. > > Luke > > On Tue, Nov 21, 2023 at 11:53 AM Satis

Re: [DISCUSS] KIP-1018: Introduce max remote fetch timeout config

2024-04-29 Thread Christo Lolov
)) and one at what you are proposing? As an operator I would find it strange to not see the metric in the RequestMetrics. Your thoughts? Best, Christo On Sun, 28 Apr 2024 at 10:52, Kamal Chandraprakash < kamal.chandraprak...@gmail.com> wrote: > Christo, > > Updated the KIP with t

Re: [VOTE] KIP-1018: Introduce max remote fetch timeout config

2024-05-09 Thread Christo Lolov
Heya Kamal, Thanks for the KIP and the answers in the discussion! +1 from me :) Best, Christo On Thu, 9 May 2024 at 11:11, Federico Valeri wrote: > +1 non binding > > Thanks > > On Thu, May 9, 2024 at 12:05 PM Luke Chen wrote: > > > > Hi Kamal, > > >

Re: [DISCUSS] KIP-950: Tiered Storage Disablement

2024-05-09 Thread Christo Lolov
implementation) happen synchronously. Should people run into timeout problems we can always then have a follow-up KIP where we make it asynchronous. Best, Christo On Tue, 7 May 2024 at 10:04, Kamal Chandraprakash < kamal.chandraprak...@gmail.com> wrote: > Hi Christo, > > Thanks for the

Re: [DISCUSS] KIP-950: Tiered Storage Disablement

2024-05-13 Thread Christo Lolov
8. Best, Christo On Fri, 10 May 2024 at 11:11, Luke Chen wrote: > Hi Christo, > > > 1. I am not certain I follow the question. From DISABLED you can only go > to > ENABLED regardless of whether your cluster is backed by Zookeeper or KRaft. > Am I misunderstanding your

[VOTE] KIP-950: Tiered Storage Disablement

2024-05-14 Thread Christo Lolov
Heya! I would like to start a vote on KIP-950: Tiered Storage Disablement in order to catch the last Kafka release targeting Zookeeper - https://cwiki.apache.org/confluence/display/KAFKA/KIP-950%3A++Tiered+Storage+Disablement Best, Christo

Re: [VOTE] KIP-950: Tiered Storage Disablement

2024-05-24 Thread Christo Lolov
f the community decides that they do in fact want one more 3.x release. I will mark the KRaft part as ready to be started and aiming for either 4.0 or 3.9. Best, Christo

Re: [DISCUSS] KIP-950: Tiered Storage Disablement

2024-07-16 Thread Christo Lolov
Hello! Makes sense thank you for pointing it out, I will aim to update the section. I also need to add to the section for metrics! Best, Christo On Mon, 15 Jul 2024 at 19:45, Jun Rao wrote: > Hi, Christo, > > Thanks for the KIP and sorry for the late reply. > > Since this

Re: [VOTE] KIP-950: Tiered Storage Disablement

2024-07-25 Thread Christo Lolov
e way to achieve this is to keep the remote.log.disable.policy, but only allow it to take a value of "delete". What are your thoughts? Best, Christo On Thu, 25 Jul 2024 at 12:10, Luke Chen wrote: > Hi all, > > I just found the table is not able to be displayed correctly i

Re: [VOTE] KIP-1007: Introduce Remote Storage Not Ready Exception

2023-12-21 Thread Christo Lolov
Heya Kamal, The proposed change makes sense to me as it will be a more explicit behaviour than what Kafka does today - I am happy with it! +1 (non-binding) from me Best, Christo On Tue, 12 Dec 2023 at 09:01, Kamal Chandraprakash < kamal.chandraprak...@gmail.com> wrote: > Hi, > &g

[VOTE] KIP-1005: Expose EarliestLocalOffset and TieredOffset

2023-12-21 Thread Christo Lolov
Heya all! KIP-1005 ( https://cwiki.apache.org/confluence/display/KAFKA/KIP-1005%3A+Expose+EarliestLocalOffset+and+TieredOffset) has been open for around a month with no further comments - I would like to start a voting round on it! Best, Christo

Re: [DISCUSS] KIP-1005: Add EarliestLocalOffset to GetOffsetShell

2024-01-11 Thread Christo Lolov
Thank you Divij! I have updated the KIP to explicitly state that the broker will have a different behaviour when a timestamp of -5 is requested as part of ListOffsets. Best, Christo On Tue, 2 Jan 2024 at 11:10, Divij Vaidya wrote: > Thanks for the KIP Christo. > > The shell command

Re: [DISCUSS] KIP-1005: Add EarliestLocalOffset to GetOffsetShell

2024-01-15 Thread Christo Lolov
. Let me know if you disagree! Best, Christo On Fri, 12 Jan 2024 at 03:43, Luke Chen wrote: > Hi Christo, > > Thanks for the KIP! > One question: > > What will the offset return if tiered storage is disabled? > For "-4 or earliest-local", it should be the same as &

Re: [DISCUSS] KIP-1005: Add EarliestLocalOffset to GetOffsetShell

2024-01-15 Thread Christo Lolov
Heya! Okay, your suggestion also makes sense to me! I have updated the KIP. Best, Christo On Mon, 15 Jan 2024 at 11:51, Luke Chen wrote: > Hi Christo, > > Thanks for the update. > For "-4 or earliest-local" but tiered storage disabled, I agree it should > work as

Re: [VOTE] KIP-1005: Expose EarliestLocalOffset and TieredOffset

2024-01-17 Thread Christo Lolov
Thank you everyone for casting your votes! KIP-1005 passes with 6 +1 (three binding and three not binding) - I will get down to implementing it :) Best, Christo On Tue, 16 Jan 2024 at 01:35, Luke Chen wrote: > +1 binding from me. > > Thanks for the KIP! > Luke > > On Fri,

Re: [DISCUSS] KIP-950: Tiered Storage Disablement

2024-01-17 Thread Christo Lolov
welcome! Best, Christo On Tue, 9 Jan 2024 at 09:44, Doğuşcan Namal wrote: > Hi everyone, any progress on the status of this KIP? Overall looks good to > me but I wonder whether we still need to support it for Zookeeper mode > given that it will be deprecated in the next 3 months. >

Re: [DISCUSS] KIP-950: Tiered Storage Disablement

2024-03-18 Thread Christo Lolov
? Best, Christo On Thu, 14 Mar 2024 at 06:12, Luke Chen wrote: > Hi Christo, > > Any update with this KIP? > If you don't have time to complete it, I can collaborate with you to work > on it. > > Thanks. > Luke > > On Wed, Jan 17, 2024 at 11:38 PM Satish

Re: [ANNOUNCE] New committer: Christo Lolov

2024-03-26 Thread Christo Lolov
Thank you everyone! It wouldn't have been possible without quite a lot of reviews and extremely helpful inputs from you and the rest of the community! I am looking forward to working more closely with you going forward :) On Tue, 26 Mar 2024 at 14:31, Kirk True wrote: > Congratulations

Re: [DISCUSS] KIP-1023: Follower fetch from tiered offset

2024-03-29 Thread Christo Lolov
- earliest-pending-upload-offset or the latest-tiered-offset? If it is the second, then I believe KIP-1005 ought to already be exposing that offset as part of the ListOffsets API, no? Best, Christo On Wed, 27 Mar 2024 at 18:23, Abhijeet Kumar wrote: > Hi All, > > I have created KIP-1023 to

Re: [DISCUSS] KIP-950: Tiered Storage Disablement

2024-03-29 Thread Christo Lolov
it just won't have an effect. Granted, I do believe we should restrict the policy being changed while a disablement is ongoing. re: Satish and Kamal 104, 1 and 2 are fair asks, I will work with Doguscan to update the KIP with the information! Best, Christo On Thu, 28 Mar 2024 at 10:31, Doğuş

Re: [DISCUSS] KIP-1023: Follower fetch from tiered offset

2024-04-05 Thread Christo Lolov
if you introduce a new offset (i.e. pending-upload-offset) you have to make a change to the ListOffsets API (i.e. introduce -6) and thus document it in this KIP as such. However, the last-tiered-offset ought to already be exposed as part of KIP-1005 (under implementation). Am I misunderstanding someth

Re: [DISCUSS] KIP-950: Tiered Storage Disablement

2024-04-09 Thread Christo Lolov
n the StopReplicas API which will then disappear in KRaft world as it is already scheduled for deprecation. What do you think? Best, Christo On Wed, 3 Apr 2024 at 07:59, Luke Chen wrote: > Hi Christo, > > 1. I agree with Doguscan that in KRaft mode, the controller won't send RPCs >

Re: [ANNOUNCE] New Kafka PMC Member: Greg Harris

2024-04-15 Thread Christo Lolov
Congratulations, Greg :) On Mon, 15 Apr 2024 at 07:34, Zhisheng Zhang <31791909...@gmail.com> wrote: > Congratulations Greg! > > > Manikumar 于2024年4月15日周一 13:49写道: > > > Congratulations, Greg. > > > > On Mon, Apr 15, 2024 at 11:18 AM Bruno Cadonna > wrote: > > > > > > Congratulations, Greg! > >

Re: [DISCUSS] KIP-1037: Allow WriteTxnMarkers API with Alter Cluster Permission

2024-04-15 Thread Christo Lolov
should also trust them to be able to abort a hanging transaction. I would support this KIP if it is put to the vote unless there are other suggestions for improvements! Best, Christo On Thu, 11 Apr 2024 at 16:48, Nikhil Ramakrishnan < ramakrishnan.nik...@gmail.com> wrote: > Hi everyo

Re: [DISCUSS] KIP-950: Tiered Storage Disablement

2024-04-15 Thread Christo Lolov
a few changes have been discussed so I will aim to put them on paper in the upcoming days and let everyone know! Best, Christo On Tue, 9 Apr 2024 at 14:49, Doğuşcan Namal wrote: > +1 let's not introduce a new api and mark it immediately as deprecated :) > > On your second comment Luke, o

Re: [DISCUSS] KIP-950: Tiered Storage Disablement

2024-04-19 Thread Christo Lolov
would have to use already existing methods Let me know if there are any new comments or I have missed something! Best, Christo On Mon, 15 Apr 2024 at 12:40, Christo Lolov wrote: > Heya Doguscan, > > I believe that the state of the world after this KIP will be the following: > >

Re: [VOTE] KIP-1037: Allow WriteTxnMarkers API with Alter Cluster Permission

2024-04-22 Thread Christo Lolov
Heya Nikhil, Thanks for the proposal, as mentioned before it makes sense to me! +1 (binding) Best, Christo On Sat, 20 Apr 2024 at 00:25, Justine Olshan wrote: > Hey Nikhil, > > I meant to comment on the discussion thread, but my draft took so long, you > opened the vote. >

Re: [ANNOUNCE] New committer: Igor Soarez

2024-04-25 Thread Christo Lolov
Congratulations Igor :) ! On Thu, 25 Apr 2024 at 17:07, Igor Soarez wrote: > Thanks everyone, I'm very honoured to join! > > -- > Igor >

Re: [VOTE] KIP-1023: Follower fetch from tiered offset

2024-04-26 Thread Christo Lolov
Heya Abhijeet, Thanks a lot for pushing this forward, especially with the explanation of EARLIEST_PENDING_UPLOAD_OFFSET_TIMESTAMP! +1 from me :) Best, Christo On Fri, 26 Apr 2024 at 12:50, Luke Chen wrote: > Hi Abhijeet, > > Thanks for the KIP. > +1 from me. > > Thanks. >

Re: [DISCUSS] KIP-1018: Introduce max remote fetch timeout config

2024-04-27 Thread Christo Lolov
twork/RequestChannel.scala#L521-L527 and https://kafka.apache.org/documentation/#tiered_storage_monitoring. If I am right, then I believe it would be very useful if this KIP also introduces such a metric because the two are tightly coupled. What do you think? Best, Christo On Sat, 27 Apr 2024 at 11:33, Fed

Re: [VOTE] KIP-1075: Introduce delayed remote list offsets purgatory to make LIST_OFFSETS async

2024-08-28 Thread Christo Lolov
Hello! Apologies for the late arrival. I read through the KIP and the discussion thread and I have no concerns with the proposed approach. This is a great improvement! +1 from me. Best, Christo On Fri, 23 Aug 2024 at 02:50, Luke Chen wrote: > +1 from me. > > Thanks. > > On Th

RE: Last sprint to finish line: Replace EasyMock/Powermock with Mockito

2022-09-06 Thread Christo Lolov
elves some of the unassigned tests their contributions would be welcome :) Best, Christo

Re: Last sprint to finish line: Replace EasyMock/Powermock with Mockito

2022-09-24 Thread Christo Lolov
ound 1/3 are remaining. https://issues.apache.org/jira/browse/KAFKA-14132 <https://issues.apache.org/jira/browse/KAFKA-14132> - a little under 1/3 of all classes using PowerMock have been moved and merged; a bit over 2/3 are remaining. Best, Christo

RE: Last sprint to finish line: Replace EasyMock/Powermock with Mockito

2022-11-08 Thread Christo Lolov
big thank you to Shekhar Prasad Rajak (who recently joined our effort), Matthew de Detrich, Dalibor Plavcic, and everyone who has provided reviews over the last month! Best, Christo

Re: [DISCUSS] KIP-895: Dynamically refresh partition count of __consumer_offsets

2023-01-18 Thread Christo Lolov
be shown in a KRaft cluster. Please let me know your opinions on the problem and the presented solution. Best, Christo On Thursday, 29 December 2022 at 14:19:27 GMT, Christo > wrote: > > > Hello! > I would like to start this discussion thread on KIP-895: Dynamically > refresh

RE: Last sprint to finish line: Replace EasyMock/Powermock with Mockito

2023-01-23 Thread Christo Lolov
: * https://github.com/apache/kafka/pull/12728 * https://github.com/apache/kafka/pull/12781 Best, Christo

Re: [DISCUSS] KIP-899: Allow clients to rebootstrap

2023-01-23 Thread Christo Lolov
behaviour either by a reproducible manual test or by a branch with a failing unit/integration test? Best, Christo > On 18 Jan 2023, at 12:07, Ivan Yurchenko wrote: > > Hello! > I would like to start the discussion thread on KIP-899: Allow clients to > rebootstrap. > This KIP

Re: [DISCUSS] KIP-828: Add the corresponding validator to the configuration where the validator is missing

2022-04-13 Thread Lolov, Christo
the impression that you are proposing to add validation to a configuration which didn't have any validation to begin with. Best, Christo On 08/04/2022, 09:54, "Riven Sun" wrote: Hi devs, I've created a KIP that aims to add the corresponding validator to the con

Re: [DISCUSS] KIP-833: Mark KRaft as Production Ready

2022-06-18 Thread Christo NUKK
configurations before so I would want to pick up Modifying certain dynamic configurations on the standalone KRaft controller if possible. Best,Christo On Wednesday, 4 May 2022, 02:03:47 BST, Colin McCabe wrote: Hi all, I've written a KIP for marking KRaft as production ready. Please take a lo

[DISCUSS] KIP-902: Upgrade Zookeeper to 3.8.1

2023-02-15 Thread Christo Lolov
the reviews. Christo

[VOTE] KIP-902: Upgrade Zookeeper to 3.8.1

2023-02-23 Thread Christo Lolov
Christo

Re: [DISCUSS] KIP-902: Upgrade Zookeeper to 3.8.1

2023-03-06 Thread Christo Lolov
#issuecomment-1245590870). ZK 3.7.1 also doesn’t support earlier client/server combinations different to what 3.8.1 does. Best, Christo > On 2 Mar 2023, at 07:07, Luke Chen wrote: > > Hi Christo, > > Thanks for the KIP. > The motivation of upgrading ZK makes sense. > And

Re: [DISCUSS] KIP-902: Upgrade Zookeeper to 3.8.1

2023-03-06 Thread Christo Lolov
Hello Ismael, Thank you for the valid points. I have updated the KIP, but do let me know if you believe it is still not clear enough. Best, Christo > On 2 Mar 2023, at 15:21, Ismael Juma wrote: > > Thanks for the KIP. I think the following is a little confusing since it > doe

Re: [VOTE] KIP-902: Upgrade Zookeeper to 3.8.1

2023-03-15 Thread Christo Lolov
have compliance requirements to only run on stable versions of a software and its dependencies and not keeping the dependencies up to date renders them unable to use Kafka. Please, let me know your thoughts on the matter! Best, Christo On Thu, 9 Mar 2023 at 21:56, Colin McCabe wrote: > Hi,

Re: [DISCUSS] Apache Kafka 3.5.0 release

2023-03-17 Thread Christo Lolov
Hello! What would you suggest as the best way to get more eyes on KIP-902 as I would like it to be included it in 3.5.0? Best, Christo > On 16 Mar 2023, at 10:33, Mickael Maison wrote: > > Hi, > > This is a reminder that KIP freeze is less than a week away (22 Mar). &g

Re: [VOTE] KIP-902: Upgrade Zookeeper to 3.8.1

2023-04-12 Thread Christo Lolov
concern better than I could. Best, Christo On Mon, 10 Apr 2023 at 00:53, Colin McCabe wrote: > On Wed, Mar 15, 2023, at 04:58, Christo Lolov wrote: > > Hello Colin, > > > > Thank you for taking the time to review the proposal! > > > > I have attached a compat

Re: [VOTE] KIP-902: Upgrade Zookeeper to 3.8.1

2023-04-18 Thread Christo Lolov
remove it if you think it is unnecessary or amend it so that it becomes clearer. Please let me know what you think! Best, Christo On Mon, 17 Apr 2023 at 16:30, Mickael Maison wrote: > Hi Christo, > > +1 (binding) > > Thanks for the KIP > > On Fri, Apr 14, 2023 at 7:32 P

Re: [DISCUSS] KIP-895: Dynamically refresh partition count of __consumer_offsets

2023-04-18 Thread Christo Lolov
accepted until that’s done (since this change will be fairly intrusive). Do let me know if I have misunderstood the general sentiment. Best, Christo > On Dec 29, 2022, at 2:18 PM, Christo wrote: > > Hello! > > I would like to start this discussion thread on KIP-895: Dyna

[DISCUSS] KIP-928: Making Kafka resilient to log directories becoming full

2023-05-22 Thread Christo Lolov
. I am interested in your thoughts and any suggestions for improving the proposal! Best, Christo

Re: [DISCUSS] KIP-905: Broker interceptors

2023-05-22 Thread Christo Lolov
an imagine someone saying filter everything above a value X, do some more complex operation, filter everything above a value X, do another more complex operation, filter everything above a value X etc. Let me know your thoughts! Best, Christo On Thu, 9 Feb 2023 at 19:28, David Mariassy wr

RE: [DISCUSS] KIP-858: Handle JBOD broker disk failure in KRaft

2023-05-22 Thread Christo Lolov
starting a vote soon? Best, Christo On 2022/07/27 10:15:22 Igor Soarez wrote: > Hi all, > > I have proposal to handle JBOD disk failures in KRaft mode. > > With KIP-833 KRaft is being marked production ready and ZK mode is being > deprecated but support for JBOD is still a big feat

Re: [DISCUSS] KIP-934: Add DeleteTopicPolicy

2023-05-23 Thread Christo Lolov
Best, Christo On Mon, 22 May 2023 at 17:19, Jorge Esteban Quilcate Otoya < quilcate.jo...@gmail.com> wrote: > Hi everyone, > > I'd like to start a discussion for KIP-934 < > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-934%3A+Add+DeleteTopicPolicy > >

Re: [DISCUSS] KIP-935: Extend AlterConfigPolicy with existing configurations

2023-05-23 Thread Christo Lolov
Hello! This proposal will address problems with configuration dependencies which I run into very frequently, so I am fully supporting the development of this feature! Best, Christo On Mon, 22 May 2023 at 17:18, Jorge Esteban Quilcate Otoya < quilcate.jo...@gmail.com> wrote: > Hi

Re: [VOTE] 3.5.0 RC0

2023-05-23 Thread Christo Lolov
Hey Mickael! I am giving a +1 (non-binding) for this candidate release. * Built from the binary tar.gz source with Java 17 and Scala 2.13 on Intel (m5.4xlarge) and ARM (m6g.4xlarge) machines. * Ran unit and integration tests on Intel and ARM machines. * Ran the Quickstart in both Zookeeper and KR

Re: [DISCUSS] KIP-858: Handle JBOD broker disk failure in KRaft

2023-05-25 Thread Christo Lolov
f there is another time I will do my best to appear. Best, Christo On Tue, 23 May 2023 at 17:59, Igor Soarez wrote: > Hi everyone, > > Someone suggested at the recent Kafka Summit that it may be useful > to have a video call to discuss remaining concerns. > > I'm proposing we hav

Re: [DISCUSS] KIP-858: Handle JBOD broker disk failure in KRaft

2023-05-25 Thread Christo Lolov
Heya! 5th of June 16:30 - 17:00 UTC works for me. Best, Christo On Thu, 25 May 2023 at 15:14, Igor Soarez wrote: > Hi Divij, Christo, > > Thank you for pointing that out. > > Let's aim instead for Monday 5th of June, at the same time – 16:30-17:00 > UTC. > > Pleas

Re: [DISCUSS] KIP-928: Making Kafka resilient to log directories becoming full

2023-06-05 Thread Christo Lolov
e has been reclaimed would require a bounce of the broker. I have a want should the KIP be accepted to build upon the proposal to allow auto-recovery without the need of a restart. Best, Christo On Fri, 2 Jun 2023 at 17:02, Igor Soarez wrote: > Hi Christo, > > Thank you for the

Re: [DISCUSS] KIP-928: Making Kafka resilient to log directories becoming full

2023-06-05 Thread Christo Lolov
educe the data they have and only when that also does not work they are okay with sacrificing all of the data. Let me know your thoughts! Best, Christo On Fri, 2 Jun 2023 at 20:09, Colin McCabe wrote: > Hi Christo, > > We're not adding new stuff to ZK at this point (it's de

Re: [DISCUSS] KIP-928: Making Kafka resilient to log directories becoming full

2023-06-07 Thread Christo Lolov
the problem of deleting topics on startup if there is no space left on the disk - is there something wrong with my setup that you disagree with? I think this will continue to be the case even when JBOD + KRaft is implemented. Let me know your thoughts! Best, Christo On Mon, 5 Jun 2023 at 11:03

Re: [VOTE] KIP-937: Improve Message Timestamp Validation

2023-06-27 Thread Christo Lolov
+1 (non-binding) from me as well! This is the type of problem which is difficult to become aware of so the more guardrails we put into place the better. On Wed, 21 Jun 2023 at 23:30, Beyene, Mehari wrote: > Thank you, Justin. That makes sense. > I have updated the KIP to remove the concept of ah

Re: Apache Kafka 3.6.0 release

2023-06-30 Thread Christo Lolov
Hello! I will add KIP-902 to the release plan. I would appreciate a few more reviews on the pull request (https://github.com/apache/kafka/pull/13260) for that KIP as the longer we have it in trunk with tests running against it the more confidence we will have before the release. Best, Christo

[DISCUSS] KIP-952: Regenerate segment-aligned producer snapshots when upgrading to a Kafka version supporting Tiered Storage

2023-07-17 Thread Christo Lolov
tart a discussion on KIP-952: Regenerate segment-aligned producer snapshots when upgrading to a Kafka version supporting Tiered Storage (https://cwiki.apache.org/confluence/x/dIuzDw) which aims to solve this issue. Best, Christo

Re: Apache Kafka 3.6.0 release

2023-07-20 Thread Christo Lolov
that the date for KIP freeze is fast approaching. What are your thoughts on the matter? [1] https://cwiki.apache.org/confluence/display/KAFKA/KIP-952%3A+Regenerate+segment-aligned+producer+snapshots+when+upgrading+to+a+Kafka+version+supporting+Tiered+Storage Best, Christo On Sat, 8 Jul 2023 at 13

Request for permissions to contribute to Apache Kafka

2021-08-13 Thread Christo NUKK
Hello, Wiki ID: christo_lolovJira ID: christo_lolovCould you please grant me the necessary permissions to contribute to Apache Kafka. I don't know whether the above are the corrects identifiers, but they were the only ones I could find. Best wishes,Christo

Request development permissions to Apache Kafka

2021-08-13 Thread Christo NUKK
Wiki ID: christo_lolovJira ID: christo_lolov

Stuck build

2021-08-24 Thread Christo NUKK
Hello, I have a stuck build which has been going on for more than two days, while subsequent pull requests (made by other contributors) appear to have completed. Is there a way I can restart it (https://github.com/apache/kafka/pull/11214)? Thanks in advance. Best,Christo

Re: Stuck build

2021-08-25 Thread Christo NUKK
Hello, Thanks to both of you for your swift responses, suggestions and action. The build has now succeeded. Best,Christo On Wednesday, 25 August 2021, 08:19:17 BST, Bruno Cadonna wrote: Hi Christo, I stopped the build and restarted it. Hopefully, this time it will not get stuck

Re: [DISCUSS] KIP-1058: Txn consumer exerts pressure on remote storage when reading non-txn topic

2024-10-04 Thread Christo Lolov
(TopicIdPartition topicIdPartition, int epochForOffset, long offset) throws RemoteStorageException This will help plugin implementers to build optimisations such as skip lists which will give them the next segment quicker than a linear search. I am keen to hear your thoughts! Best, Christo On Fri, 4 Oct

Re: [ANNOUNCE] New committer: Kamal Chandraprakash

2024-10-04 Thread Christo Lolov
Many congratulations Kamal! Very well deserved! On Tue, 1 Oct 2024 at 08:21, Jorge Esteban Quilcate Otoya < quilcate.jo...@gmail.com> wrote: > Congrats Kamal!! > > On Tue 1. Oct 2024 at 7.54, Kamal Chandraprakash < > kamal.chandraprak...@gmail.com> wrote: > > > Thank you all for your warm wishes!

Re: New release branch 3.9

2024-09-20 Thread Christo Lolov
Hello, I have filed https://issues.apache.org/jira/browse/KAFKA-17584 as a blocker. While it has not been introduced by a KIP, I think this has durability implications and needs to be addressed immediately. Let me know if you disagree! Best, Christo On Thu, 19 Sept 2024 at 16:01, José Armando

Re: [VOTE] KIP-1105: Make remote log manager thread-pool configs dynamic

2024-11-08 Thread Christo Lolov
Heya, I have ran a few times into issues which required adjustment of the thread pools and having to carry out a rolling restart was cumbersome. +1 (binding) for the change! Best, Christo On Thu, 7 Nov 2024 at 16:17, Satish Duggana wrote: > +1 (binding) > > On Thu, 7 Nov 2024

Re: [VOTE] KIP-1058: Txn consumer exerts pressure on remote storage when reading non-txn topic

2024-11-08 Thread Christo Lolov
Heya, Apologies for the delay. You have my +1 vote as well! I am excited to see this making it in 4.0 Best, Christo On Wed, 6 Nov 2024 at 09:43, Kamal Chandraprakash < kamal.chandraprak...@gmail.com> wrote: > Hi all, > > The KIP is passed with 3 (+1) binding votes. Thanks everyo

Re: [ANNOUNCE] New committer: Andrew Schofield

2024-12-02 Thread Christo Lolov
Congratulations Andrew, well deserved! On Mon, 2 Dec 2024 at 16:36, Josep Prat wrote: > Congrats Andrew! > > > On Mon, Dec 2, 2024 at 5:33 PM Mickael Maison > wrote: > > > Congratulations Andrew! > > > > Thanks, > > Mickael > > > > On Mon, Dec 2, 2024 at 5:27 PM Kuan Po Tseng > wrote: > > > >

Re: [DISCUSS] KIP-1126: Serialize changes to Kafka with a build queue

2025-01-24 Thread Christo Lolov
stage in the merge queue + this PR? Or am I misunderstanding the sequence of events? Best, Christo On Fri, 24 Jan 2025 at 04:20, Chris Egerton wrote: > Hi David, > > Thanks for the KIP, and for your ongoing work to improve Kafka CI. > > Two small thoughts: > > 1) Today, there

Re: [ANNOUNCE] New committer: TengYao Chi

2025-04-11 Thread Christo Lolov
Congratulations! On Thu, 10 Apr 2025 at 18:22, David Arthur wrote: > Congrats!! > > David Arthur > > > On Thu, Apr 10, 2025 at 12:43 TengYao Chi wrote: > > > Thank you very much everyone!! > > > > I truly appreciate all your reviews, guidance, and discussions on my code > > contributions. > > Y

Re: [DISCUSS] KIP-1150 Diskless Topics

2025-04-22 Thread Christo Lolov
compile + runtime broker-only dependencies is currently 16 (if I have done my analysis correctly). What problem(s) do you envision w.r.t. spilling to disk which we wouldn't be able to solve with our own implementation that require SQLite? Once again, great work so far! Best, Christo On Sun, 20 Apr

Re: [DISCUSS] KIP-1176: Tiered Storage for Active Log Segment

2025-05-06 Thread Christo Lolov
r proposal you put multiple partitions in the same blob. What and how will move this data back to the old format used by TS? How will you handle compaction? How will you handle indexes? How will you handle transactions? Once again, this is quite exciting, so thanks for the contribution! Best, Chris

Re: [VOTE] KIP-1123: Rack-aware partitioning for Kafka Producer

2025-05-14 Thread Christo Lolov
Hello! Apologies for coming late to the party. I think this is a great idea and don't see why we can't try it out in practice! +1 (binding) Best, Christo On Tue, 29 Apr 2025 at 15:16, Andrew Schofield < andrew_schofield_j...@outlook.com> wrote: > Thanks for the KIP, Iv

Re: 4.0.1 bug-fix release?

2025-06-26 Thread Christo Lolov
Hello! I would like to volunteer as a release manager for 4.0.1! I haven't done this before so I will most likely reach out for help if accepted :) Best, Christo On Wed, 25 Jun 2025 at 16:48, Josep Prat wrote: > But of course, Vivekanand, you are more than welcome to help out testi

[DISCUSS] Apache Kafka 4.0.1 release

2025-06-30 Thread Christo Lolov
to reach out with any questions or concerns about the schedule! Best, Christo

Re: [DISCUSS] Apache Kafka 4.0.1 release

2025-07-23 Thread Christo Lolov
Hello, The 23rd is now drawing to an end. I am slightly behind schedule, but will be continuing with creating the artifacts tomorrow! Best, Christo On Mon, 30 Jun 2025 at 12:31, Christo Lolov wrote: > Hello! > > I have volunteered to be the release manager for the 4.0.1 release. &

[VOTE] 4.0.1 RC0

2025-07-25 Thread Christo Lolov
kafka/actions/runs/16501196196 Thanks, Christo

Re: [VOTE] 4.1.0 RC1

2025-07-30 Thread Christo Lolov
://cwiki.apache.org/confluence/display/KAFKA/Queues+for+Kafka+%28KIP-932%29+-+Preview+Release+Notes and I am able to produce and consume using the CLI tools without it? I don't feel that my documentation-related queries are a blocker. As such +1 (binding) for this release candidate from me :) Best, Christo

[jira] [Created] (KAFKA-15267) Cluster-wide disablement of Tiered Storage

2023-07-28 Thread Christo Lolov (Jira)
Christo Lolov created KAFKA-15267: - Summary: Cluster-wide disablement of Tiered Storage Key: KAFKA-15267 URL: https://issues.apache.org/jira/browse/KAFKA-15267 Project: Kafka Issue Type: Sub

  1   2   >