Heya David,

Thanks a lot for this!

Building on top of Chris's questions - does including only a subset of the
stages in the merge queue mean that while subsequent stages (i.e. tests)
can run in parallel-ish across PRs they will contain trunk + set of PRs
ahead of this one which passed the stage in the merge queue + this PR? Or
am I misunderstanding the sequence of events?

Best,
Christo

On Fri, 24 Jan 2025 at 04:20, Chris Egerton <fearthecel...@gmail.com> wrote:

> Hi David,
>
> Thanks for the KIP, and for your ongoing work to improve Kafka CI.
>
> Two small thoughts:
>
> 1) Today, there's a convention of waiting for a green (or at least
> completed) CI build before merging PRs, which includes running the full
> test suite. This can be relaxed on a case-by-case basis but it's generally
> expected for most PRs.
>
> Since we won't be running the full test suite in the merge queue, would I
> be correct in assuming that it is not a goal of this KIP to further relax
> that convention?
>
> 2) Do you have an estimate on the expected build time if we add unit tests?
> I'm wondering if it would be feasible to enable them in the merge queue.
>
> Cheers,
>
> Chris
>
> On Thu, Jan 23, 2025, 22:06 Ukpa Uchechi <ukpauchec...@gmail.com> wrote:
>
> > Hey David,
> >
> > Is the credentials for Confluent data center different from the one used
> to
> > access Apache Kafka jira?
> >
> > Best Regards.
> >
> > On Fri, 24 Jan 2025 at 03:35, David Arthur <mum...@gmail.com> wrote:
> >
> > > Greetings, Kafka community!
> > >
> > > At long last, the GitHub Merge Queue is upon us. This is a feature that
> > > many of us have wanted for quite a while. After many months of
> > discussion,
> > > the excellent ASF Infra team has delivered!
> > >
> > > Since this is quite a significant change, I have written up the details
> > as
> > > a KIP.
> > >
> > >
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1126%3A+Serialize+changes+to+Kafka+with+build+queue
> > >
> > > Please let me know what you think.
> > >
> > > --
> > > David Arthur
> > >
> >
>

Reply via email to