Re: [ANNOUNCE] New Committer: Manikumar Reddy

Congrats Manikumar! On Thu, Oct 11, 2018 at 2:07 PM Hugo Louro wrote: > Congrats Manikumar! > Hugo > > > On Oct 11, 2018, at 11:04 AM, Kamal Chandraprakash < > kamal.chandraprak...@gmail.com> wrote: > > > > Congratulations, Manikumar! > > > >> On Thu, 11 Oct 2018, 23:29 Rajini Sivaram, > wrote:

Re: [VOTE] KIP-328: Ability to suppress updates for KTables

entInterval", for the same > reasons. > >>>> I > >>>> >>>> simply > >>>> >>>>>>> overlooked it previously. I've updated the KIP accordingly. > >>>> >>>>>>> > >>&

Re: [VOTE] KIP-351: Add --under-min-isr option to describe TopicCommand

Thanks for the KIP +1 (non-binding) -Bill On Wed, Nov 28, 2018 at 7:06 AM Manikumar wrote: > +1 (binding) > Thanks for the KIP. > > Can you update the KIP stating that this option is not supported with > "--zookeeper" option. > > On Mon, Nov 26, 2018 at 11:15 PM Mickael Maison > wrote: > > >

Re: [VOTE] KIP-394: Require member.id for initial join group request

+1 Thanks for the KIP. -Bill On Wed, Dec 5, 2018 at 1:43 PM Matthias J. Sax wrote: > Thanks for the KIP. > > +1 (binding) > > -Matthias > > > On 12/5/18 7:53 AM, Mayuresh Gharat wrote: > > +1 (non-binding) > > > > Thanks, > > > > Mayuresh > > > > > > On Wed, Dec 5, 2018 at 3:59 AM Boyang Chen

Re: [VOTE] - KIP-213 (new vote) - Simplified and revised.

+1 from me. Great job on the KIP. -Bill On Thu, Jan 10, 2019 at 11:35 AM John Roesler wrote: > It's a +1 (nonbinding) from me as well. > > Thanks for sticking with this, Adam! > -John > > On Wed, Jan 9, 2019 at 6:22 PM Guozhang Wang wrote: > > > Hello Adam, > > > > I'm +1 on the current propo

Re: [VOTE] KIP-414: Expose Embedded ClientIds in Kafka Streams

Thanks for the KIP Guozhang, +1 for me. On Fri, Jan 11, 2019 at 7:10 AM Damian Guy wrote: > +1 > > On Fri, 11 Jan 2019 at 05:09, John Roesler wrote: > > > Hi Guozhang, > > > > It sounds reasonable to me. I'm +1 (nonbinding). > > > > -John > > > > On Tue, Jan 8, 2019 at 8:51 PM Guozhang Wang w

Re: [DISCUSS] KIP-258: Allow to Store Record Timestamps in RocksDB

>>>>> new versioned store to be able to read old-versioned changelog > > >>>>> topics. > > >>>>>>>>>> Firstly I think we should not expose key in the public APIs > but > > >>>> only > > >>>>&

Re: [ANNOUNCE] New Committer: Vahid Hashemian

Congratulations! On Tue, Jan 15, 2019 at 7:08 PM Harsha wrote: > Congrats!! > -Harsha > > On Tue, Jan 15, 2019, at 4:00 PM, Mayuresh Gharat wrote: > > congrats !! > > > > On Tue, Jan 15, 2019 at 3:42 PM Matthias J. Sax > > wrote: > > > > > Congrats! > > > > > > On 1/15/19 3:34 PM, Boyang Chen w

Re: [VOTE] KIP-258: Allow to Store Record Timestamps in RocksDB

Thanks for the KIP Matthias. +1 -Bill On Tue, Jan 15, 2019 at 7:33 PM Matthias J. Sax wrote: > Hi, > > I would like to start the vote for KIP-258: > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-258%3A+Allow+to+Store+Record+Timestamps+in+RocksDB > > The KIP adds new stores that all

Re: [DISCUSS] KIP-307: Allow to define custom processor names with KStreams DSL

I'm getting caught up with the current state of this KIP. I agree that the question on what to do with overloads is a difficult one to answer. Both John and Matthias have laid out their thoughts thoroughly, and the points made by both resonate with me. I've spent some time thinking about this, a

Re: [VOTE] KIP-307: Allow to define custom processor names with KStreams DSL

Thanks for the KIP Florian, it will be a useful addition. +1 on the KIP for me. -Bill On Thu, Jan 17, 2019 at 4:31 PM Florian Hussonnois wrote: > Hi folks, > > I would like to initiate a vote for the following KIP : > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-307%3A+Allow+to+defi

Re: [DISCUSS] KIP-307: Allow to define custom processor names with KStreams DSL

t; but we should take care to make sure the getter method has the same name > > everywhere for minimum confusion. > > > > Thanks, everyone! > > -John > > > > On Thu, Jan 17, 2019 at 12:09 PM Bill Bejeck wrote: > > > > > I'm getting caught up w

Re: [DISCUSS] KIP-307: Allow to define custom processor names with KStreams DSL

ed implements NamedOperation` class with a protected `name` > field, > >>> set by the `withName` setter (and also other config objects would do > the > >>> same, e.g., `Grouped implements NamedOperation`) > >>> * `NamedInternal extends Named` class with a public (bu

[DISCUSS] KIP-295: Add Streams Configuration Allowing for Optional Topology Optimization

All, I'd like to start a discussion about adding a configuration parameter allowing for the forthcoming topology optimization to be optional via configuration. The KIP can be found here: https://cwiki.apache.org/confluence/display/KAFKA/KIP-295%3A+Add+Streams+Configuration+Allowing+for+Optional+T

Re: [VOTE] KIP-266: Add TimeoutException for KafkaConsumer#position

+1 Thanks, Bill On Fri, May 4, 2018 at 7:21 PM, Richard Yu wrote: > Hi all, I would like to bump this thread since discussion in the KIP > appears to be reaching its conclusion. > > > > On Thu, Mar 15, 2018 at 3:30 PM, Richard Yu > wrote: > > > Hi all, > > > > Since there does not seem to be t

Re: [DISCUSS] KIP-295: Add Streams Configuration Allowing for Optional Topology Optimization

n the future? > > > > > > Hi Ted, > > > > The cover JIRA for topology optimization can be found here: > > https://issues.apache.org/jira/browse/KAFKA-6034 > > > > > > Guozhang > > > > > > On Mon, May 7, 2018 at 11:04 AM, Ted Yu wr

Re: [DISCUSS] KIP-295: Add Streams Configuration Allowing for Optional Topology Optimization

vidual optimizations on/off is too > >> fine grained and hard to maintain. However, for compatibility, it might > >> make sense, to have certain "levels of optimizations" (based on the > >> release) that allow users to stay with on an older level for upgrade >

Re: [VOTE] KIP-244: Add Record Header support to Kafka Streams

Thanks for the KIP! +1 -Bill On Tue, May 15, 2018 at 1:47 PM, Damian Guy wrote: > Thanks. +1 (binding) > > On Tue, 15 May 2018 at 01:04 Jorge Esteban Quilcate Otoya < > quilcate.jo...@gmail.com> wrote: > > > @Guozhang added. Thanks! > > > > El mar., 15 may. 2018 a las 5:50, Matthias J. Sax (<

Re: [DISCUSS] KIP-295: Add Streams Configuration Allowing for Optional Topology Optimization

ot; and "all", should we change the config name > to just "topology.optimizations"? > > The "enable." feels like a holdover from the boolean-valued config. > > Thanks, > -John > > On Tue, May 8, 2018 at 9:13 PM, Bill Bejeck wrote: > > > T

Re: [DISCUSS] KIP-295: Add Streams Configuration Allowing for Optional Topology Optimization

At this point, I think the overall discussion on the new config is completed and I'll start a voting thread. Thanks, Bill On Tue, May 15, 2018 at 4:37 PM, Bill Bejeck wrote: > Thanks for the comments, John. I've updated the config name on the KIP.. > > -Bill > > &g

[VOTE] KIP-295: Add Streams Configuration Allowing for Optional Topology Optimization

Hi all, I'd like to start a vote on KIP-295: Add Streams Configuration Allowing for Optional Topology Optimization. KIP wiki page: https://cwiki.apache.org/confluence/display/KAFKA/KIP-295%3A+Add+Streams+Configuration+Allowing+for+Optional+Topology+Optimization Discussion thread: https://www.mai

Re: [DISCUSS] KIP-303: Add Dynamic Routing in Streams Sink

Thanks for the KIP Guozhang, it's a +1 for me. As for re-using the KeyValueMapper for choosing the topic, I am on the fence, a more explicitly named class would be more clear, but I'm not sure it's worth a new class that will primarily perform the same actions as the KeyValueMapper. Thanks, Bill

Re: [VOTE] KIP-303: Add Dynamic Routing Support in Kafka Streams' Topology Sink

Thanks for the KIP. +1 -Bill On Thu, May 17, 2018 at 2:51 PM, Damian Guy wrote: > Thanks Guozhang. +1 > > Note: the link to the KIP is broken > > On Thu, 17 May 2018 at 11:38 Guozhang Wang wrote: > > > Hello folks, > > > > I'd like to start a voting thread on adding dynamic routing functional

Re: [VOTE] KIP-295: Add Streams Configuration Allowing for Optional Topology Optimization

nal Topology > > Optimization > > +1 (binding). > > > > On Tue, May 15, 2018 at 2:16 PM, Matthias J. Sax > > wrote: > > > > > +1 (binding) > > > > > > > > > On 5/15/18 1:45 PM, Bill Bejeck wrote: > > > > Hi all, > >

Re: [VOTE] KIP-306: Configuration for Delaying Response to Failed Client Authentication

Thanks for the KIP. +1 -Bill On Mon, May 21, 2018 at 1:41 PM, Ted Yu wrote: > +1 > > On Mon, May 21, 2018 at 9:02 AM, Guozhang Wang wrote: > > > Thanks Dhruvil for the KIP, +1 from me (binding). > > > > > > Guozhang > > > > On Mon, May 21, 2018 at 7:52 AM, Dhruvil Shah > > wrote: > > > > > H

Re: [VOTE] KIP-303: Add Dynamic Routing Support in Kafka Streams' Topology Sink

+1 On Tue, May 22, 2018 at 3:46 AM, Ismael Juma wrote: > Breaking API without a deprecation cycle doesn't seem good. Are we sure > about this? > > Ismael > > On Mon, 21 May 2018, 15:04 Guozhang Wang, wrote: > > > Hello Matthias, > > > > I've tried it out on the PR, the implementation should b

Re: [DISCUSS] KIP-307: Allow to define custom processor names with KStreams DSL

Hi Florian, Thanks for the KIP. I think being able to add more context to the processor names would be useful. I like the idea of adding a "withProcessorName" to Produced, Consumed and Joined. But instead of adding the "Processed" parameter to a large percentage of the methods, which would resu

Re: [VOTE] KIP-266: Add TimeoutException for KafkaConsumer#position

t; > > > > > > > rajinisiva...@gmail.com> > > > > > > > >> wrote: > > > > > > > >>> Hi Richard, Thanks for the KIP. > > > > > > > >>> > > > > > > > >>> +1

Re: [VOTE] KIP-266: Add TimeoutException for KafkaConsumer#position

31, 2018 at 6:00 PM, Jason Gustafson > > > wrote: > > > > > > > Thanks everyone for the feedback. I've updated the KIP and added > > > > KAFKA-6979. > > > > > > > > -Jason > > > > > > > > On Wed, May 30, 2018 at 3:

[DISCUSS] KIP-312: Add Overloaded StreamsBuilder Build Method to Accept java.util.Properties

All, I'd like to start the discussion for adding an overloaded method to StreamsBuilder taking a java.util.Properties instance. The KIP is located here : https://cwiki.apache.org/confluence/display/KAFKA/KIP-312%3A+Add+Overloaded+StreamsBuilder+Build+Method+to+Accept+java.util.Properties I look

Re: [DISCUSS] KIP-313: Add KStream.flatTransform and KStream.flatTransformValues

Thanks for the KIP, it's a +1 for me. Looking forward to having a look at the PR. On Mon, Jun 11, 2018 at 9:58 AM Damian Guy wrote: > Thanks for the KIP. LGTM > > On Mon, 11 Jun 2018 at 00:44 Matthias J. Sax > wrote: > > > Thanks for the KIP. > > > > I don't have any comments at this pint. O

Re: [DISCUSS] KIP-312: Add Overloaded StreamsBuilder Build Method to Accept java.util.Properties

ew KafkaStreams(builder, props); > > >>> > > >>> such that it would internally call builder.build(props) ? > > >>> > > >>> Thanks, > > >>> -John > > >>> > > >>> > > >>> &

Re: [VOTE] KIP-228 Negative record timestamp support

+1 Thanks, Bill On Sun, Jun 10, 2018 at 5:32 PM Ted Yu wrote: > +1 > > On Sun, Jun 10, 2018 at 2:17 PM, Matthias J. Sax > wrote: > > > +1 (binding) > > > > Thanks for the KIP. > > > > > > -Matthias > > > > On 5/29/18 9:14 AM, Konstantin Chukhlomin wrote: > > > Thanks, updated the KIP. > > > ht

Re: [DISCUSS] KIP-312: Add Overloaded StreamsBuilder Build Method to Accept java.util.Properties

. > > On Tue, Jun 12, 2018 at 9:21 AM, Bill Bejeck wrote: > > > > Since there're only two values for the optional optimization config > > > introduced by KAFKA-6935, I wonder the overloaded build method (with > > Properties > > > instance) would

Re: [VOTE] KIP-313: Add KStream.flatTransform and KStream.flatTransformValues

Thanks for the KIP, +1. -Bill On Fri, Jun 22, 2018 at 1:08 PM Ted Yu wrote: > +1 > > On Fri, Jun 22, 2018 at 2:50 AM, Bruno Cadonna wrote: > > > Hi list, > > > > I would like to voting on this KIP. > > > > I created a first PR[1] that adds flatTransform. Once I get some > > feedback, I will st

Re: [DISCUSS] KIP-319: Replace segments with segmentSize in WindowBytesStoreSupplier

Hi John, Thanks for the KIP, and overall it's a +1 for me. In the JavaDoc for the segmentInterval method, there's no mention of the number of segments there can be at any one time. While it's implied that the number of segments is potentially unbounded, would be better to explicitly state that t

[VOTE] KIP-312: Add Overloaded StreamsBuilder Build Method to Accept java.util.Properties

All, I'd like to start a vote for this KIP now. Thanks, Bill

Re: [DISCUSS] KIP-319: Replace segments with segmentSize in WindowBytesStoreSupplier

05 PM, John Roesler > > wrote: > > > > > > > >> Thanks for the feedback, Bill and Guozhang, > > > >> > > > >> I've updated the KIP accordingly. > > > >> > > > >> Thanks, > > > >> -Joh

Re: [Discuss] KIP-321: Add method to get TopicNameExtractor in TopologyDescription

Thanks for the KIP! Overall I'm +1 on the KIP. I have one question. The KIP states that the method "topicNameExtractor()" is added to the InternalTopologyBuilder.java. It could be that I'm missing something, but wow does this work if a user has provided different TopicNameExtractor instances t

Re: [VOTE] KIP-319: Replace numSegments to segmentInterval in Streams window configurations

+1 On Mon, Jun 25, 2018 at 11:07 PM Matthias J. Sax wrote: > +1 (binding) > > On 6/25/18 3:00 PM, Guozhang Wang wrote: > > +1 > > > > On Mon, Jun 25, 2018 at 2:58 PM, Ted Yu wrote: > > > >> +1 > >> > >> On Mon, Jun 25, 2018 at 2:56 PM, John Roesler > wrote: > >> > >>> Hello All, > >>> > >>> Th

Re: [VOTE] KIP-324: Add method to get metrics() in AdminClient

+1 -Bill On Wed, Jun 27, 2018 at 12:47 PM Manikumar wrote: > +1 (non-binding) > > Thanks. > > On Wed, Jun 27, 2018 at 10:15 PM Matthias J. Sax > wrote: > > > +1 (binding) > > > > On 6/26/18 2:33 PM, Guozhang Wang wrote: > > > +1. Thanks. > > > > > > On Tue, Jun 26, 2018 at 2:31 PM, Yishun Guan

Re: [DISCUSS] KIP-328: Ability to suppress updates for KTables

Hi John, thanks for the KIP. Early on in the KIP, you mention the current approaches for controlling the rate of downstream records from a KTable, cache size configuration and commit time. Will these configuration parameters still be in effect for tables that don't use suppression? For tables t

Re: [VOTE] KIP-330: Add retentionPeriod in SessionBytesStoreSupplier

+1 -Bill On Wed, Jun 27, 2018 at 7:39 PM Guozhang Wang wrote: > Hello folks, > > I'd like to start a voting thread on KIP-330. I've intentionally skipped > the discuss phase since it is a pretty straight-forward public API change > and should actually be added since day one. The bug fix of KAFK

Re: [VOTE] KIP-312: Add Overloaded StreamsBuilder Build Method to Accept java.util.Properties

72 hours have passed, so I'm going to close out the vote. KIP-312 is accepted with the following votes: +1 (binding) Dongjin Lee, Damian Guy, Guozhang Wang, and Matthias J. Sax +1 (community) Ted Yu, Bill Bejeck -1 none Thanks to all for participating. -Bill On Wed, Jun 27, 2018 at 2:

Re: [DISCUSS] KIP-326: Schedulable KTable as Graph source

Hi Flávio, Thanks for creating the KIP. I agree with Guozhang on comparing the pros and cons of the approach he outlined vs the one in the proposed KIP. I also have a few clarification questions on the current KIP Will the triggering mechanism always be time, or would it make sense to expand to

Re: [DISCUSS] KIP-328: Ability to suppress updates for KTables

g (k:2). When it > later gets to time 3, it's time to emit (k:2) downstream. Because k is no > longer buffered, the suppress operator will log (k:null). Thus, when > recovering, > it can rebuild the buffer by reading its changelog. > > What do you think about this? > > Thank

Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde

Thanks for the KIP! +1 from me. -Bill On Sun, Jul 8, 2018 at 9:55 PM Ismael Juma wrote: > The KIP needs 3 binding votes to pass. I still think we should include the > details of how things will look like with the headers being passed to > serializers/deserializers to ensure things actually make

Re: [Vote] KIP-321: Update TopologyDescription to better represent Source and Sink Nodes

Thanks for the KIP! +1 -Bill On Thu, Jul 26, 2018 at 2:39 AM Guozhang Wang wrote: > +1 > > On Wed, Jul 25, 2018 at 11:13 PM, Matthias J. Sax > wrote: > > > +1 (binding) > > > > -Matthias > > > > On 7/25/18 7:47 PM, Ted Yu wrote: > > > +1 > > > > > > On Wed, Jul 25, 2018 at 7:24 PM Nishanth Pr

Re: [DISCUSS] KIP-258: Allow to Store Record Timestamps in RocksDB

;>>>>>> > >>>>>>>> @Bill: I think a filter predicate should be part of user code. And > >>>> even > >>>>>>>> if we want to add something like this, I would prefer to do it in > a > >&g

Re: [VOTE] KIP-328: Ability to suppress updates for KTables

Thanks for the KIP! +1 -Bill On Mon, Jul 30, 2018 at 3:42 PM Ted Yu wrote: > +1 > > On Mon, Jul 30, 2018 at 11:46 AM John Roesler wrote: > > > Hello devs, > > > > The discussion of KIP-328 has gone some time with no new comments, so I > am > > calling for a vote! > > > > Here's the KIP: https

Re: [ANNOUNCE] New committer: Matthias J. Sax

Congratulations Matthias! -Bill On Fri, Jan 12, 2018 at 7:43 PM, Damian Guy wrote: > Can't think of anyone me deserving! Congratulations Matthias! > On Sat, 13 Jan 2018 at 00:17, Ismael Juma wrote: > > > Congratulations Matthias! > > > > On 12 Jan 2018 10:59 pm, "Guozhang Wang" wrote: > > > >

Re: [DISCUSS] KIP-247: Add public test utils for Kafka Streams

Thanks for the KIP! One meta question: Will users that are currently using the existing testing code with the "classifier:test" approach: 1) have access to the new testing utilities without updating the gradle.build file 2) can they continue to use the current testing code with the cl

Re: [ANNOUNCE] New Kafka PMC Member: Rajini Sivaram

Congrats Rajini! -Bill On Wed, Jan 17, 2018 at 2:02 PM, Matthias J. Sax wrote: > Congrats Rajini!! > > -Matthias > > On 1/17/18 10:54 AM, Vahid S Hashemian wrote: > > Great news! Congratulations Rajini! > > > > --Vahid > > > > > > > > From: Gwen Shapira > > To: "dev@kafka.apache.org" , U

Re: [VOTE] KIP-222 - Add "describe consumer group" to KafkaAdminClient

Thanks for the KIP +1 Bill On Thu, Jan 18, 2018 at 4:24 AM, Rajini Sivaram wrote: > +1 (binding) > > Thanks for the KIP, Jorge. > > Regards, > > Rajini > > On Wed, Jan 17, 2018 at 9:04 PM, Guozhang Wang wrote: > > > +1 (binding). Thanks Jorge. > > > > > > Guozhang > > > > On Wed, Jan 17, 2018

Re: [VOTE] KIP-247: Add public test utils for Kafka Streams

Thanks for the KIP. +1 -Bill On Wed, Jan 17, 2018 at 9:09 PM, Matthias J. Sax wrote: > Hi, > > I would like to start the vote for KIP-247: > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 247%3A+Add+public+test+utils+for+Kafka+Streams > > > -Matthias > >

Re: [DISCUSS] KIP-251: Allow timestamp manipulation in Processor API

Hi Matthias, Thanks for the KIP! Could we consider taking an approach similar to what was done in KIP-182 with regards to overloading? Meaning we could add a "Forwarded" object (horrible name I know) with methods withTimestamp, withChildName, and withChildIndex. To handle the case when both a ch

Re: [DISCUSS] KIP-251: Allow timestamp manipulation in Processor API

context.forward(key, value, To.all().withTimestamp(5)); > > WDYT? > > > -Matthias > > On 2/1/18 8:45 AM, Ted Yu wrote: > > I like Bill's idea (pending a better name for the Forwarded). > > > > Cheers > > > > On Thu, Feb 1, 2018 at 7:47 AM

Re: [VOTE] KIP-251: Allow timestamp manipulation in Processor API

Thanks for the KIP, +1 for me. -Bill On Fri, Feb 9, 2018 at 6:45 AM, Damian Guy wrote: > Thanks Matthias, +1 > > On Fri, 9 Feb 2018 at 02:42 Ted Yu wrote: > > > +1 > > Original message From: "Matthias J. Sax" < > > matth...@confluent.io> Date: 2/8/18 6:05 PM (GMT-08:00) To:

Re: [VOTE] KIP-261: Add Single Value Fetch in Window Stores

Thanks for the KIP! +1 Bill On Sat, Feb 24, 2018 at 2:33 PM, Damian Guy wrote: > Thanks Guozhang! > +1 > > On Sat, 24 Feb 2018 at 19:12 Ted Yu wrote: > > > +1 > > > > On Sat, Feb 24, 2018 at 11:10 AM, Guozhang Wang > > wrote: > > > > > Hi all, > > > > > > I want to start voting on KIP-261 to

Re: [VOTE] KIP-265: Make Windowed Serde to public APIs

Thanks for the KIP Guozhang. +1 -Bill On Mon, Mar 5, 2018 at 5:11 PM, Ted Yu wrote: > +1 > > On Mon, Mar 5, 2018 at 1:46 PM, Guozhang Wang wrote: > > > Hello all, > > > > I'd like to start voting on KIP-265, on making windowed serde to public > > APIs of Kafka Streams. It involves a couple of

Re: [VOTE] KIP-186: Increase offsets retention default to 7 days

+1 Thanks, Bill On Tue, Mar 6, 2018 at 2:27 PM, Matthias J. Sax wrote: > +1 (binding) > > On 3/6/18 10:43 AM, Vahid S Hashemian wrote: > > +1 (non-binding) > > > > Thanks Ewen. > > > > --Vahid > > > > > > > > From: Ewen Cheslack-Postava > > To: dev@kafka.apache.org > > Date: 03/05/2018

Re: [DISCUSS] KIP-267: Add Processor Unit Test Support to Kafka Streams Test Utils

John, Sorry for the delayed response. Thanks for the KIP, I'm +1 on it, and I don't have any further comments on the KIP itself aside from the comments that others have raised. Regarding the existing MockProcessorContext and its removal in favor of the one added from this KIP, I'm actually in fa

Re: [DISCUSS] KIP-258: Allow to Store Record Timestamps in RocksDB

Matthias, Thanks for the KIP, it's a +1 from me. I do have one question regarding the retrieval methods on the new interfaces. Would want to consider adding one method with a Predicate that would allow for filtering records by the timestamp stored with the record? Or is this better left for use

Re: [VOTE] KIP-267: Add Processor Unit Test Support to Kafka Streams Test Utils

Thanks for the KIP. +1 -Bill On Fri, Mar 9, 2018 at 3:16 PM, John Roesler wrote: > Hello all, > > I'd like to start voting on KIP-267, to introduce a MockProcessorContent > enabling Processor, Transformer, and ValueTransformer authors to unit-test > their components. > > https://cwiki.apache.o

Re: [VOTE] KIP-268: Simplify Kafka Streams Rebalance Metadata Upgrade

+1 Thanks, Bill On Tue, Mar 20, 2018 at 9:23 PM, Ted Yu wrote: > +1 > > On Tue, Mar 20, 2018 at 5:56 PM, Richard Yu > wrote: > > > Hi Matthias, > > Thanks for setting up the upgrade path. > > > > +1 (non-binding) > > > > On Tue, Mar 20, 2018 at 3:42 PM, Matthias J. Sax > > wrote: > > > > > Hi

Re: Gradle strategy for exposing and using public test-utils modules

John, Thanks for the clear, detailed explanation. I'm +1 on what you have proposed. While I agree with you manually pulling in transitive test dependencies is not ideal, in this case, I think it's worth it to get over the circular dependency hurdle and use streams:test-utils ourselves. -Bill On

Re: [ANNOUNCE] New Committer: Dong Lin

Congrats Dong! On Wed, Mar 28, 2018 at 1:58 PM, Ted Yu wrote: > Congratulations, Dong. > > On Wed, Mar 28, 2018 at 10:58 AM, Becket Qin wrote: > > > Hello everyone, > > > > The PMC of Apache Kafka is pleased to announce that Dong Lin has accepted > > our invitation to be a new Kafka committer.

Re: [DISCUSS] KIP-274: Kafka Streams Skipped Records Metrics

Thanks for the KIP John, and sorry for the late comments. I'm on the fence with providing a single level metrics, but I think we'll have that discussion outside of this KIP. > * maintain one skipped-record metric (could be per-thread, per-task, or > per-processor-node) with no "reason" > * introd

Re: [VOTE] KIP-274: Kafka Streams Skipped Records Metrics

Thanks for the KIP. +1 -Bill On Mon, Apr 2, 2018 at 10:09 AM, John Roesler wrote: > Dear Kafka community, > > I am proposing KIP-274 to improve visibility when Streams skips invalid > records. > > The proposal is to simplify the metrics and add warning logs. > > Please find details in the wiki

Re: [DISCUSS] KIP-274: Kafka Streams Skipped Records Metrics

t; > > > >>>>> > > > >>>>> > > > >>>>> On your last note, yeah, I got that impression from Guozhang as > > well. > > > >>>>> Thanks for the clarification. > > > >>>>> > >

Re: [DISCUSS] KIP-276: Add StreamsConfig prefix for different consumers

Boyang, Thanks for making changes to the KIP, I'm +1 on the updated version. -Bill On Tue, Apr 3, 2018 at 1:14 AM, Boyang Chen wrote: > Hey friends, > > > both KIP 276+Add+StreamsConfig+prefix+for+different+consumers> and pull request<

Re: [VOTE] KIP-284 Set default retention ms for Streams repartition topics to Long.MAX_VALUE

Thanks for the KIP. +1 -Bill On Mon, Apr 9, 2018 at 7:57 AM, zhenya Sun wrote: > +1 > > > from my iphone！ > On 04/09/2018 17:27, khaireddine Rezgui wrote: > Hi guys, > > I created this thread to get your agreement about the new default value of > the retention_ms in kafka stream repartion topi

Re: [VOTE] KIP-270 A Scala wrapper library for Kafka Streams

+1 -Bill On Mon, Apr 16, 2018 at 5:14 AM, Matthias J. Sax wrote: > +1 (binding) > > On 4/16/18 9:33 AM, Michael Noll wrote: > > +1 (non-binding) > > > > Thanks for contributing and shepherding this, Debasish and team! > > > > And thanks also to Alexis Seigneurin for the original start of the Sc

Re: [VOTE] Kafka 2.0.0 in June 2018

+1 Thanks, Bill On Wed, Apr 18, 2018 at 6:07 PM, Edoardo Comar wrote: > thanks Ismael > > +1 (non-binding) > > -- > > Edoardo Comar > > IBM Message Hub > > IBM UK Ltd, Hursley Park, SO21 2JN > > > > From: Rajini Sivaram > To: dev > Date:

Re: [DISCUSS]KIP-216: IQ should throw different exceptions for different errors

Hi Vito, Thanks for the KIP, overall it's a +1 from me. At this point, the only thing I would change is possibly removing the listing of all methods called by the user and the listing of all store types and focus on what states result in which exceptions thrown to the user. Thanks, Bill On Fri,

Re: [VOTE] KIP-276 Add StreamsConfig prefix for different consumers

+1 Thanks, Bill On Thu, Apr 19, 2018 at 9:50 AM, Boyang Chen wrote: > Thanks guys！ > > Sent from my iPhone > > > On Apr 19, 2018, at 8:28 PM, Matthias J. Sax > wrote: > > > > +1 (binding) > > > > -Matthias > > > >> On 4/19/18 9:08 AM, Ted Yu wrote: > >> +1 > >> Original message --

Re: [DISCUSS] KIP-353: Allow Users to Configure Kafka Streams Timestamp Synchronization

@Guozhang, I've read the KIP and I don't have any further comments in addition to what's already been discussed. Thanks, Bill On Thu, Aug 9, 2018 at 2:26 PM Matthias J. Sax wrote: > @Guozhang, I think you can start the VOTE for this KIP? I don't have any > further comments. > > One more nit: we

Re: [VOTE] KIP-356: Add withCachingDisabled() to StoreBuilder

Thanks for the KIP. +1 -Bill On Tue, Aug 14, 2018 at 1:42 PM Guozhang Wang wrote: > Hello folks, > > I'd like to start a voting thread on the following KIP: > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-356%3A+Add+withCachingDisabled%28%29+to+StoreBuilder > > It is a pretty strai

Re: [VOTE] KIP-353: Allow Users to Configure Multi-Streams Timestamp Synchronization Behavior

+1 Thanks, Bill On Thu, Aug 9, 2018 at 4:20 PM John Roesler wrote: > +1 non-binding > > On Thu, Aug 9, 2018 at 3:14 PM Matthias J. Sax > wrote: > > > +1 (binding) > > > > On 8/9/18 11:57 AM, Guozhang Wang wrote: > > > Hello all, > > > > > > I would like to start the voting processing on the fo

Re: [VOTE] KIP-325: Extend Consumer Group Command to Show Beginning Offsets

+1 Thanks, Bill On Thu, Aug 16, 2018 at 3:13 PM Ted Yu wrote: > +1 > > On Thu, Aug 16, 2018 at 12:05 PM Vahid S Hashemian < > vahidhashem...@us.ibm.com> wrote: > > > I would like to start a vote on KIP-325 which aims at adding a beginning > > offset column to consumer group command describe out

Re: [VOTE] KIP-363: Make FunctionConversions private

+1 -Bill On Mon, Aug 27, 2018 at 10:41 AM John Roesler wrote: > Hey Joan, > > I was thinking more about this... Do any of the conversions in > FunctionConversions convert to types that are used in the public Scala > interface? > > If you've already checked, then carry on. > > Otherwise, we shou

Re: [VOTE] KIP-365: Materialized, Serialized, Joined, Consumed and Produced with implicit Serde

+1 -Bill On Mon, Aug 27, 2018 at 3:24 PM Ted Yu wrote: > +1 > > On Mon, Aug 27, 2018 at 12:18 PM John Roesler wrote: > > > +1 (non-binding) > > > > On Sat, Aug 25, 2018 at 1:16 PM Joan Goyeau wrote: > > > > > Hi, > > > > > > We want to make sure that we always have a serde for all Materialize

Re: [DISCUSS] KIP-369: Alternative Partitioner to Support "Always Round-Robin" Selection

Hi, Thanks for the KIP. Have you considered using the overloaded ProducerRecord constructor where you can specify the partition? I mention this as an option as I encountered the same issue on a previous project and that is how we handled round-robin distribution with non-null keys. Would that

Re: [DISCUSS] KIP-369 Alternative Partitioner to Support "Always Round-Robin" Selection

Hi, NOTE: I sent this earlier, but that message just went to the dev list. I'm including both users and dev now. Thanks for the KIP. Have you considered using the overloaded ProducerRecord constructor where you can specify the partition? I mention this as an option as I encountered the same i

Re: [VOTE] KIP-358: Migrate Streams API to Duration instead of long ms times

Sorry for chiming in late, there was a lot of detail to catch up on. Overall I'm +1 in the KIP. But I do have one question about the KIP in regards to Matthias's comments about defining dual use. In the "Proposed Changes" section, there is "Try to reduce the visibility of methods in next tickets

Re: [VOTE] KIP-358: Migrate Streams API to Duration instead of long ms times

list of deprecated methods in KIP. > > > > > > 2. Some internal methods can't be deprecated or hid from the user for > now. > > > I was trying to say that we should research possibility to reduce > > > visibility of *internal* methods that are *public* now.

Re: [VOTE] KIP-366 - Make FunctionConversations private

+1 -Bill On Thu, Sep 6, 2018 at 4:29 AM Joan Goyeau wrote: > Sournds good, I'll make the deprecation and copy the class over. > > Thanks > > On Wed, 5 Sep 2018 at 22:48 John Roesler wrote: > > > I'm a +1 (non-binding) because we doubt the class is in use. > > > > If you decide to copy it to a

Re: [DISCUSS] KIP-358: Migrate Streams API to Duration instead of long ms times

Hi Nikolay, I'm a +1 to points 1 and 2 above from Guozhang. Thanks, Bill On Mon, Sep 10, 2018 at 6:58 PM Guozhang Wang wrote: > Hello Nikolay, > > Thanks for picking this up! Just sharing my two cents: > > 1) I'd suggest keeping `Punctuator#punctuate(long timestamp)` as is since > comparing wi

[DISCUSS] KIP-372: Naming Joins and Grouping

All I'd like to start a discussion on KIP-372 for the naming of joins and grouping operations in Kafka Streams. The KIP page can be found here: https://cwiki.apache.org/confluence/display/KAFKA/KIP-372%3A+Naming+Joins+and+Grouping I look forward to feedback and comments. Thanks, Bill

Re: [VOTE] KIP-367 Introduce close(Duration) to Producer and AdminClient instead of close(long, TimeUnit)

+1 -Bill On Thu, Sep 13, 2018 at 4:44 AM Mickael Maison wrote: > +1 (non-binding) > Thanks! > On Thu, Sep 13, 2018 at 7:05 AM Manikumar > wrote: > > > > +1 (non-binding) > > > > Thanks for the KIP. > > > > On Thu, Sep 13, 2018 at 10:38 AM Harsha wrote: > > > > > +1 (Binding). > > > Thanks, >

Re: [DISCUSS] KIP-372: Naming Joins and Grouping

; > > I think it is more natural to rename it to > > > > > > > > * [app-id]-[join-name]-left-repartition > > > > > > > > * [app-id]-[join-name]-right-repartition > > > > > > > > > > > > 2. I'd suggest to use the name to

Re: [VOTE] KIP-361: Add Consumer Configuration to Disable Auto Topic Creation

Thanks for the KIP. This is a great addition. +1(non-binding) Bill On Sat, Sep 15, 2018 at 12:06 PM Gwen Shapira wrote: > Thank you. This has been a source of surprises and confusion for a long > time. > +1 > > On Fri, Sep 14, 2018 at 4:55 PM, Dhruvil Shah > wrote: > > > Hi all, > > > > I wo

Re: [ANNOUNCE] New Kafka PMC member: Dong Lin

Congrats! On Sat, Sep 15, 2018 at 1:27 PM Jorge Esteban Quilcate Otoya < quilcate.jo...@gmail.com> wrote: > Congratulations!! > > El sáb., 15 sept. 2018 a las 15:18, Dongjin Lee () > escribió: > > > Congratulations! > > > > Best, > > Dongjin > > > > On Sat, Sep 15, 2018 at 3:00 PM Colin McCabe w

[VOTE] KIP-372: Naming Repartition Topics for Joins and Grouping

All, I'd like to start the voting process for KIP-372. Here's the link to the updated proposal https://cwiki.apache.org/confluence/display/KAFKA/KIP-372%3A+Naming+Repartition+Topics+for+Joins+and+Grouping I'll start with my own +1. Thanks, Bill

Re: [VOTE] KIP-372: Naming Repartition Topics for Joins and Grouping

ongjin Lee wrote: > > > Great improvements. +1. (Non-binding) > > > > On Tue, Sep 18, 2018 at 5:14 AM Matthias J. Sax > > wrote: > > > > > +1 (binding) > > > > > > -Matthias > > > > > > On 9/17/18 1:12 PM, Guozhang Wang wrote

Re: Accessing Topology Builder

Jorge: I have a crazy idea off the top of my head. Would something as low-tech using KSteam.peek calls on either side of certain processors to record start and end times work? Thanks, Bill On Tue, Sep 18, 2018 at 4:38 PM Guozhang Wang wrote: > Jorge: > > My suggestion was to let your users to

Re: [VOTE] KIP-372: Naming Repartition Topics for Joins and Grouping

Hi All, KIP-372 is now accepted with: - 3 Binding +1 (Damian, Guozhang, Matthias) - 3 Non-binding +1 (Dongjin, John, Bill) Thanks to everyone for the votes. -Bill On Thu, Sep 20, 2018 at 7:30 AM Damian Guy wrote: > +1 (binding) > > On Tue, 18 Sep 2018 at 16:33 Bill Bejeck wrote:

Re: [ANNOUNCE] New committer: Colin McCabe

Congrats Colin! On Tue, Sep 25, 2018 at 8:11 AM Manikumar wrote: > Congrats Colin! > > On Tue, Sep 25, 2018 at 4:39 PM Mickael Maison > wrote: > > > Congratulations Colin! > > > > On Tue, Sep 25, 2018, 11:17 Viktor Somogyi-Vass > > > wrote: > > > > > Congrats Colin, well deserved! :) > > > > >

Re: [DISCUSSION] KIP-376: Implement AutoClosable on appropriate classes that has close()

Hi Yishun, Thanks for the KIP, seems like a useful addition. Just a couple of minor comments. Can you list all the changes in the list under "Public Interfaces" in the "Proposed Changes" section that way it's clear what's changing? I realize they all will be very similar, but it's better to be

Re: [VOTE] KIP-372: Naming Repartition Topics for Joins and Grouping

All, I've made a slight adjustment to the KIP and changed the "Joined.name" to "Joined.named" Thanks, Bill On Thu, Sep 20, 2018 at 4:49 PM Bill Bejeck wrote: > Hi All, > > KIP-372 is now accepted with: > - 3 Binding +1 (Damian, Guozhang, Matthias) >

  1   2   3   4   5   6   7   8   9   10   >