Re: [DISCUSS] KIP-1124: Providing a clear Kafka Client upgrade path

2025-02-20 Thread Jun Rao
Hi, Kuan, Thanks for the KIP. A couple of comments. jr1. Since connect is another client, it would be useful to include the compatibility for connect too. jr2. It seems a bit weird to include 2.0 as the bridge release for Kafka client since it's not compatible with the target release 4.0. Jun

Re: Simplifying Java import order tooling

2025-02-20 Thread Chia-Ping Tsai
hi Farid I'm curious, what is the problem with the current import order? Best, Chia-Ping Farid Zakaria 於 2025年2月21日 週五 上午3:46寫道: > Hi Kafka developers, > > I've seen some previous discussions in the past about "adopting > formatting" for the Kafka codebase a la google-java-format. > > While su

Re: [DISCUSS] KIP-1124: Flexible Windows for Late Arriving Data

2025-02-20 Thread Matthias J. Sax
Hi, I was just re-reading to KIP in order to vote and notices that the example seems not to be correct? If we have a window of size 10, and bounds [0,10), [11,20), [21,30) the lower bound would be inclusive, and the upper bound would be exclusive. At least this is how we do it for `TimeWindo

[jira] [Resolved] (KAFKA-18829) Can't use explicit ack when poll returns an empty batch

2025-02-20 Thread Shivsundar R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shivsundar R resolved KAFKA-18829. -- Resolution: Fixed > Can't use explicit ack when poll returns an empty batch >

[jira] [Resolved] (KAFKA-18796) Fix flaky test testAcquisitionLockOnOffsetWithWriteShareGroupStateFailure

2025-02-20 Thread Abhinav Dixit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhinav Dixit resolved KAFKA-18796. --- Resolution: Not A Problem > Fix flaky test testAcquisitionLockOnOffsetWithWriteShareGroupSta

[jira] [Resolved] (KAFKA-18740) Remove BootstrapDirectory#ibp

2025-02-20 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18740. Fix Version/s: (was: 4.1.0) Resolution: Duplicate fixed by https://github.com/a

[jira] [Created] (KAFKA-18839) Drop support for eager rebalancing in Streams

2025-02-20 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-18839: -- Summary: Drop support for eager rebalancing in Streams Key: KAFKA-18839 URL: https://issues.apache.org/jira/browse/KAFKA-18839 Project: Kafka

Re: [DISCUSS] Apache Kafka 4.0.0 release

2025-02-20 Thread David Jacot
Hi Andrew, Please go ahead and merge it to 4.0. Thanks, David On Thu, Feb 20, 2025 at 6:25 PM Andrew Schofield < andrew_schofield_j...@outlook.com> wrote: > Hi David, > I have a small fix that I'd like to back-port to 4.0 for the KIP-932 > consumer (https://github.com/apache/kafka/pull/18964).

[jira] [Created] (KAFKA-18840) Add system test for 2-rolling-bounce bridge release upgrade path in Streams

2025-02-20 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-18840: -- Summary: Add system test for 2-rolling-bounce bridge release upgrade path in Streams Key: KAFKA-18840 URL: https://issues.apache.org/jira/browse/KAFKA-18840

Re: [DISCUSS] KIP-1124: Providing a clear Kafka Client upgrade path

2025-02-20 Thread Matthias J. Sax
Hello, took me some time, and sorry for the long email, but it's complicated... First, I just re-read the latest version of the KIP. Thanks for all the updates. One thing that I an missing in the motivation is, that we really want to stop support direct upgrades from older versions, to cut

Re: Request for PR Review

2025-02-20 Thread Nelson B.
Hi all, This is a kind reminder for anyone who has free time available to review the PR. Thanks! On Mon, Feb 17, 2025 at 5:44 PM Nelson B. wrote: > Hi all, > > Could you help review this PR? > https://github.com/apache/kafka/pull/18828 > Thanks in advance! > > Best, > NB >

[jira] [Resolved] (KAFKA-16475) Create unit test for TopicImageNode

2025-02-20 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 resolved KAFKA-16475. - Resolution: Fixed > Create unit test for TopicImageNode > --- > >

Re: [DISCUSS] KIP-1134: Virtual Clusters in Kafka

2025-02-20 Thread Dániel Urbán
Hi Greg, Trying to respond to some of your questions/points: 1. We started out with the exact model you propose here - if VCs can be nested, the root VC can be a special one, and everything else falls into place. The issue we encountered here is how can clients inside a VC can refer to topics lin

[jira] [Reopened] (KAFKA-18796) Fix flaky test testAcquisitionLockOnOffsetWithWriteShareGroupStateFailure

2025-02-20 Thread Abhinav Dixit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhinav Dixit reopened KAFKA-18796: --- > Fix flaky test testAcquisitionLockOnOffsetWithWriteShareGroupStateFailure > --

[jira] [Created] (KAFKA-18837) Validate controller.quorum.fetch.timeout.ms is a positive value

2025-02-20 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-18837: -- Summary: Validate controller.quorum.fetch.timeout.ms is a positive value Key: KAFKA-18837 URL: https://issues.apache.org/jira/browse/KAFKA-18837 Project: Kafka

Re: [DISCUSS] Apache Kafka 4.0.0 release

2025-02-20 Thread Andrew Schofield
Hi David, I have a small fix that I'd like to back-port to 4.0 for the KIP-932 consumer (https://github.com/apache/kafka/pull/18964). It changes just the KafkaShareConsumer.java so there's no impact on other components. Without this, one of the examples in KIP-932 will not work correctly if the

[jira] [Created] (KAFKA-18838) Fix ArbitraryMemoryRecords so that they are always invalid

2025-02-20 Thread Jira
José Armando García Sancio created KAFKA-18838: -- Summary: Fix ArbitraryMemoryRecords so that they are always invalid Key: KAFKA-18838 URL: https://issues.apache.org/jira/browse/KAFKA-18838

Simplifying Java import order tooling

2025-02-20 Thread Farid Zakaria
Hi Kafka developers, I've seen some previous discussions in the past about "adopting formatting" for the Kafka codebase a la google-java-format. While such a discussion may be ongoing and require further iterations; I was wondering if we could start somewhere smaller. google-java-format has the