Re: [DISCUSS] KIP-812: Introduce another form of the `KafkaStreams.close()` API that forces the member to leave the consumer group

Hi Luke, Thanks for the comment. 3. In that case, I assumed we'd make it behave in the same way of `close()`, and that eventually means the `close(Long.MAX_VALUE)`. It'd be better to specify the default value in the `CloseOptions` class. Let me update the KIP -> Done Thank you. Seung-chan On Sa

Re: [DISCUSS] KIP-812: Introduce another form of the `KafkaStreams.close()` API that forces the member to leave the consumer group

Hi Seung-chan, Thanks for the update. Making the default value to `Long.MAX_VALUE` of duration for consistency makes sense to me. I have no more comments. Thank you. Luke On Sat, Feb 19, 2022 at 5:12 PM Seung-chan Ahn wrote: > Hi Luke, > > Thanks for the comment. > > 3. In that case, I assume

Re: [VOTE] KIP-812: Introduce another form of the `KafkaStreams.close()` API that forces the member to leave the consumer group

Hi Seung-chan, Thanks for the KIP! I'm +1 (binding). Thank you. Luke On Fri, Feb 18, 2022 at 10:04 AM John Roesler wrote: > Thanks for the KIP, Sueng-Chan! > > I’m +1 (binding) > > -John > > On Thu, Feb 17, 2022, at 12:58, Guozhang Wang wrote: > > Thanks Sueng-chan, > > > > I'm +1 on the propo

Re: [VOTE] KIP-812: Introduce another form of the `KafkaStreams.close()` API that forces the member to leave the consumer group

This vote passes with: - 3 +1 (binding) votes from Guozhang, John and Luke Thanks for the votes and feedback Seung-chan On Wed, Feb 16, 2022 at 12:06 AM Seung-chan Ahn wrote: > Hi team, > > I feel like we have a finalized proposal for this improvement >