Request to add to the contributor list

2017-04-30 Thread Amit Daga
Hello Team, Hope you are doing well. My name is Amit Daga. This is to request you to add me to the contributor list. Also if KAFKA-4996 issue is still not assigned, I would like to work on it. Thanks, Amit

[jira] [Commented] (KAFKA-3514) Stream timestamp computation needs some further thoughts

2017-04-30 Thread Michal Borowiecki (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990176#comment-15990176 ] Michal Borowiecki commented on KAFKA-3514: -- I think the description of this ticke

[jira] [Commented] (KAFKA-4923) Add Exactly-Once Semantics to Streams

2017-04-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990178#comment-15990178 ] ASF GitHub Bot commented on KAFKA-4923: --- GitHub user mjsax opened a pull request:

[GitHub] kafka pull request #2945: KAFKA-4923: Add Exactly-Once Semantics to Streams

2017-04-30 Thread mjsax
GitHub user mjsax opened a pull request: https://github.com/apache/kafka/pull/2945 KAFKA-4923: Add Exactly-Once Semantics to Streams You can merge this pull request into a Git repository by running: $ git pull https://github.com/mjsax/kafka kafka-4923-add-eos-to-streams Alter

[jira] [Updated] (KAFKA-4923) Add Exactly-Once Semantics to Streams

2017-04-30 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-4923: --- Status: Patch Available (was: In Progress) > Add Exactly-Once Semantics to Streams >

[jira] [Commented] (KAFKA-3514) Stream timestamp computation needs some further thoughts

2017-04-30 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990281#comment-15990281 ] Matthias J. Sax commented on KAFKA-3514: Your observation is correct -- and this t

[jira] [Commented] (KAFKA-3514) Stream timestamp computation needs some further thoughts

2017-04-30 Thread Michal Borowiecki (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990288#comment-15990288 ] Michal Borowiecki commented on KAFKA-3514: -- Agreed. That's what I meant. Beyond t

[GitHub] kafka pull request #2946: KAFKA-4218: Enable access to key in ValueTransform...

2017-04-30 Thread jeyhunkarimov
GitHub user jeyhunkarimov opened a pull request: https://github.com/apache/kafka/pull/2946 KAFKA-4218: Enable access to key in ValueTransformer This PR groups KAFKA-4218, KAFKA-4726 and KAFKA-3745. You can merge this pull request into a Git repository by running: $ git pull ht

[jira] [Commented] (KAFKA-4218) Enable access to key in ValueTransformer

2017-04-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990294#comment-15990294 ] ASF GitHub Bot commented on KAFKA-4218: --- GitHub user jeyhunkarimov opened a pull req

[jira] [Created] (KAFKA-5144) MinTimestampTracker does not correctly add timestamps lower than the current max

2017-04-30 Thread Michal Borowiecki (JIRA)
Michal Borowiecki created KAFKA-5144: Summary: MinTimestampTracker does not correctly add timestamps lower than the current max Key: KAFKA-5144 URL: https://issues.apache.org/jira/browse/KAFKA-5144

[GitHub] kafka pull request #2947: KAFKA-5144 added 2 test cases

2017-04-30 Thread mihbor
GitHub user mihbor opened a pull request: https://github.com/apache/kafka/pull/2947 KAFKA-5144 added 2 test cases These two newly added test cases are currently failing You can merge this pull request into a Git repository by running: $ git pull https://github.com/mihbor/kafka

[jira] [Commented] (KAFKA-5144) MinTimestampTracker does not correctly add timestamps lower than the current max

2017-04-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990328#comment-15990328 ] ASF GitHub Bot commented on KAFKA-5144: --- GitHub user mihbor opened a pull request:

[jira] [Commented] (KAFKA-5144) MinTimestampTracker does not correctly add timestamps lower than the current max

2017-04-30 Thread Michal Borowiecki (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990329#comment-15990329 ] Michal Borowiecki commented on KAFKA-5144: -- [PR|https://github.com/apache/kafka/p

[GitHub] kafka pull request #2948: KAFKA-5144 renamed and added comments to make it c...

2017-04-30 Thread mihbor
GitHub user mihbor opened a pull request: https://github.com/apache/kafka/pull/2948 KAFKA-5144 renamed and added comments to make it clear what's going on The descendingSubsequence is a misnomer. The linked list is actually arranged so that the lowest timestamp is first and larger t

[jira] [Commented] (KAFKA-5144) MinTimestampTracker does not correctly add timestamps lower than the current max

2017-04-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990333#comment-15990333 ] ASF GitHub Bot commented on KAFKA-5144: --- GitHub user mihbor opened a pull request:

[jira] [Commented] (KAFKA-5144) MinTimestampTracker does not correctly add timestamps lower than the current max

2017-04-30 Thread Michal Borowiecki (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990335#comment-15990335 ] Michal Borowiecki commented on KAFKA-5144: -- Added a second [PR|https://github.com

Re: [DISCUSS] KIP-138: Change punctuate semantics

2017-04-30 Thread Michal Borowiecki
Hi Matthias, I'd like to start moving the discarded ideas into Rejected Alternatives section. Before I do, I want to tidy them up, ensure they've each been given proper treatment. To that end let me go back to one of your earlier comments about the original suggestion (A) to put that to bed.

Re: [DISCUSS] KIP 141 - ProducerRecordBuilder Interface

2017-04-30 Thread Michael Pearce
Why not, instead of deprecating or removing whats there, as noted, its a point of preference, think about something that could wrap the existing, but provide an api that for you is cleaner? e.g. here's a sample idea building on a fluent api way. (this wraps the producer and producer records so

[GitHub] kafka pull request #2949: KAFKA-5055: Kafka Streams skipped-records-rate sen...

2017-04-30 Thread dpoldrugo
GitHub user dpoldrugo opened a pull request: https://github.com/apache/kafka/pull/2949 KAFKA-5055: Kafka Streams skipped-records-rate sensor bug Fix as described in the [KAFKA-5055 Jira comment](https://issues.apache.org/jira/browse/KAFKA-5055?focusedCommentId=15990086&page=com.atla

[jira] [Commented] (KAFKA-5055) Kafka Streams skipped-records-rate sensor producing nonzero values even when FailOnInvalidTimestamp is used as extractor

2017-04-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990377#comment-15990377 ] ASF GitHub Bot commented on KAFKA-5055: --- GitHub user dpoldrugo opened a pull request

[GitHub] kafka pull request #2950: enhance JmxTool usage and output format

2017-04-30 Thread scottf
GitHub user scottf opened a pull request: https://github.com/apache/kafka/pull/2950 enhance JmxTool usage and output format one-time flag to only run the pull once instead of looping forever reporting-interval -1 equivalent to setting one-time reportFormatOpt supports 'origin

[DISCUSS] KIP-147: Add missing type parameters to StateStoreSupplier factories and KGroupedStream/Table methods

2017-04-30 Thread Michal Borowiecki
Hi community! I have just drafted KIP-147: Add missing type parameters to StateStoreSupplier factories and KGroupedStream/Table methods Please let me know if this a step in the right direction. All comments welcome.

kafka tcp connection

2017-04-30 Thread Sharat Jagannath
I was just wondering, when does the kafka producer tcp connection open when using the java api? Is it when initializing the KafkaProducer object using the constructor or when the actual send method is called to send the record? I am guessing its on send since if kafka is down, it throws a connecti

Re: [DISCUSS] KIP 141 - ProducerRecordBuilder Interface

2017-04-30 Thread Stephane Maarek
I’m not sure how people would feel about having two distinct methods to build the same object? An API wrapper may be useful, but it doesn’t bring opinion about how one should program, that’s just driven by the docs. I’m okay with that, but we need concensus On 1/5/17, 6:08 am, "Michael Pearce

[jira] [Created] (KAFKA-5145) Remove task close() call from closeNonAssignedSuspendedTasks method

2017-04-30 Thread Narendra Kumar (JIRA)
Narendra Kumar created KAFKA-5145: - Summary: Remove task close() call from closeNonAssignedSuspendedTasks method Key: KAFKA-5145 URL: https://issues.apache.org/jira/browse/KAFKA-5145 Project: Kafka

Re: [DISCUSS] KIP 141 - ProducerRecordBuilder Interface

2017-04-30 Thread Michael Pearce
See https://hc.apache.org/httpcomponents-client-ga/tutorial/html/fluent.html Doesn't cause much issue over there where you have a fluent api wrapper for those who like that style, and the original more verbose api. Surely it would be better than removing a way of doing things that everyone has

[jira] [Commented] (KAFKA-5144) MinTimestampTracker does not correctly add timestamps lower than the current max

2017-04-30 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990619#comment-15990619 ] Matthias J. Sax commented on KAFKA-5144: It is intended behavior. {{MinTimestampTr