[ https://issues.apache.org/jira/browse/KAFKA-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990335#comment-15990335 ]
Michal Borowiecki commented on KAFKA-5144: ------------------------------------------ Added a second [PR|https://github.com/apache/kafka/pull/2948] which is just a refactoring (does not fix the issue!) to make reasoning about the code easier. It renames variables to express their true meaning and adds comments where it matters. This is a separate PR since it's independent of the tests. If I got it wrong somehow and the test cases are indeed invalid, this refactoring is still useful as it better documents what the code actually does. > MinTimestampTracker does not correctly add timestamps lower than the current > max > -------------------------------------------------------------------------------- > > Key: KAFKA-5144 > URL: https://issues.apache.org/jira/browse/KAFKA-5144 > Project: Kafka > Issue Type: Bug > Components: streams > Affects Versions: 0.10.2.1 > Reporter: Michal Borowiecki > Assignee: Michal Borowiecki > > When adding elements MinTimestampTracker removes all existing elements > greater than the added element. > Perhaps I've missed something and this is intended behaviour but I can't find > any evidence for that in comments or tests. -- This message was sent by Atlassian JIRA (v6.3.15#6346)