Re: Kafka Indentation

2015-08-12 Thread Ismael Juma
On Wed, Aug 12, 2015 at 1:23 AM, Jason Gustafson wrote: > Can the java code be indented without affecting the results of git blame? > If not, then I'd vote to leave it as it is. > Nope. Ismael

[jira] [Created] (KAFKA-2423) Introduce Scalastyle

2015-08-12 Thread Ismael Juma (JIRA)
Ismael Juma created KAFKA-2423: -- Summary: Introduce Scalastyle Key: KAFKA-2423 URL: https://issues.apache.org/jira/browse/KAFKA-2423 Project: Kafka Issue Type: Improvement Reporter:

[jira] [Created] (KAFKA-2424) Consider introducing lint-like tool for Scala

2015-08-12 Thread Ismael Juma (JIRA)
Ismael Juma created KAFKA-2424: -- Summary: Consider introducing lint-like tool for Scala Key: KAFKA-2424 URL: https://issues.apache.org/jira/browse/KAFKA-2424 Project: Kafka Issue Type: Improveme

[jira] [Updated] (KAFKA-2424) Consider introducing lint-like tool for Scala

2015-08-12 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2424: --- Labels: newbie (was: ) > Consider introducing lint-like tool for Scala >

Re: Kafka Indentation

2015-08-12 Thread Ismael Juma
On Wed, Aug 12, 2015 at 1:29 AM, Gwen Shapira wrote: > +1 on not breaking git blame > > -1 on rewriting Kafka in Java > +1 on upping our Scala game (as Ismael pointed out) > I filed a couple of JIRAs, and I'll look at introducing Scalastyle once some of the bigger patches/PRs are merged. https:

[jira] [Commented] (KAFKA-2367) Add Copycat runtime data API

2015-08-12 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693161#comment-14693161 ] Ismael Juma commented on KAFKA-2367: [~ewencp], aside from the nullable fields issue a

[jira] [Created] (KAFKA-2425) Migrate website from SVN to Git

2015-08-12 Thread Ismael Juma (JIRA)
Ismael Juma created KAFKA-2425: -- Summary: Migrate website from SVN to Git Key: KAFKA-2425 URL: https://issues.apache.org/jira/browse/KAFKA-2425 Project: Kafka Issue Type: Improvement

[jira] [Commented] (KAFKA-2364) Improve documentation for contributing to docs

2015-08-12 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693167#comment-14693167 ] Ismael Juma commented on KAFKA-2364: [~anshbansal], the consensus was that moving to G

Re: KAFKA-2364 migrate docs from SVN to git

2015-08-12 Thread Ismael Juma
Hi Gwen, I filed KAFKA-2425 as KAFKA-2364 is about improving the website documentation. Aseem Bansal seemed interested in helping us with the move so I pinged him in the issue. Best, Ismael On Wed, Aug 12, 2015 at 1:51 AM, Gwen Shapira wrote: > Ah, there is already a JIRA in the title. Never m

[jira] [Commented] (KAFKA-2425) Migrate website from SVN to Git

2015-08-12 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693182#comment-14693182 ] Ismael Juma commented on KAFKA-2425: [~anshbansal], are you interested in attempting t

[jira] [Created] (KAFKA-2426) A Kafka node tries to connect to itself through its advertised hostname

2015-08-12 Thread JIRA
Mikaël Cluseau created KAFKA-2426: - Summary: A Kafka node tries to connect to itself through its advertised hostname Key: KAFKA-2426 URL: https://issues.apache.org/jira/browse/KAFKA-2426 Project: Kafk

[jira] [Updated] (KAFKA-2426) A Kafka node tries to connect to itself through its advertised hostname

2015-08-12 Thread JIRA
[ https://issues.apache.org/jira/browse/KAFKA-2426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikaël Cluseau updated KAFKA-2426: -- Description: Hi, when used behind a firewall, Apache Kafka nodes are trying to connect to them

[jira] [Comment Edited] (KAFKA-2078) Getting Selector [WARN] Error in I/O with host java.io.EOFException

2015-08-12 Thread PC (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693213#comment-14693213 ] PC edited comment on KAFKA-2078 at 8/12/15 9:30 AM: Here is an update

[jira] [Commented] (KAFKA-2078) Getting Selector [WARN] Error in I/O with host java.io.EOFException

2015-08-12 Thread PC (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693213#comment-14693213 ] PC commented on KAFKA-2078: --- Here is an update on appears to cause this problem: Pumping 4 mess

[jira] [Created] (KAFKA-2427) Error writing to highwatermark file

2015-08-12 Thread Harish Seshadri (JIRA)
Harish Seshadri created KAFKA-2427: -- Summary: Error writing to highwatermark file Key: KAFKA-2427 URL: https://issues.apache.org/jira/browse/KAFKA-2427 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-2165) ReplicaFetcherThread: data loss on unknown exception

2015-08-12 Thread Artem Kirillov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693242#comment-14693242 ] Artem Kirillov commented on KAFKA-2165: --- We experience the same issue on our product

Re: KAFKA-2364 migrate docs from SVN to git

2015-08-12 Thread Edward Ribeiro
FYI, I created a tiny trivial patch to address a typo in the web site (KAFKA-2418), so maybe you can review it and eventually commit before moving to github. ;) Cheers, Eddie Em 12/08/2015 06:01, "Ismael Juma" escreveu: > Hi Gwen, > > I filed KAFKA-2425 as KAFKA-2364 is about improving the websi

[jira] [Commented] (KAFKA-2425) Migrate website from SVN to Git

2015-08-12 Thread Aseem Bansal (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693316#comment-14693316 ] Aseem Bansal commented on KAFKA-2425: - Yes I am interested. But how to do that. I mean

[jira] [Commented] (KAFKA-2425) Migrate website from SVN to Git

2015-08-12 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693330#comment-14693330 ] Manikumar Reddy commented on KAFKA-2425: You can find the docs here : http://svn.a

[jira] [Comment Edited] (KAFKA-2425) Migrate website from SVN to Git

2015-08-12 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693330#comment-14693330 ] Manikumar Reddy edited comment on KAFKA-2425 at 8/12/15 11:24 AM: --

[jira] [Commented] (KAFKA-2425) Migrate website from SVN to Git

2015-08-12 Thread Aseem Bansal (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693505#comment-14693505 ] Aseem Bansal commented on KAFKA-2425: - The Infra ticket has fields "Git Notification M

[jira] [Comment Edited] (KAFKA-2425) Migrate website from SVN to Git

2015-08-12 Thread Aseem Bansal (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693505#comment-14693505 ] Aseem Bansal edited comment on KAFKA-2425 at 8/12/15 1:54 PM: --

[jira] [Commented] (KAFKA-2425) Migrate website from SVN to Git

2015-08-12 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693544#comment-14693544 ] Manikumar Reddy commented on KAFKA-2425: Issue Type can be simple "Bug". "SVN->GI

[jira] [Commented] (KAFKA-1683) Implement a "session" concept in the socket server

2015-08-12 Thread Eugene Miretsky (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693676#comment-14693676 ] Eugene Miretsky commented on KAFKA-1683: My apologies, didn't word the question pr

[jira] [Comment Edited] (KAFKA-1683) Implement a "session" concept in the socket server

2015-08-12 Thread Eugene Miretsky (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693676#comment-14693676 ] Eugene Miretsky edited comment on KAFKA-1683 at 8/12/15 3:36 PM: ---

[jira] [Comment Edited] (KAFKA-1683) Implement a "session" concept in the socket server

2015-08-12 Thread Eugene Miretsky (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693676#comment-14693676 ] Eugene Miretsky edited comment on KAFKA-1683 at 8/12/15 3:39 PM: ---

[jira] [Comment Edited] (KAFKA-1683) Implement a "session" concept in the socket server

2015-08-12 Thread Eugene Miretsky (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693676#comment-14693676 ] Eugene Miretsky edited comment on KAFKA-1683 at 8/12/15 3:40 PM: ---

[jira] [Commented] (KAFKA-2071) Replace Produce Request/Response with their org.apache.kafka.common.requests equivalents

2015-08-12 Thread David Jacot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693855#comment-14693855 ] David Jacot commented on KAFKA-2071: [~gwenshap] Could you review this one when you ha

[jira] [Commented] (KAFKA-2073) Replace TopicMetadata request/response with o.a.k.requests.metadata

2015-08-12 Thread David Jacot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693859#comment-14693859 ] David Jacot commented on KAFKA-2073: [~abiletskyi] Are you still working on this one?

[jira] [Assigned] (KAFKA-2072) Add StopReplica request/response to o.a.k.common.requests and replace the usage in core module

2015-08-12 Thread David Jacot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot reassigned KAFKA-2072: -- Assignee: David Jacot > Add StopReplica request/response to o.a.k.common.requests and replace t

Re: Review Request 33049: Patch for KAFKA-2084

2015-08-12 Thread Aditya Auradkar
> On Aug. 12, 2015, 12:42 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, line 419 > > > > > > I am still not sure that I see the value of the delay factor. If one > > wants to be a bit

[jira] [Commented] (KAFKA-2071) Replace Produce Request/Response with their org.apache.kafka.common.requests equivalents

2015-08-12 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693874#comment-14693874 ] Gwen Shapira commented on KAFKA-2071: - Its on my review queue, so I definitely will. I

[jira] [Created] (KAFKA-2428) Add sanity test in kafkaConsumer for the timeouts. This is a followup ticket for Kafka-2120

2015-08-12 Thread Mayuresh Gharat (JIRA)
Mayuresh Gharat created KAFKA-2428: -- Summary: Add sanity test in kafkaConsumer for the timeouts. This is a followup ticket for Kafka-2120 Key: KAFKA-2428 URL: https://issues.apache.org/jira/browse/KAFKA-2428

Re: Review Request 36858: Patch for KAFKA-2120

2015-08-12 Thread Mayuresh Gharat
> On Aug. 11, 2015, 8:49 p.m., Jason Gustafson wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java, > > line 302 > > > > > > Can we make this value greater than sessionTimeoutMs (w

Re: Review Request 36858: Patch for KAFKA-2120

2015-08-12 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36858/ --- (Updated Aug. 12, 2015, 5:59 p.m.) Review request for kafka. Bugs: KAFKA-2120

[jira] [Commented] (KAFKA-2120) Add a request timeout to NetworkClient

2015-08-12 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693951#comment-14693951 ] Mayuresh Gharat commented on KAFKA-2120: Updated reviewboard https://reviews.apach

[jira] [Updated] (KAFKA-2120) Add a request timeout to NetworkClient

2015-08-12 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-2120: --- Attachment: KAFKA-2120_2015-08-12_10:59:09.patch > Add a request timeout to NetworkClient > --

Re: [DISCUSS] Client-side Assignment for New Consumer

2015-08-12 Thread Jiangjie Qin
Hey Ewen, Onur and I discussed this a little bit more. And we are still worrying about passing all the metadata of all consumers around. Let's say I have a cluster has 10,000 topics, the average topic name length is 10 bytes. In this case, the opaque metadata will have 10 * 10,000 = 100KB for top

[jira] [Assigned] (KAFKA-2015) Enable ConsoleConsumer to use new consumer

2015-08-12 Thread Ben Stopford (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Stopford reassigned KAFKA-2015: --- Assignee: Ben Stopford (was: Guozhang Wang) > Enable ConsoleConsumer to use new consumer > -

Re: Kafka Indentation

2015-08-12 Thread Edward Ribeiro
+1 about rewriting to Java (in a year or more). +1 about upping Scala use in the meanwhile +1 about using Gradle instead of Maven or SBT. Eddie On Wed, Aug 12, 2015 at 5:26 AM, Ismael Juma wrote: > On Wed, Aug 12, 2015 at 1:29 AM, Gwen Shapira wrote: > > > +1 on not breaking git blame > > > >

[jira] [Commented] (KAFKA-2418) Typo on official KAFKA documentation

2015-08-12 Thread Edward Ribeiro (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693984#comment-14693984 ] Edward Ribeiro commented on KAFKA-2418: --- Hi folks, if you have any free time could s

[jira] [Commented] (KAFKA-2418) Typo on official KAFKA documentation

2015-08-12 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694010#comment-14694010 ] Gwen Shapira commented on KAFKA-2418: - Committed! Our docs look better now :) Thanks

[jira] [Updated] (KAFKA-2418) Typo on official KAFKA documentation

2015-08-12 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-2418: Resolution: Fixed Reviewer: Gwen Shapira Status: Resolved (was: Patch Available) > Ty

Re: Review Request 33049: Patch for KAFKA-2084

2015-08-12 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33049/ --- (Updated Aug. 12, 2015, 7:02 p.m.) Review request for kafka, Joel Koshy and Jun

Re: Review Request 33049: Patch for KAFKA-2084

2015-08-12 Thread Aditya Auradkar
> On Aug. 12, 2015, 12:34 a.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java, lines > > 131-150 > > > > > > I think the comment can be a simpler. Basically, if O is the obser

Re: Review Request 33049: Patch for KAFKA-2084

2015-08-12 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33049/ --- (Updated Aug. 12, 2015, 7:03 p.m.) Review request for kafka, Joel Koshy and Jun

[jira] [Updated] (KAFKA-2084) byte rate metrics per client ID (producer and consumer)

2015-08-12 Thread Aditya A Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya A Auradkar updated KAFKA-2084: - Attachment: KAFKA-2084_2015-08-12_12:02:33.patch > byte rate metrics per client ID (produc

[jira] [Commented] (KAFKA-2084) byte rate metrics per client ID (producer and consumer)

2015-08-12 Thread Aditya A Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694017#comment-14694017 ] Aditya A Auradkar commented on KAFKA-2084: -- Updated reviewboard https://reviews.a

Re: Review Request 33049: Patch for KAFKA-2084

2015-08-12 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33049/ --- (Updated Aug. 12, 2015, 7:04 p.m.) Review request for kafka, Joel Koshy and Jun

Re: Review Request 33049: Patch for KAFKA-2084

2015-08-12 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33049/ --- (Updated Aug. 12, 2015, 7:05 p.m.) Review request for kafka, Joel Koshy and Jun

[jira] [Updated] (KAFKA-2084) byte rate metrics per client ID (producer and consumer)

2015-08-12 Thread Aditya A Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya A Auradkar updated KAFKA-2084: - Attachment: KAFKA-2084_2015-08-12_12:04:51.patch > byte rate metrics per client ID (produc

[jira] [Commented] (KAFKA-2084) byte rate metrics per client ID (producer and consumer)

2015-08-12 Thread Aditya A Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694021#comment-14694021 ] Aditya A Auradkar commented on KAFKA-2084: -- Updated reviewboard https://reviews.a

[jira] [Commented] (KAFKA-2084) byte rate metrics per client ID (producer and consumer)

2015-08-12 Thread Aditya A Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694023#comment-14694023 ] Aditya A Auradkar commented on KAFKA-2084: -- Updated reviewboard https://reviews.a

Re: Review Request 33049: Patch for KAFKA-2084

2015-08-12 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33049/ --- (Updated Aug. 12, 2015, 7:08 p.m.) Review request for kafka, Joel Koshy and Jun

[jira] [Updated] (KAFKA-2084) byte rate metrics per client ID (producer and consumer)

2015-08-12 Thread Aditya A Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya A Auradkar updated KAFKA-2084: - Attachment: KAFKA-2084_2015-08-12_12:08:17.patch > byte rate metrics per client ID (produc

Re: Review Request 33049: Patch for KAFKA-2084

2015-08-12 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33049/ --- (Updated Aug. 12, 2015, 7:09 p.m.) Review request for kafka, Joel Koshy and Jun

[jira] [Commented] (KAFKA-2425) Migrate website from SVN to Git

2015-08-12 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694034#comment-14694034 ] Gwen Shapira commented on KAFKA-2425: - Wouldn't a new branch mean that we can't push c

[jira] [Commented] (KAFKA-1387) Kafka getting stuck creating ephemeral node it has already created when two zookeeper sessions are established in a very short period of time

2015-08-12 Thread James Lent (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694052#comment-14694052 ] James Lent commented on KAFKA-1387: --- After refreshing my memory of this issue I was unab

[jira] [Commented] (KAFKA-2367) Add Copycat runtime data API

2015-08-12 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694057#comment-14694057 ] Ewen Cheslack-Postava commented on KAFKA-2367: -- [~ijuma] No huge benefits. Al

[jira] [Created] (KAFKA-2429) Add annotations to mark classes as stable/unstable

2015-08-12 Thread Ewen Cheslack-Postava (JIRA)
Ewen Cheslack-Postava created KAFKA-2429: Summary: Add annotations to mark classes as stable/unstable Key: KAFKA-2429 URL: https://issues.apache.org/jira/browse/KAFKA-2429 Project: Kafka

[GitHub] kafka pull request: KAFKA-2429: Add annotations to mark classes as...

2015-08-12 Thread ewencp
GitHub user ewencp opened a pull request: https://github.com/apache/kafka/pull/133 KAFKA-2429: Add annotations to mark classes as stable/unstable This also marks the consumer as unstable to show an example of using these annotations. You can merge this pull request into a Git repos

[jira] [Commented] (KAFKA-2429) Add annotations to mark classes as stable/unstable

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694170#comment-14694170 ] ASF GitHub Bot commented on KAFKA-2429: --- GitHub user ewencp opened a pull request:

[jira] [Updated] (KAFKA-2429) Add annotations to mark classes as stable/unstable

2015-08-12 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-2429: - Status: Patch Available (was: In Progress) > Add annotations to mark classes as s

[jira] [Work started] (KAFKA-2429) Add annotations to mark classes as stable/unstable

2015-08-12 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-2429 started by Ewen Cheslack-Postava. > Add annotations to mark classes as stable/unstable > --

[jira] [Updated] (KAFKA-313) Add JSON/CSV output and looping options to ConsumerGroupCommand

2015-08-12 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-313: - Attachment: KAFKA-313_2015-08-12_14:21:32.patch > Add JSON/CSV output and looping options to Consum

[jira] [Updated] (KAFKA-313) Add JSON/CSV output and looping options to ConsumerGroupCommand

2015-08-12 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-313: - Status: Patch Available (was: In Progress) > Add JSON/CSV output and looping options to ConsumerGr

[jira] [Commented] (KAFKA-313) Add JSON/CSV output and looping options to ConsumerGroupCommand

2015-08-12 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694190#comment-14694190 ] Ashish K Singh commented on KAFKA-313: -- Updated reviewboard https://reviews.apache.org

Re: Review Request 28096: Patch for KAFKA-313

2015-08-12 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28096/ --- (Updated Aug. 12, 2015, 9:21 p.m.) Review request for kafka, Gwen Shapira, Jare

Re: Review Request 28096: Patch for KAFKA-313

2015-08-12 Thread Ashish Singh
> On July 29, 2015, 6:35 p.m., Gwen Shapira wrote: > > core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala, lines 237-242 > > > > > > These look identical - copy/paste error? > > Ashish Singh wrote: > Not r

[GitHub] kafka pull request: KAFKA-2300: Error in controller log when broke...

2015-08-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/102 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (KAFKA-2300) Error in controller log when broker tries to rejoin cluster

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694208#comment-14694208 ] ASF GitHub Bot commented on KAFKA-2300: --- Github user asfgit closed the pull request

[jira] [Updated] (KAFKA-2300) Error in controller log when broker tries to rejoin cluster

2015-08-12 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2300: - Resolution: Fixed Status: Resolved (was: Patch Available) Issue resolved by pull request

[GitHub] kafka pull request: MINOR: Fix hard coded strings in ProduceRespon...

2015-08-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/131 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] kafka pull request: KAFKA-2429: Add annotations to mark classes as...

2015-08-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/133 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Updated] (KAFKA-2429) Add annotations to mark classes as stable/unstable

2015-08-12 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-2429: Resolution: Fixed Fix Version/s: 0.8.3 Status: Resolved (was: Patch Available) Is

[jira] [Commented] (KAFKA-2429) Add annotations to mark classes as stable/unstable

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694249#comment-14694249 ] ASF GitHub Bot commented on KAFKA-2429: --- Github user asfgit closed the pull request

Re: KIP Meeting Notes 08/11/2015

2015-08-12 Thread Guozhang Wang
Yeah. Jun used to send out table-summary of backlogs with reviews before KIP meeting, we can continue to do that. Also we used to have a dashboard for replication development tracking, Neha/Jun/Joel do you remember how to setup sth. similar? Guozhang On Tue, Aug 11, 2015 at 10:31 PM, Jiangjie Qi

NEW: API Stability annotations!

2015-08-12 Thread Gwen Shapira
Hi Team Kafka, Ewen just added stability annotations to Apache Kafka (KAFKA-2429). In the same PR, we marked the new Consumer API as "unstable" since we are still actively iterating on them. The goal is to mark them as "evolving" before the next release and after one release to validate them, we

[jira] [Updated] (KAFKA-1893) Allow regex subscriptions in the new consumer

2015-08-12 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-1893: -- Status: Patch Available (was: In Progress) > Allow regex subscriptions in the new consumer > --

[jira] [Work started] (KAFKA-1893) Allow regex subscriptions in the new consumer

2015-08-12 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-1893 started by Ashish K Singh. - > Allow regex subscriptions in the new consumer > -

Re: NEW: API Stability annotations!

2015-08-12 Thread Grant Henke
This is a great idea! I do question the classifications a bit. @stable seams unreasonable as Kafka has not has a "major" release yet. I have typically thought of Kafka releases as 0.{major}.{minor}.{maintenance}. For instance 0.8.3 coming up has a significant amount of change. Though Kafka's relea

[jira] [Commented] (KAFKA-2367) Add Copycat runtime data API

2015-08-12 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694383#comment-14694383 ] Ismael Juma commented on KAFKA-2367: I think using Avro (as suggested by [~gwenshap])

[jira] [Commented] (KAFKA-2425) Migrate website from SVN to Git

2015-08-12 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694393#comment-14694393 ] Ismael Juma commented on KAFKA-2425: Requiring a different branch is annoying. However

[jira] [Commented] (KAFKA-2367) Add Copycat runtime data API

2015-08-12 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694407#comment-14694407 ] Gwen Shapira commented on KAFKA-2367: - I'm a strong +1 on using Avro instead of mainta

Re: Review Request 36858: Patch for KAFKA-2120

2015-08-12 Thread Jason Gustafson
> On Aug. 11, 2015, 8:49 p.m., Jason Gustafson wrote: > > clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java, > > line 302 > > > > > > Can we make this value greater than sessionTimeoutMs (w

[jira] [Commented] (KAFKA-2425) Migrate website from SVN to Git

2015-08-12 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694494#comment-14694494 ] Gwen Shapira commented on KAFKA-2425: - I guess I'm not imagining how it works correctl

Re: NEW: API Stability annotations!

2015-08-12 Thread Gwen Shapira
Yeah, I agree that your description matches reality better :) By "document" do you have any suggestions where? The interface itself has documentation. Were you thinking Wiki? On Wed, Aug 12, 2015 at 3:48 PM, Grant Henke wrote: > This is a great idea! > > I do question the classifications a bit.

[GitHub] kafka pull request: KAFKA-2389: remove commit type from new consum...

2015-08-12 Thread becketqin
GitHub user becketqin opened a pull request: https://github.com/apache/kafka/pull/134 KAFKA-2389: remove commit type from new consumer. A shot to remove commit type from new consumer. The coordinator constructor takes a default offset commit callback mainly for testing purpose. You

[jira] [Commented] (KAFKA-2389) CommitType seems not necessary in commit().

2015-08-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694519#comment-14694519 ] ASF GitHub Bot commented on KAFKA-2389: --- GitHub user becketqin opened a pull request

[GitHub] kafka pull request: KAFKA-Junit3 Misusage

2015-08-12 Thread ewencp
GitHub user ewencp opened a pull request: https://github.com/apache/kafka/pull/135 KAFKA-Junit3 Misusage You can merge this pull request into a Git repository by running: $ git pull https://github.com/ewencp/kafka kafka-1782-junit3-misusage Alternatively you can review and ap

Re: NEW: API Stability annotations!

2015-08-12 Thread Jiangjie Qin
Good annotations. I can see a few future usages :) Jiangjie (Becket) Qin On Wed, Aug 12, 2015 at 3:05 PM, Gwen Shapira wrote: > Hi Team Kafka, > > Ewen just added stability annotations to Apache Kafka (KAFKA-2429). > > In the same PR, we marked the new Consumer API as "unstable" since we are >

Re: Review Request 33049: Patch for KAFKA-2084

2015-08-12 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33049/#review95216 --- core/src/main/scala/kafka/server/ClientQuotaManager.scala (line 65)

Re: Review Request 33049: Patch for KAFKA-2084

2015-08-12 Thread Joel Koshy
> On June 17, 2015, 4:40 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/ClientQuotaMetrics.scala, line 1 > > > > > > Why was MockTime moved from test to main? > > Aditya Auradkar wrote: > Because I ne

Re: Review Request 33049: Patch for KAFKA-2084

2015-08-12 Thread Joel Koshy
> On Aug. 6, 2015, 4:17 p.m., Jun Rao wrote: > > A few more comments. > > > > We need to be careful with sensors at the client-id level. Clients can come > > and go (e.g. console consumer). We probably don't want to hold sensors that > > are not longer actively used since it takes memory. So,

[jira] [Commented] (KAFKA-2336) Changing offsets.topic.num.partitions after the offset topic is created breaks consumer group partition assignment

2015-08-12 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694558#comment-14694558 ] Joel Koshy commented on KAFKA-2336: --- Sorry I should not have assigned it to myself befor

[GitHub] kafka pull request: KAFKA-Junit3 Misusage

2015-08-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/135 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Resolved] (KAFKA-1782) Junit3 Misusage

2015-08-12 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-1782. -- Resolution: Fixed Issue resolved by pull request 135 [https://github.com/apache/kafka/pull/135]

[jira] [Commented] (KAFKA-1782) Junit3 Misusage

2015-08-12 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694602#comment-14694602 ] Guozhang Wang commented on KAFKA-1782: -- [~apakulov] Thanks for the patch, [~ewencp] h

[jira] [Assigned] (KAFKA-2244) Document Kafka metrics configuration properties

2015-08-12 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke reassigned KAFKA-2244: -- Assignee: Grant Henke > Document Kafka metrics configuration properties > -

Re: Review Request 33049: Patch for KAFKA-2084

2015-08-12 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33049/ --- (Updated Aug. 13, 2015, 4:24 a.m.) Review request for kafka, Joel Koshy and Jun

  1   2   >