[jira] [Commented] (KAFKA-873) Consider replacing zkclient with curator (with zkclient-bridge)

2015-08-03 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14651721#comment-14651721 ] Flavio Junqueira commented on KAFKA-873: +1 to have this one in in the next release

[jira] [Updated] (KAFKA-873) Consider replacing zkclient with curator (with zkclient-bridge)

2015-08-03 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Junqueira updated KAFKA-873: --- Fix Version/s: 0.8.3 > Consider replacing zkclient with curator (with zkclient-bridge) > --

[jira] [Commented] (KAFKA-873) Consider replacing zkclient with curator (with zkclient-bridge)

2015-08-03 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14651764#comment-14651764 ] Flavio Junqueira commented on KAFKA-873: Let me elaborate on my suggestion. Adoptin

[jira] [Issue Comment Deleted] (KAFKA-2120) Add a request timeout to NetworkClient

2015-08-03 Thread Stevo Slavic (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stevo Slavic updated KAFKA-2120: Comment: was deleted (was: If this is considered as must have for Kafka 0.8.3, please consider sett

[jira] [Updated] (KAFKA-2384) Override commit message title in kafka-merge-pr.py

2015-08-03 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2384: --- Summary: Override commit message title in kafka-merge-pr.py (was: Enable renaming commit message titl

[jira] [Commented] (KAFKA-2398) Transient test failure for SocketServerTest - Socket closed.

2015-08-03 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14651917#comment-14651917 ] Ismael Juma commented on KAFKA-2398: [~granthenke] described the reason in the followi

[jira] [Commented] (KAFKA-2384) Override commit message title in kafka-merge-pr.py

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14651951#comment-14651951 ] ASF GitHub Bot commented on KAFKA-2384: --- GitHub user ijuma opened a pull request:

[GitHub] kafka pull request: KAFKA-2384; Override commit message title in k...

2015-08-03 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/105 KAFKA-2384; Override commit message title in kafka-merge-pr.py You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka kafka-2384-override-com

[jira] [Updated] (KAFKA-2384) Override commit message title in kafka-merge-pr.py

2015-08-03 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2384: --- Reviewer: Guozhang Wang Status: Patch Available (was: In Progress) [~guozhang], I submitted a P

[jira] [Work started] (KAFKA-2384) Override commit message title in kafka-merge-pr.py

2015-08-03 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-2384 started by Ismael Juma. -- > Override commit message title in kafka-merge-pr.py > --

[jira] [Commented] (KAFKA-2398) Transient test failure for SocketServerTest - Socket closed.

2015-08-03 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652002#comment-14652002 ] Jiangjie Qin commented on KAFKA-2398: - Thanks, [~ijuma]. I saw this on Mac but not Yos

[jira] [Commented] (KAFKA-2388) subscribe(topic)/unsubscribe(topic) should either take a callback to allow user to handle exceptions or it should be synchronous.

2015-08-03 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652058#comment-14652058 ] Jason Gustafson commented on KAFKA-2388: [~becket_qin] If you don't mind, I can ta

[jira] [Commented] (KAFKA-1860) File system errors are not detected unless Kafka tries to write

2015-08-03 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652067#comment-14652067 ] Mayuresh Gharat commented on KAFKA-1860: [~guozhang] ping. > File system errors a

Re: Review Request 33620: Patch for KAFKA-1690

2015-08-03 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33620/#review93862 --- Thanks for the patch. A few more comments below. build.gradle (lin

[jira] [Commented] (KAFKA-1690) new java producer needs ssl support as a client

2015-08-03 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652110#comment-14652110 ] Jun Rao commented on KAFKA-1690: [~sriharsha], I made another pass of the patch and left s

[jira] [Commented] (KAFKA-1690) new java producer needs ssl support as a client

2015-08-03 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652118#comment-14652118 ] Ismael Juma commented on KAFKA-1690: [~junrao], fair enough. It will definitely be goo

[jira] [Updated] (KAFKA-2388) subscribe(topic)/unsubscribe(topic) should either take a callback to allow user to handle exceptions or it should be synchronous.

2015-08-03 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2388: Assignee: Onur Karaman (was: Jiangjie Qin) > subscribe(topic)/unsubscribe(topic) should either take a callb

[jira] [Commented] (KAFKA-2388) subscribe(topic)/unsubscribe(topic) should either take a callback to allow user to handle exceptions or it should be synchronous.

2015-08-03 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652126#comment-14652126 ] Dong Lin commented on KAFKA-2388: - [~hachikuji] Sorry, my bad.. [~onurkaraman] is working

[jira] [Commented] (KAFKA-2388) subscribe(topic)/unsubscribe(topic) should either take a callback to allow user to handle exceptions or it should be synchronous.

2015-08-03 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652146#comment-14652146 ] Jason Gustafson commented on KAFKA-2388: [~becket_qin] That works too! > subscrib

Re: Gauging Interest in adding Encryption to Kafka

2015-08-03 Thread Gwen Shapira
If I understand you correctly, you are saying that the kerberos keytab that the broker uses to authenticate with the KMS will be somewhere on the broker node and can be used by a malicious admin. I agree this is a valid concern. I am not opposed to client-side encryption, I am more concerned that

[jira] [Commented] (KAFKA-1716) hang during shutdown of ZookeeperConsumerConnector

2015-08-03 Thread Chris Barlock (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652197#comment-14652197 ] Chris Barlock commented on KAFKA-1716: -- We just upgraded to Kafka 0.8.2.1 and are now

[jira] [Commented] (KAFKA-2397) leave group request

2015-08-03 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652198#comment-14652198 ] Jason Gustafson commented on KAFKA-2397: [~onurkaraman] I like this idea. Wouldn't

[jira] [Resolved] (KAFKA-1360) Configure continuous integration (CI) for Kafka branches under active development

2015-08-03 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-1360. Resolution: Fixed There is also a job for GitHub pull requests: https://builds.apache.org/job/kafka

[jira] [Commented] (KAFKA-2397) leave group request

2015-08-03 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652231#comment-14652231 ] Jiangjie Qin commented on KAFKA-2397: - I would prefer extending heartbeat to indicate

[jira] [Created] (KAFKA-2399) Replace Stream.continually with Iterator.continually

2015-08-03 Thread Ismael Juma (JIRA)
Ismael Juma created KAFKA-2399: -- Summary: Replace Stream.continually with Iterator.continually Key: KAFKA-2399 URL: https://issues.apache.org/jira/browse/KAFKA-2399 Project: Kafka Issue Type: Bu

Re: Review Request 33620: Patch for KAFKA-1690

2015-08-03 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33620/#review93939 --- clients/src/main/java/org/apache/kafka/clients/ClientUtils.java (li

[GitHub] kafka pull request: KAFKA-2399; Replace `Stream.continually` with ...

2015-08-03 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/106 KAFKA-2399; Replace `Stream.continually` with `Iterator.continually` `Iterator.continually` is more efficient (it doesn't allocate a `Cons` instance per element) and we don't need the extra functionali

[jira] [Commented] (KAFKA-2399) Replace Stream.continually with Iterator.continually

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652297#comment-14652297 ] ASF GitHub Bot commented on KAFKA-2399: --- GitHub user ijuma opened a pull request:

[jira] [Updated] (KAFKA-2399) Replace Stream.continually with Iterator.continually

2015-08-03 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2399: --- Assignee: Ismael Juma Status: Patch Available (was: Open) > Replace Stream.continually with Ite

Re: Gauging Interest in adding Encryption to Kafka

2015-08-03 Thread Alejandro Abdelnur
Doing encryption on the client has the following benefits (most of them already mentioned in the thread): * brokers don't have additional CPU load * brokers never see the data in unencrypted form (Kafka admins cannot snoop) * secure multi-tenancy (keys are 100% on the client space) * no need to se

Re: Review Request 33125: Add comment to timing fix

2015-08-03 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33125/#review93953 --- clients/src/test/java/org/apache/kafka/clients/MetadataTest.java (l

[jira] [Commented] (KAFKA-2397) leave group request

2015-08-03 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652386#comment-14652386 ] Onur Karaman commented on KAFKA-2397: - Hey everyone. There's a difference between the

[GitHub] kafka pull request: KAFKA-2384; Override commit message title in k...

2015-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/105 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (KAFKA-2384) Override commit message title in kafka-merge-pr.py

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652397#comment-14652397 ] ASF GitHub Bot commented on KAFKA-2384: --- Github user asfgit closed the pull request

[jira] [Updated] (KAFKA-2384) Override commit message title in kafka-merge-pr.py

2015-08-03 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2384: - Resolution: Fixed Status: Resolved (was: Patch Available) Issue resolved by pull request

[jira] [Updated] (KAFKA-313) Add JSON/CSV output and looping options to ConsumerGroupCommand

2015-08-03 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-313: --- Status: In Progress (was: Patch Available) Moving to "in progress" until new patch is submitted fixing

[jira] [Comment Edited] (KAFKA-2397) leave group request

2015-08-03 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652386#comment-14652386 ] Onur Karaman edited comment on KAFKA-2397 at 8/3/15 8:48 PM: -

[jira] [Commented] (KAFKA-2384) Override commit message title in kafka-merge-pr.py

2015-08-03 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652498#comment-14652498 ] Guozhang Wang commented on KAFKA-2384: -- [~ijuma] There seems some unicode encoding er

[jira] [Reopened] (KAFKA-2384) Override commit message title in kafka-merge-pr.py

2015-08-03 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang reopened KAFKA-2384: -- > Override commit message title in kafka-merge-pr.py > -

[GitHub] kafka pull request: MINOR: Added to .gitignore Kafka server logs d...

2015-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/94 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[jira] [Updated] (KAFKA-1684) Implement TLS/SSL authentication

2015-08-03 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1684: Affects Version/s: (was: 0.9.0) > Implement TLS/SSL authentication > ---

[jira] [Updated] (KAFKA-1684) Implement TLS/SSL authentication

2015-08-03 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1684: Fix Version/s: 0.8.3 > Implement TLS/SSL authentication > > >

[jira] [Created] (KAFKA-2400) Expose heartbeat frequency in new consumer configuration

2015-08-03 Thread Jason Gustafson (JIRA)
Jason Gustafson created KAFKA-2400: -- Summary: Expose heartbeat frequency in new consumer configuration Key: KAFKA-2400 URL: https://issues.apache.org/jira/browse/KAFKA-2400 Project: Kafka Is

Kafka KIP discussion tomorrow

2015-08-03 Thread Jun Rao
Hi, Everyone, We will have a Kafka KIP discussion tomorrow at 11am PST. The following is the agenda. If you are interested in participating but haven't received an invite, please let me know. Agenda: 1) KIP-28: Add a processor client 2) KIP-27: Conditional publish 3) go through jira backlogs http

[GitHub] kafka pull request: KAFKA-2386; increase timeouts for transient te...

2015-08-03 Thread hachikuji
GitHub user hachikuji opened a pull request: https://github.com/apache/kafka/pull/107 KAFKA-2386; increase timeouts for transient test failure in ConsumerCoordinatorResponseTests There are two race conditions in the test case "testGenerationIdIncrementsOnRebalance." First, a delay

[jira] [Commented] (KAFKA-2386) Transient test failure: testGenerationIdIncrementsOnRebalance

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652636#comment-14652636 ] ASF GitHub Bot commented on KAFKA-2386: --- GitHub user hachikuji opened a pull request

[jira] [Commented] (KAFKA-2400) Expose heartbeat frequency in new consumer configuration

2015-08-03 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652663#comment-14652663 ] Jay Kreps commented on KAFKA-2400: -- Also we should set good defaults: - session timeout

[jira] [Commented] (KAFKA-1690) new java producer needs ssl support as a client

2015-08-03 Thread Rajasekar Elango (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652678#comment-14652678 ] Rajasekar Elango commented on KAFKA-1690: - [~harsha_ch] Thanks for documentation,

[jira] [Commented] (KAFKA-2397) leave group request

2015-08-03 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652686#comment-14652686 ] Jay Kreps commented on KAFKA-2397: -- Nice summary [~onurkaraman]. I agree that adding a f

[jira] [Comment Edited] (KAFKA-2397) leave group request

2015-08-03 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652686#comment-14652686 ] Jay Kreps edited comment on KAFKA-2397 at 8/3/15 10:36 PM: --- Nice

[jira] [Commented] (KAFKA-2386) Transient test failure: testGenerationIdIncrementsOnRebalance

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652696#comment-14652696 ] ASF GitHub Bot commented on KAFKA-2386: --- Github user asfgit closed the pull request

[GitHub] kafka pull request: KAFKA-2386; increase timeouts for transient te...

2015-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/107 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Resolved] (KAFKA-2386) Transient test failure: testGenerationIdIncrementsOnRebalance

2015-08-03 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira resolved KAFKA-2386. - Resolution: Fixed Assignee: Jason Gustafson Reviewer: Gwen Shapira Fix Ver

[jira] [Assigned] (KAFKA-2285) Logging trait obfuscates call site information

2015-08-03 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke reassigned KAFKA-2285: -- Assignee: Grant Henke > Logging trait obfuscates call site information > --

[jira] [Commented] (KAFKA-2285) Logging trait obfuscates call site information

2015-08-03 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652767#comment-14652767 ] Ismael Juma commented on KAFKA-2285: Also see https://issues.apache.org/jira/plugins/s

[jira] [Commented] (KAFKA-1690) new java producer needs ssl support as a client

2015-08-03 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652805#comment-14652805 ] Jun Rao commented on KAFKA-1690: [~erajasekar], for 3, the SSL patch only works for the ne

[jira] [Commented] (KAFKA-2285) Logging trait obfuscates call site information

2015-08-03 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652841#comment-14652841 ] Ismael Juma commented on KAFKA-2285: Better than a macro would be using @inline, but s

Re: Review Request 36722: Patch for KAFKA-2332

2015-08-03 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36722/#review93833 --- Ship it! core/src/main/scala/kafka/consumer/FetchRequestAndRespons

Re: Review Request 33049: Patch for KAFKA-2084

2015-08-03 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33049/#review93965 --- Looks good overall. I have a few more minor comments/suggestions. Ap

Re: Review Request 33378: Patch for KAFKA-2136

2015-08-03 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33378/#review93979 --- This patch also needs a rebase. core/src/main/scala/kafka/server/R

[jira] [Commented] (KAFKA-2231) Deleting a topic fails

2015-08-03 Thread Laurent Raufaste (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652909#comment-14652909 ] Laurent Raufaste commented on KAFKA-2231: - FYI I have the same problem. On a prist

Re: Review Request 36722: Patch for KAFKA-2332

2015-08-03 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36722/ --- (Updated Aug. 4, 2015, 1:23 a.m.) Review request for kafka. Bugs: KAFKA-2332

[jira] [Updated] (KAFKA-2332) Add quota metrics to old producer and consumer

2015-08-03 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-2332: Attachment: KAFKA-2332_2015-08-03_18:22:53.patch > Add quota metrics to old producer and consumer >

[jira] [Commented] (KAFKA-2332) Add quota metrics to old producer and consumer

2015-08-03 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652915#comment-14652915 ] Dong Lin commented on KAFKA-2332: - Updated reviewboard https://reviews.apache.org/r/36722/

Re: Review Request 36722: Patch for KAFKA-2332

2015-08-03 Thread Dong Lin
> On Aug. 4, 2015, 12:36 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/consumer/FetchRequestAndResponseStats.scala, line > > 25 > > > > > > unused import Thanks for the catch. - Dong

Re: Review Request 36722: Patch for KAFKA-2332

2015-08-03 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36722/ --- (Updated Aug. 4, 2015, 1:24 a.m.) Review request for kafka. Bugs: KAFKA-2332

Re: Gauging Interest in adding Encryption to Kafka

2015-08-03 Thread Don Bosco Durai
>The client-broker protocol would have to be augmented to carry the >encrypted encryption key, plus logic to handle redistribution to existing >clients due to key rotation. This is a good point. HDFS has the encryption zone concept, which could be akin to a topic. The keys in HDFS are per file leve

Re: Review Request 33049: Patch for KAFKA-2084

2015-08-03 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33049/#review93991 --- clients/src/main/java/org/apache/kafka/common/metrics/Quota.java (l

Re: [DISCUSS] KIP-27 - Conditional Publish

2015-08-03 Thread Jun Rao
A couple of thoughts on the commit log use case. Suppose that we want to maintain multiple replicas of a K/V store backed by a shared Kafka topic/partition as a commit log. There are two possible ways to use Kafka as a commit log. 1. The first approach allows multiple producers to publish to Kafka

[jira] [Created] (KAFKA-2401) Fix transient failure of ProducerSendTest.testCloseWithZeroTimeoutFromSenderThread()

2015-08-03 Thread Jiangjie Qin (JIRA)
Jiangjie Qin created KAFKA-2401: --- Summary: Fix transient failure of ProducerSendTest.testCloseWithZeroTimeoutFromSenderThread() Key: KAFKA-2401 URL: https://issues.apache.org/jira/browse/KAFKA-2401 Proj

[jira] [Created] (KAFKA-2402) Broker should create zkpath /isr_change_notification if it does not exist when updating ISR.

2015-08-03 Thread Jiangjie Qin (JIRA)
Jiangjie Qin created KAFKA-2402: --- Summary: Broker should create zkpath /isr_change_notification if it does not exist when updating ISR. Key: KAFKA-2402 URL: https://issues.apache.org/jira/browse/KAFKA-2402

[GitHub] kafka pull request: KAFKA-2402: Create IsrChangeNotificationPath w...

2015-08-03 Thread becketqin
GitHub user becketqin opened a pull request: https://github.com/apache/kafka/pull/108 KAFKA-2402: Create IsrChangeNotificationPath when server statrs. You can merge this pull request into a Git repository by running: $ git pull https://github.com/becketqin/kafka KAFKA-2402 Al

[jira] [Commented] (KAFKA-2402) Broker should create zkpath /isr_change_notification if it does not exist when updating ISR.

2015-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14653095#comment-14653095 ] ASF GitHub Bot commented on KAFKA-2402: --- GitHub user becketqin opened a pull request