[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652110#comment-14652110 ]
Jun Rao commented on KAFKA-1690: -------------------------------- [~sriharsha], I made another pass of the patch and left some comments on the RB. [~ijuma] and [~dong lin], thanks for the review comments. Those are valuable. The SSL patch is relatively big since there is no easy way to break it into smaller chunks. Harsha has been working very diligently on this and the patch is close to be committed. To help him out, I'd suggest we only focus on blocking issues now so that the patch can be committed soon. We can file followup jira for non-critical issues (e.g., coding style). > new java producer needs ssl support as a client > ----------------------------------------------- > > Key: KAFKA-1690 > URL: https://issues.apache.org/jira/browse/KAFKA-1690 > Project: Kafka > Issue Type: Sub-task > Reporter: Joe Stein > Assignee: Sriharsha Chintalapani > Fix For: 0.8.3 > > Attachments: KAFKA-1690.patch, KAFKA-1690.patch, > KAFKA-1690_2015-05-10_23:20:30.patch, KAFKA-1690_2015-05-10_23:31:42.patch, > KAFKA-1690_2015-05-11_16:09:36.patch, KAFKA-1690_2015-05-12_16:20:08.patch, > KAFKA-1690_2015-05-15_07:18:21.patch, KAFKA-1690_2015-05-20_14:54:35.patch, > KAFKA-1690_2015-05-21_10:37:08.patch, KAFKA-1690_2015-06-03_18:52:29.patch, > KAFKA-1690_2015-06-23_13:18:20.patch, KAFKA-1690_2015-07-20_06:10:42.patch, > KAFKA-1690_2015-07-20_11:59:57.patch, KAFKA-1690_2015-07-25_12:10:55.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)