[jira] [Commented] (KAFKA-1581) Log cleaner should have an option to ignore messages without keys

2015-04-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14501228#comment-14501228 ] Manikumar Reddy commented on KAFKA-1581: [~jjkoshy] I think this can be closed no

[jira] [Commented] (KAFKA-1758) corrupt recovery file prevents startup

2015-04-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14501295#comment-14501295 ] Manikumar Reddy commented on KAFKA-1758: [~jkreps] Can I get review for this simpl

[jira] [Updated] (KAFKA-2088) kafka-console-consumer.sh should not create zookeeper path when no brokers found and chroot was set in zookeeper.connect

2015-04-18 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2088: --- Resolution: Fixed Fix Version/s: 0.8.3 Status: Resolved (was: Patch Available) Thanks for t

Re: Review Request 31369: Patch for KAFKA-1982

2015-04-18 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369/#review80607 --- There seems to be a bunch of checkstyle failures. Could you address

[jira] [Updated] (KAFKA-2036) Consumer and broker have different networks

2015-04-18 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2036: --- Status: In Progress (was: Patch Available) Thanks for the patch. The new consumer/producer client will be usi

[jira] [Updated] (KAFKA-1994) Evaluate performance effect of chroot check on Topic creation

2015-04-18 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1994: --- Resolution: Fixed Fix Version/s: 0.8.3 Status: Resolved (was: Patch Available) Thanks for t

Jenkins build is back to normal : Kafka-trunk #466

2015-04-18 Thread Apache Jenkins Server
See

Re: Review Request 33088: add heartbeat to coordinator

2015-04-18 Thread Onur Karaman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33088/ --- (Updated April 18, 2015, 5:16 p.m.) Review request for kafka. Bugs: KAFKA-133

[jira] [Commented] (KAFKA-1334) Add failure detection capability to the coordinator / consumer

2015-04-18 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14501479#comment-14501479 ] Onur Karaman commented on KAFKA-1334: - Updated reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1334) Add failure detection capability to the coordinator / consumer

2015-04-18 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Onur Karaman updated KAFKA-1334: Attachment: KAFKA-1334_2015-04-18_10:16:23.patch > Add failure detection capability to the coordinat

Build failed in Jenkins: Kafka-trunk #467

2015-04-18 Thread Apache Jenkins Server
See Changes: [junrao] kafka-1994; Evaluate performance effect of chroot check on Topic creation; patched by Ashish Singh; reviewed by Gwen Shapira and Jun Rao -- [...truncated 1551 lines...] kafka.ap

Re: Review Request 33088: add heartbeat to coordinator

2015-04-18 Thread Onur Karaman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33088/ --- (Updated April 18, 2015, 7:16 p.m.) Review request for kafka. Bugs: KAFKA-133

[jira] [Commented] (KAFKA-1334) Add failure detection capability to the coordinator / consumer

2015-04-18 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14501538#comment-14501538 ] Onur Karaman commented on KAFKA-1334: - Updated reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1334) Add failure detection capability to the coordinator / consumer

2015-04-18 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Onur Karaman updated KAFKA-1334: Attachment: KAFKA-1334_2015-04-18_12:16:39.patch > Add failure detection capability to the coordinat

Re: Review Request 33088: add heartbeat to coordinator

2015-04-18 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33088/#review80619 --- core/src/main/scala/kafka/coordinator/DelayedHeartbeat.scala

[jira] [Created] (KAFKA-2132) Move Log4J appender to clients module

2015-04-18 Thread Gwen Shapira (JIRA)
Gwen Shapira created KAFKA-2132: --- Summary: Move Log4J appender to clients module Key: KAFKA-2132 URL: https://issues.apache.org/jira/browse/KAFKA-2132 Project: Kafka Issue Type: Improvement

[jira] [Updated] (KAFKA-1554) Corrupt index found on clean startup

2015-04-18 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1554: --- Status: In Progress (was: Patch Available) > Corrupt index found on clean startup > -

[jira] [Updated] (KAFKA-1420) Replace AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZK with TestUtils.createTopic in unit tests

2015-04-18 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1420: --- Status: In Progress (was: Patch Available) > Replace AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZ

Re: Review Request 24006: Patch for KAFKA-1420

2015-04-18 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24006/#review80620 --- Thanks for the patch. Sorry for the late review. A few comments belo

[jira] [Resolved] (KAFKA-2116) Add code that uses new consumer to system_tests

2015-04-18 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira resolved KAFKA-2116. - Resolution: Duplicate > Add code that uses new consumer to system_tests >

[jira] [Commented] (KAFKA-1974) NPE in SelectorTest on trunk

2015-04-18 Thread Eddie Hao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14501667#comment-14501667 ] Eddie Hao commented on KAFKA-1974: -- Hi I just ran this test from HEAD and everything pass

[jira] [Updated] (KAFKA-2121) error handling in KafkaProducer constructor

2015-04-18 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Zhen Wu updated KAFKA-2121: -- Attachment: KAFKA-2121_2015-04-18_20:09:20.patch > error handling in KafkaProducer constructor >

[jira] [Commented] (KAFKA-2121) error handling in KafkaProducer constructor

2015-04-18 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14501669#comment-14501669 ] Steven Zhen Wu commented on KAFKA-2121: --- Updated reviewboard https://reviews.apache.

Re: Review Request 33242: Patch for KAFKA-2121

2015-04-18 Thread Steven Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33242/ --- (Updated April 19, 2015, 3:09 a.m.) Review request for kafka. Bugs: KAFKA-212

Re: Review Request 33242: Patch for KAFKA-2121

2015-04-18 Thread Steven Wu
> On April 16, 2015, 5:29 p.m., Ewen Cheslack-Postava wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java, > > line 548 > > > > > > One idea for making this less verbose and redundant