Re: [DISCUSSION] KIP-15 close(timeout) for producer

Cool. I think blocking is good or alternately throwing an exception directly from close(). Basically I would just worry about subtly doing something slightly different from what the user asked for as it will be hard to notice that behavior difference. -Jay On Sat, Mar 14, 2015 at 5:48 PM, Jiangj

Re: Review Request 31967: Patch for KAFKA-1546

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31967/#review76511 --- core/src/main/scala/kafka/cluster/Partition.scala

Re: [VOTE] KIP-16: Replica Lag Tuning

+1 on the KIP. Minor nit: "it is deemed to not be in ISR because it is not caught up" => "it is deemed to not be in the ISR because it has fallen behind for more than a certain amount of time as controlled by this config" Also took a look at the patch. Looks correct, left review comments. Thanks f

Re: [VOTE] KIP-16: Replica Lag Tuning

+1 one more minor nit, please update the KIP with the link to the discuss thread too. ~ Joe Stein - - - - - - - - - - - - - - - - - http://www.stealth.ly - - - - - - - - - - - - - - - - - On Sun, Mar 15, 2015 at 5:27 PM, Neha Narkhede wrote: > +1 on the KIP. Minor nit: "it is deemed to not

[jira] [Commented] (KAFKA-1546) Automate replica lag tuning

[ https://issues.apache.org/jira/browse/KAFKA-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14362581#comment-14362581 ] Neha Narkhede commented on KAFKA-1546: -- [~aauradkar] Thanks for the patch. Overall, t

Re: [DISCUSSION] KIP-15 close(timeout) for producer

> > And I also agree it is better if we can make producer block when > close() is called from sender thread so user will notice something went > wrong. This isn't a great experience either. Why can't we just throw an exception for a behavior we know is incorrect and we'd like the user to know. Bl

Re: [DISCUSSION] KIP-15 close(timeout) for producer

Yeah I agree we should not silently change the behavior of the function with the given parameters; and I would prefer error-logging-and-shutdown over blocking when close(>0) is used, since as Neha suggested blocking would also not proceed with sending any data, bu will just let users to realize the

Re: [DISCUSS] KIP 16 - Replica lag tuning

The wiki page and the patch LGTM. Just a couple of minor comments: On the wiki page, definition of* replica.lag.time.max.ms *: just mention that "If a follower hasn't sent..." is its original definition, and now we are adding another aspect in addition to this.

Re: [VOTE] KIP-16: Replica Lag Tuning

+1 on the KIP. On Sun, Mar 15, 2015 at 2:56 PM, Joe Stein wrote: > +1 > > one more minor nit, please update the KIP with the link to the discuss > thread too. > > ~ Joe Stein > - - - - - - - - - - - - - - - - - > > http://www.stealth.ly > - - - - - - - - - - - - - - - - - > > On Sun, Mar 15, 2

[jira] [Commented] (KAFKA-1682) Security for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14362638#comment-14362638 ] Jun Rao commented on KAFKA-1682: Just so that everyone knows the sequencing and who is wor

[jira] [Assigned] (KAFKA-1685) Implement TLS/SSL tests

[ https://issues.apache.org/jira/browse/KAFKA-1685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani reassigned KAFKA-1685: - Assignee: Sriharsha Chintalapani > Implement TLS/SSL tests >

[jira] [Commented] (KAFKA-1682) Security for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14362644#comment-14362644 ] Sriharsha Chintalapani commented on KAFKA-1682: --- Also 5. KAFKA-1688(Authoriz

[jira] [Comment Edited] (KAFKA-1682) Security for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14362644#comment-14362644 ] Sriharsha Chintalapani edited comment on KAFKA-1682 at 3/16/15 1:14 AM:

Re: Review Request 31967: Patch for KAFKA-1546

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31967/#review76517 --- Thanks for the patch. A few comments below. core/src/main/scala/ka

Re: [VOTE] KIP-16: Replica Lag Tuning

+1 on the approach. Much better than before. Thanks, Jun On Fri, Mar 13, 2015 at 9:54 AM, Aditya Auradkar < aaurad...@linkedin.com.invalid> wrote: > Details in the KIP, Jira and RB. > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP+16+:+Automated+Replica+Lag+Tuning > https://issues.ap

RE: [VOTE] KIP-16: Replica Lag Tuning

Thanks. We have 5 binding +1s. I'll update the KIP with your comments and mark as accepted. Aditya From: Jun Rao [j...@confluent.io] Sent: Sunday, March 15, 2015 8:41 PM To: dev@kafka.apache.org Subject: Re: [VOTE] KIP-16: Replica Lag Tuning +1 on the ap

RE: [VOTE] KIP-16: Replica Lag Tuning

Rather, 6 binding +1's. Aditya From: Aditya Auradkar Sent: Sunday, March 15, 2015 10:39 PM To: dev@kafka.apache.org Subject: RE: [VOTE] KIP-16: Replica Lag Tuning Thanks. We have 5 binding +1s. I'll update the KIP with your comments and mark as accepted.